ELECTRON-790: add japanese localisation support for "Learn more" menu item (#508)

The menu item "Learn More" under the "Help" menu doesn't take a user to the appropriate page when Japanese is set as the user's language. This fixes the issue
This commit is contained in:
Vishwas Shashidhar 2018-09-27 12:07:48 +05:30 committed by GitHub
parent f345660129
commit faae7a6f2a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 6 additions and 1 deletions

View File

@ -105,7 +105,8 @@ function getTemplate(app) {
{
label: i18n.getMessageFor('Learn More'),
click() {
electron.shell.openExternal('https://www.symphony.com');
let symUrl = i18n.getMessageFor('Symphony Url');
electron.shell.openExternal(symUrl);
}
},
{

View File

@ -58,6 +58,7 @@
"Flash Notification in Taskbar": "Flash Notification in Taskbar",
"Help": "Help",
"Help Url": "https://support.symphony.com",
"Symphony Url": "https://symphony.com/en-US",
"Hide Others": "Hide Others",
"Hide Symphony": "Hide Symphony",
"Learn More": "Learn More",

View File

@ -56,6 +56,7 @@
"Flash Notification in Taskbar": "Flash Notification in Taskbar",
"Help": "Help",
"Help Url": "https://support.symphony.com",
"Symphony Url": "https://symphony.com/en-US",
"Hide Others": "Hide Others",
"Hide Symphony": "Hide Symphony",
"Learn More": "Learn More",

View File

@ -58,6 +58,7 @@
"Flash Notification in Taskbar": "タスクバーの通知を点滅",
"Help": "ヘルプ",
"Help Url": "https://support.symphony.com/hc/ja",
"Symphony Url": "https://symphony.com/ja",
"Hide Others": "他を隠す",
"Hide Symphony": "Symphonyを隠す",
"Learn More": "詳細",

View File

@ -56,6 +56,7 @@
"Flash Notification in Taskbar": "タスクバーの通知を点滅",
"Help": "ヘルプ",
"Help Url": "https://support.symphony.com/hc/ja",
"Symphony Url": "https://symphony.com/ja",
"Hide Others": "他を隠す",
"Hide Symphony": "Symphonyを隠す",
"Learn More": "詳細",