GreenPolyProducts/cantera
5
0
Fork 0
mirror of https://github.com/Cantera/cantera.git synced 2026-08-17 16:35:17 -05:00
Code Issues Packages Projects Releases Wiki Activity

[thermo] Avoid spurious WaterPropsIAPWS::density failures

Browse Source 
Some initial guesses fail (see GitHUb issue #577, or starting with an initial
density guess equl to the critical density); running an alternative initial
guess prevents spurious failures (fix is a band-aid).
This commit is contained in:
Ingmar Schoegl
2021-01-29 13:39:28 -05:00
committed by Ray Speth
parent ac1274fa0a
commit f092244bec
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/thermo/WaterPropsIAPWS.cpp
+5 -3
View File
@@ -83,9 +83,6 @@ doublereal WaterPropsIAPWS::density(doublereal temperature, doublereal pressure,
// Catch critical point, as no solution is found otherwise
setState_TR(temperature, Rho_c);
return Rho_c;
} else if (fabs(rhoguess - Rho_c) / Rho_c < 1.e-8) {
// Starting a search with the critical density would fail
rhoguess *= .9;
}
doublereal deltaGuess = 0.0;
if (rhoguess == -1.0) {
@@ -117,6 +114,11 @@ doublereal WaterPropsIAPWS::density(doublereal temperature, doublereal pressure,
deltaGuess = rhoguess / Rho_c;
setState_TR(temperature, rhoguess);
doublereal delta_retn = m_phi.dfind(p_red, tau, deltaGuess);
if (delta_retn <= 0) {
// No solution found for first initial guess; perturb initial guess once
// to avoid spurious failures (band-aid fix)
delta_retn = m_phi.dfind(p_red, tau, 0.9 * deltaGuess);
}
doublereal density_retn;
if (delta_retn > 0.0) {
delta = delta_retn;