Fixes setup_cantera and the post-install message to reference the path
of the Python module on the target system rather than the staging
directory.
Also, generated .pyc files no long specify the path in the staging
directory. This has no effect on the use of the .pyc files, but helps
avoid warnings/errors from packaging system linters (notably, on
FreeBSD).
Fixes#1094
Deprecate Kinetics.*_stoich_coeffs() method in favor of property:
Behavior will change after Cantera 2.6; for new behavior, new properties
Kinetics.*_stoich_coefficients are implemented
as Kinetics::m_irrevProductManager is only used in conjunction with
Kinetics::m_revProductManager, a new Kinetics::m_productManager provides
for simpler code.
The 'Kinetics::finalizeSetup' method executes code after all reactions
have been added. The new flag 'finalize' is added to 'Kinetics::addReaction'
which determines whether 'finalizeSetup' is executed. While the default
is 'true', imports within 'KineticsManager' use 'addReaction' with the
flag set to 'false'.
Several internal methods defined for C1, C2, C3, and C_AnyN are unused;
as there are no simple accessor methods defined in StoichManagerN,
deprecation appears not to be required.
* Use consistent interface based on Array2D
* Use column-major consistently in internal calculations
* Deprecate Chebyshev::coeffs and Chebyshev::setup
Compilation with GNU g++ currently raises the following warning.
warning: 'nSolnValues' may be used uninitialized in this function [-Wmaybe-uninitialized]
The warning is resolved by providing an (invalid) initial value; the
value is overwritten by a subsequent (pre-existing) if-else tree.
'scons help' reports setting values in terms of 'yes' and 'no' rather than
boolean flags that are otherwise used internally. This commit ensures that
documentation for the newly added flag 'legacy-rate-constants' is
consistent with this convention; accordingly, the setting is either enabled
or disabled.
In the default case where the 'python_prefix' variable is '$prefix',
the Python module would get installed to the literal '$prefix'
subdirectory of the staging directory, instead of actually expanding
the '$prefix' variable.
Fixes a regression introduced in c7a5d1885e.
- Test that `enthalpy_mole = sum(X_k * h_k)` for `IdealSolidSolnPhase`
class, where `X_k` is mole fraction and `h_k` partial molar enthalpy.
- Also test the pressure independence of this equality, by verifying at
pressures 1 atm and 2 atm.
