Ray Speth
a23f2da352
[CI] Always run all linter steps
2023-08-06 10:22:41 -04:00
Ray Speth
2a0e4e95f3
[CI] Move lint checks to a separate workflow
2023-08-06 10:22:41 -04:00
Ray Speth
c86220ecfe
[CI] Add linter check for misleading Doxygen blocks
2023-08-06 10:22:41 -04:00
Ray Speth
3332319f85
[CI] Relax timeouts on for Intel compiler setup
2023-08-05 16:26:32 -04:00
Ray Speth
53396d4414
Clean up line wrapping and indentation
2023-08-05 16:26:32 -04:00
Ray Speth
c50b8b4faf
Fix Matlab toolbox compilation
...
This code isn't part of namespace Cantera, so can't use the
typedefs that are specified in that namespace.
2023-08-05 16:26:32 -04:00
Ingmar Schoegl
25f6834da9
Improve formatting
2023-08-05 16:26:32 -04:00
Ingmar Schoegl
64ade35c22
Using std::string
2023-08-05 16:26:32 -04:00
Ingmar Schoegl
0df90be93e
Using std::map
2023-08-05 16:26:32 -04:00
Ingmar Schoegl
ddd803c630
Using std::function
2023-08-05 16:26:32 -04:00
Ingmar Schoegl
8f320c217c
Using std::pair
2023-08-05 16:26:32 -04:00
Ingmar Schoegl
3dae4d458b
Using std::unique_ptr
2023-08-05 16:26:32 -04:00
Ingmar Schoegl
e482e13ca2
Using std::shared_ptr
2023-08-05 16:26:32 -04:00
Ingmar Schoegl
1b81689d40
Using std::vector
2023-08-05 16:26:32 -04:00
Ingmar Schoegl
c09611b165
Using std::make_shared
2023-08-05 16:26:32 -04:00
Ingmar Schoegl
86b2a139c7
Replace doublereal
2023-08-05 16:26:32 -04:00
Ingmar Schoegl
845a551277
Replace vector_fp
2023-08-05 16:26:32 -04:00
Ingmar Schoegl
9adc594593
Replace vector_int
2023-08-05 16:26:32 -04:00
Ray Speth
e0a2f112f7
[Reactor] Fix getting sensitivities after calls to advance
...
Previously, values would be returned for the sensitivity at the
last internal timestep of the integrator, rather than being interpolated
to the user-specified integration time.
2023-08-04 14:47:58 -05:00
Ray Speth
222b0ebcf6
Mark Reactor/ReactorNet methods as const
2023-08-04 14:47:58 -05:00
Ray Speth
e6c7030735
[Reactor] Improve CVODES error handling
...
Include the name of the return code flag, not just its numeric value,
and the CVODES-generated error message for all errors.
2023-08-04 14:47:58 -05:00
Ray Speth
3ec4577a86
[Reactor] Improve error message when advancing to past time
...
Resolves #1195
2023-08-04 14:47:58 -05:00
Ray Speth
0b80608642
[CI] Test Sundials 6.6
2023-08-04 14:47:58 -05:00
Ray Speth
ce797baffb
[Reactor] Always use "one step" mode with SUNDIALS integrators
...
Do the interpolation required for "advance" explicitly, rather
than relying on SUNDIALS to do it as part of the call to CVode() or
IDASolve().
This circumvents a change in behavior introduced in SUNDIALS 6.6.
Fixes #1554 .
2023-08-04 14:47:58 -05:00
Ingmar Schoegl
c9a6f818a1
Add instructions for std:: scope resolution
2023-08-04 15:47:40 -04:00
Ingmar Schoegl
fe67a191da
Update Doxygen style instructions
...
Additional guidance for Doxygen comments should help improve the
quality of generated documentation.
2023-08-04 15:47:40 -04:00
Ingmar Schoegl
5c0490b7b9
[docs] Create anchor for member section
...
See https://github.com/doxygen/doxygen/issues/8320#issuecomment-1230584554
2023-08-04 14:01:48 -04:00
Ingmar Schoegl
9c2441bcfe
[docs] Improve documentation of Kinetics derivatives
2023-08-04 14:01:48 -04:00
Ingmar Schoegl
ceec659d60
[unittest] Add Kinetics derivative tests
...
Unit tests match example in Kinetics derivative documentation.
2023-08-04 14:01:48 -04:00
Ingmar Schoegl
6ba497c392
Use 'using std::set'
2023-08-03 15:35:50 -04:00
Ingmar Schoegl
42ed2be23e
Remove unused MaxExp constant
2023-08-03 15:35:50 -04:00
Ingmar Schoegl
02b1fbe6f8
Remove unused typedef grouplist_t
2023-08-03 15:35:50 -04:00
Ingmar Schoegl
0041441400
Standardize Composition typedef
2023-08-03 15:35:50 -04:00
Ingmar Schoegl
3478d0e481
[docs] Add Smith and Missen to bibtex
2023-08-03 12:45:31 -05:00
Ingmar Schoegl
31c5acfc92
[docs] Add missing detailed description
2023-08-03 12:45:31 -05:00
Ingmar Schoegl
dc06d7eb19
[docs] Replace additional instances of /*!
2023-08-03 12:45:31 -05:00
Ingmar Schoegl
b4cde19d61
[docs] Move 1D radiation comments to Doxygen
2023-08-03 12:45:31 -05:00
Ingmar Schoegl
82aec962d3
[docs] Improve SolutionArray documentation
2023-08-03 12:45:31 -05:00
Ingmar Schoegl
d249b2bfa9
[docs] Add citation
2023-08-03 12:45:31 -05:00
Ingmar Schoegl
8047989ff5
[docs] Fix Doxygen autobrief
2023-08-03 12:45:31 -05:00
Ingmar Schoegl
4dd28c417a
[docs] Fix brief documentation
2023-08-02 15:42:39 -05:00
Ingmar Schoegl
3b81b72057
[docs] Fix broken Doxygen links
2023-08-02 15:42:39 -05:00
Ingmar Schoegl
40b6ae36a1
[docs] Tweak signature to avoid Doxygen warning
2023-08-02 15:42:39 -05:00
Ingmar Schoegl
c4d8e5e05c
[docs] Add docstrings to explicitly linked class variables
2023-08-02 15:42:39 -05:00
Ingmar Schoegl
e1f6b82ba6
[docs] Add missing parameters
...
All parameters have to be listed to remove warnings. For arguments
with known interpretation, a docstring is added.
2023-08-02 15:42:39 -05:00
Ingmar Schoegl
054cb80b18
[docs] Fix Doxygen warning about group ending
...
Part of the group extent was outside of the namespace block.
2023-08-02 15:42:39 -05:00
Ingmar Schoegl
e2e5e1b777
[docs] Add spaces between Doxygen and LaTeX commands
2023-08-01 19:22:18 -04:00
Ingmar Schoegl
093ade858f
[docs] Differentiate Doxygen from LaTeX commands
2023-08-01 19:22:18 -04:00
Ingmar Schoegl
5b07e7fb1f
[docs] Make Doxygen style more consistent (con't)
2023-08-01 10:23:06 -04:00
Ingmar Schoegl
30d3412c61
[docs] Make Doxygen commands more consistent
...
Use @ref rather than \ref for all cross-references (about half
of the references used one or the other style); also, replace
backslash in a couple of other less commonly used Doxygen commands.
2023-08-01 10:23:06 -04:00
