Daniel Freedman
7d6d7152be
Merge pull request #5577 from Polymer/ie-placeholder-binding
...
Workaround bindings to textarea.placeholder in IE
2019-07-30 21:30:49 -07:00
Daniel Freedman
ab49f51a66
Fix up comments based on feedback
2019-07-30 17:23:27 -07:00
Daniel Freedman
61767da2c0
Workaround bindings to textarea.placeholder in IE
...
Textareas have a very weird bug in IE, where the text of the placeholder
is copied to the content of the textarea when set.
This a creates two bugs:
1. An unintended binding is made to the textContent of the textarea's
text child node, meaning updates to the `placeholder` will be an
unnecessary binding process in the best case, or an exception thrown
when updating the text child node in the worst case.
2. When `legacyOptimizations` is enabled, the child node of the text
area is removed when the binding for `placeholder` is processed and
removed, leaving a binding to a `null` node, and throwing exceptions.
Therefore, when we detect this placeholder behavior, we will remove the
textnode before template processing, preventing both bugs.
2019-07-30 15:10:13 -07:00
Peter Burns
69ee4688af
Add additional externs ( #5575 )
...
Upstreaming cl/259031976
2019-07-19 18:13:36 -07:00
Alexander Marks
e7e4c241a7
Merge pull request #5566 from Polymer/compile
...
Make Closure compiler happier about ShadyDOM access
2019-06-29 21:42:40 -07:00
Alexander Marks
46ee2aecc1
Make Closure compiler happier about ShadyDOM access
2019-06-28 17:31:07 -07:00
Peter Burns
0d2c2e5dbc
Remove other double import ( #5565 )
...
Debouncer is no longer used in the file, even as a type name.
2019-06-27 13:01:13 -07:00
Peter Burns
54f8b47fee
Only use CONST_CASE for constants. ( #5564 )
...
Otherwise it looks suspicious to closure compiler, and triggers a warning.
2019-06-27 13:00:47 -07:00
Daniel Freedman
ac12b3bc52
[skip ci] update changelog
2019-06-25 15:11:08 -07:00
Daniel Freedman
96de46f961
3.3.0
v3.3.0
2019-06-24 12:16:39 -07:00
Daniel Freedman
dd7c0d706c
[ci skip] Update version to 3.3.0
2019-06-24 12:16:12 -07:00
Peter Burns
94585c3168
Don't import/export from the same file twice ( #5562 )
...
Quiets down an annoying build warning in some configurations
2019-06-23 17:09:01 -07:00
Alexander Marks
9c7492d2e2
Merge pull request #5559 from Polymer/compile
...
Add @override, remove @attribute/@group/@hero/@homepage
2019-06-18 18:14:36 -07:00
Alexander Marks
ed7709f6a4
Add @override, remove @attribute/@group/@hero/@homepage
2019-06-17 15:51:00 -07:00
Alexander Marks
8af0ec4a53
Merge pull request #5558 from Polymer/compile
...
Various Polymer Closure compilation fixes
2019-06-17 11:57:20 -07:00
Alexander Marks
15090f2664
Closure compilation tweaks
2019-06-15 22:33:17 -07:00
Alexander Marks
1b8263fc54
Merge pull request #5557 from Polymer/compile
...
Fix a few Closure annotations
2019-06-15 13:04:31 -07:00
Alexander Marks
a6bff4360a
Add @return description
2019-06-14 12:45:57 -07:00
Alexander Marks
0810bf3e8f
Fix some Closure annotations
2019-06-14 12:32:08 -07:00
Alexander Marks
fe816760a9
Merge pull request #5550 from Polymer/externs-fixes-1
...
Various compilation fixes for externs
2019-06-06 19:12:51 +01:00
Alexander Marks
f0fb532d06
Pin to firefox 66 because of selenium error
2019-06-06 09:42:56 -07:00
Alexander Marks
6dfaa5f084
Fix eslint errors.
2019-06-06 08:47:44 -07:00
Alexander Marks
10d43ce849
Add some casts for places Closure doesn't understand constructor
2019-06-03 13:54:47 -07:00
Alexander Marks
0ae14b9c4b
Add new mixin annotations, remove GestureEventListeners alias
2019-05-31 16:39:58 -07:00
Alexander Marks
4cc6c33921
Align signatures of attributeChangedCallback
2019-05-30 15:46:12 -07:00
Alexander Marks
3dd189c418
Add @return annotation for PROPERTY_EFFECT_TYPES getter
2019-05-30 15:46:10 -07:00
Alexander Marks
e4e9e2fb52
Annotate __dataEnabled in a way analyzer understands
2019-05-30 15:46:07 -07:00
Alexander Marks
fc190dd5d0
Fix old global namespace type annotation for TemplateInstanceBase
2019-05-30 15:46:02 -07:00
Alexander Marks
54b1d78d22
Add @suppress annotation for use of deprecated cssFromModules
2019-05-30 15:46:02 -07:00
Alexander Marks
cdd4e204fa
Fix GestureEventListeners generated externs name.
...
Due to some compiler weirdness, we recently added some hacky indirection
around GestureEventListeners, however this changed the name of that
mixin from Analyzer's perspective by adding a leading underscore. This
fixes that.
2019-05-30 15:46:00 -07:00
Daniel Freedman
05231a0218
Merge pull request #5548 from Polymer/hide-template-controls-globally
...
Globally hide dom-{bind,if,repeat} elements with legacyOptmizations on
2019-05-30 11:25:39 -07:00
Daniel Freedman
43f57b1025
Globally hide dom-{bind,if,repeat} elements with legacyOptmizations on
...
Too many breaking tests internally to not hide them
2019-05-24 11:18:39 -07:00
Daniel Freedman
76bfc0a7d8
Merge pull request #5546 from Polymer/sync-closure-annotations
...
Sync closure compiler annotations
2019-05-22 11:25:36 -07:00
Daniel Freedman
ff2edd5cdc
Update dependencies to fix firefox 67 tests
2019-05-21 17:32:13 -07:00
Daniel Freedman
ad0842017d
Sync closure compiler annotations
...
Synced from cl/245073668
2019-05-21 17:14:50 -07:00
Daniel Freedman
927ae6a302
Merge pull request #5544 from Polymer/scopesubtree-same-scope
...
Scopesubtree same scope
2019-05-20 15:17:05 -07:00
Daniel Freedman
c051c5bb82
remove unused variable in test
2019-05-20 14:41:08 -07:00
Daniel Freedman
634d736c8e
remove debugger line
2019-05-20 14:35:57 -07:00
Daniel Freedman
8a5c1e9b2d
Make sure scopeSubtree does not recurse through other ShadowRoots
...
Polymer v1 implementation of `scopeSubtree` actually only added scoping
classes, and thus would have most of the effect of stopping at
ShadowRoot boundaries.
This change is more consistent with Polymer v1 behavior, without a weird
intersection of styling behavior.
2019-05-20 14:33:58 -07:00
Kevin Schaaf
4f40589cf9
Merge pull request #5542 from Polymer/5541-kschaaf-template-display
...
Don't set display: none under legacyOptimizations. Fixes #5541 .
2019-05-17 12:59:47 -07:00
Kevin Schaaf
c9cf56c075
Don't set display: none under legacyOptimizations. Fixes #5541 .
2019-05-17 08:54:41 -07:00
Daniel Freedman
6be58b08d1
Merge pull request #5537 from Polymer/scopeSubtree
...
Implement scopeSubtree for ShadyDOM noPatch mode
2019-05-16 14:46:15 -07:00
Daniel Freedman
338d420c2c
Use Array.from instead of a list comprehension
2019-05-16 13:56:31 -07:00
Daniel Freedman
971d32d73a
Merge pull request #5533 from LarsDenBakker/fix/configure-cancel-synthetic-click
...
Allow configuring cancelling synthetic click behavior
2019-05-10 16:13:07 -07:00
Alexander Marks
1c10f0ca81
Merge pull request #5538 from Polymer/cl245273850
...
More fixes for resolveUrl
2019-05-08 17:05:51 -07:00
Alexander Marks
3db5608506
Add check for //
2019-05-08 16:41:37 -07:00
Daniel Freedman
e10019a064
Use native qSA
...
Add documentation about when to use scopeSubtree
2019-05-08 16:17:41 -07:00
Daniel Freedman
6bc9534088
Implement scopeSubtree for ShadyDOM noPatch mode
...
Add scopeSubtree as a util function, and use in LegacyElement
2019-05-08 15:20:58 -07:00
Alexander Marks
1f080595a5
Remove unneccessary test
2019-05-07 13:26:20 -07:00
Alexander Marks
940b3cdc21
Add URL try/catch
2019-05-07 11:45:20 -07:00