GreenPolyProducts/polymer
5
0
Fork 0
mirror of https://github.com/Polymer/polymer.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity
6,552 Commits 91 Branches 159 Tags
7d6d7152bef2c7c489dabda842a616a43e4514c3
Commit Graph

804 Commits

Author SHA1 Message Date
Daniel Freedman
ab49f51a66 Fix up comments based on feedback 2019-07-30 17:23:27 -07:00
Daniel Freedman
61767da2c0 Workaround bindings to textarea.placeholder in IE 
Textareas have a very weird bug in IE, where the text of the placeholder
is copied to the content of the textarea when set.

This a creates two bugs:
1. An unintended binding is made to the textContent of the textarea's
   text child node, meaning updates to the `placeholder` will be an
   unnecessary binding process in the best case, or an exception thrown
   when updating the text child node in the worst case.
2. When `legacyOptimizations` is enabled, the child node of the text
   area is removed when the binding for `placeholder` is processed and
   removed, leaving a binding to a `null` node, and throwing exceptions.

Therefore, when we detect this placeholder behavior, we will remove the
textnode before template processing, preventing both bugs.
 2019-07-30 15:10:13 -07:00
Alexander Marks
46ee2aecc1 Make Closure compiler happier about ShadyDOM access 2019-06-28 17:31:07 -07:00
Peter Burns
0d2c2e5dbc Remove other double import (#5565) 
Debouncer is no longer used in the file, even as a type name.
 2019-06-27 13:01:13 -07:00
Peter Burns
54f8b47fee Only use CONST_CASE for constants. (#5564) 
Otherwise it looks suspicious to closure compiler, and triggers a warning.
 2019-06-27 13:00:47 -07:00
Daniel Freedman
dd7c0d706c [ci skip] Update version to 3.3.0 2019-06-24 12:16:12 -07:00
Peter Burns
94585c3168 Don't import/export from the same file twice (#5562) 
Quiets down an annoying build warning in some configurations
 2019-06-23 17:09:01 -07:00
Alexander Marks
ed7709f6a4 Add @override, remove @attribute/@group/@hero/@homepage 2019-06-17 15:51:00 -07:00
Alexander Marks
15090f2664 Closure compilation tweaks 2019-06-15 22:33:17 -07:00
Alexander Marks
a6bff4360a Add @return description 2019-06-14 12:45:57 -07:00
Alexander Marks
0810bf3e8f Fix some Closure annotations 2019-06-14 12:32:08 -07:00
Alexander Marks
6dfaa5f084 Fix eslint errors. 2019-06-06 08:47:44 -07:00
Alexander Marks
10d43ce849 Add some casts for places Closure doesn't understand constructor 2019-06-03 13:54:47 -07:00
Alexander Marks
0ae14b9c4b Add new mixin annotations, remove GestureEventListeners alias 2019-05-31 16:39:58 -07:00
Alexander Marks
4cc6c33921 Align signatures of attributeChangedCallback 2019-05-30 15:46:12 -07:00
Alexander Marks
3dd189c418 Add @return annotation for PROPERTY_EFFECT_TYPES getter 2019-05-30 15:46:10 -07:00
Alexander Marks
e4e9e2fb52 Annotate __dataEnabled in a way analyzer understands 2019-05-30 15:46:07 -07:00
Alexander Marks
fc190dd5d0 Fix old global namespace type annotation for TemplateInstanceBase 2019-05-30 15:46:02 -07:00
Alexander Marks
54b1d78d22 Add @suppress annotation for use of deprecated cssFromModules 2019-05-30 15:46:02 -07:00
Alexander Marks
cdd4e204fa Fix GestureEventListeners generated externs name. 
Due to some compiler weirdness, we recently added some hacky indirection
around GestureEventListeners, however this changed the name of that
mixin from Analyzer's perspective by adding a leading underscore. This
fixes that.
 2019-05-30 15:46:00 -07:00
Daniel Freedman
43f57b1025 Globally hide dom-{bind,if,repeat} elements with legacyOptmizations on 
Too many breaking tests internally to not hide them
 2019-05-24 11:18:39 -07:00
Daniel Freedman
ad0842017d Sync closure compiler annotations 
Synced from cl/245073668
 2019-05-21 17:14:50 -07:00
Daniel Freedman
8a5c1e9b2d Make sure scopeSubtree does not recurse through other ShadowRoots 
Polymer v1 implementation of `scopeSubtree` actually only added scoping
classes, and thus would have most of the effect of stopping at
ShadowRoot boundaries.

This change is more consistent with Polymer v1 behavior, without a weird
intersection of styling behavior.
 2019-05-20 14:33:58 -07:00
Kevin Schaaf
c9cf56c075 Don't set display: none under legacyOptimizations. Fixes #5541. 2019-05-17 08:54:41 -07:00
Daniel Freedman
6be58b08d1 Merge pull request #5537 from Polymer/scopeSubtree 
Implement scopeSubtree for ShadyDOM noPatch mode
 2019-05-16 14:46:15 -07:00
Daniel Freedman
338d420c2c Use Array.from instead of a list comprehension 2019-05-16 13:56:31 -07:00
Daniel Freedman
971d32d73a Merge pull request #5533 from LarsDenBakker/fix/configure-cancel-synthetic-click 
Allow configuring cancelling synthetic click behavior
 2019-05-10 16:13:07 -07:00
Alexander Marks
3db5608506 Add check for // 2019-05-08 16:41:37 -07:00
Daniel Freedman
e10019a064 Use native qSA 
Add documentation about when to use scopeSubtree
 2019-05-08 16:17:41 -07:00
Daniel Freedman
6bc9534088 Implement scopeSubtree for ShadyDOM noPatch mode 
Add scopeSubtree as a util function, and use in LegacyElement
 2019-05-08 15:20:58 -07:00
Alexander Marks
940b3cdc21 Add URL try/catch 2019-05-07 11:45:20 -07:00
Lars den Bakker
00d4cdf4d6 Allow configuring cancelling synthetic click behavior 2019-05-04 15:22:05 +02:00
Daniel Freedman
a0b83b259f Fix class$ bindings for ShadyDOM.noPatch mode 2019-05-03 16:27:54 -07:00
Alexander Marks
d0ea20a17d Check directly for // in resolveUrl because it isn't a valid URL 2019-05-01 12:33:50 -07:00
Peter Burns
733cf6831c Run resolveUrl for protocol-relative urls (#5530) 
* Run resolveUrl for protocol-relative urls

This part of ABS_URL is trying to match on absolute paths, like `/images/logo.png` not protocol-relative urls like `//example.com/images/logo.png`

Added a test and confirmed that it fails without this change.

Also cleaned up a some over-aggressive modulizer escaping in resolveurl-elements.js

Upstreaming cl/245302268
 2019-04-25 17:41:14 -07:00
Daniel Freedman
03b2c668b3 Merge pull request #5527 from Polymer/localTarget-noPatch 
Fix `localTarget` when `ShadyDOM.noPatch` is in use
 2019-04-23 13:28:07 -07:00
Peter Burns
6960c2b9f8 Fix lint 2019-04-22 16:18:38 -07:00
Peter Burns
3437334942 Cast GestureEventListeners. 
This improves the closure compiler type checking of GestureEventListeners. Upstreaming of cl/239878806
 2019-04-22 16:13:25 -07:00
Peter Burns
cc7702b476 Work around https://github.com/google/closure-compiler/issues/3240 
Also add @nocollapse to all of our static methods and properties, because we never want static property collapsing on these methods.
 2019-04-22 16:08:50 -07:00
Steven Orvell
7925254bec Fix localTareget when ShadyDOM.noPatch is in use 
Fixes #5526.

Return the "lowest" element in the same root as the node listening for the event (currentTarget).
 2019-04-22 11:08:18 -07:00
Daniel Freedman
652fea9c92 Merge branch 'master' into fix-className-bindings-master 2019-04-19 16:21:46 -07:00
Daniel Freedman
176c00161d Merge pull request #5487 from Polymer/shadydom-upgrade 
Use `ShadyDOM.attachDom`
 2019-04-19 16:17:22 -07:00
Kevin Schaaf
8f4cc31efe Merge pull request #5520 from Polymer/avoid-template-upgrade 
Avoid upgrading template if no hostProps, for better perf.
 2019-04-12 18:18:00 -07:00
Kevin Schaaf
c7eb7c1984 [ci skip] Add comment 2019-04-12 18:17:44 -07:00
Steven Orvell
dd98569bb6 Merge branch 'master' into shadydom-upgrade 2019-04-12 17:37:40 -07:00
Steven Orvell
3af9f3407b Use attachShadow({shadyUpgradeFragment}) 2019-04-12 17:37:22 -07:00
Kevin Schaaf
f5a45ebc2d Ensure wildcard arguments get undefined treatment. Fixes #5428. 2019-04-11 15:32:33 -07:00
Steven Orvell
b13e656fae Fix className on browsers without good native accessors 
* Ensure `wrap` falls back to using `ShadyDOM.patch` when `noPatch` is not in use so that `className` can be used.
* Ensure `Polymer.dom` uses `patch` when `noPatch` is not in use so that `className` can be used.
 2019-04-11 10:36:50 -07:00
Steven Orvell
8d7def7208 don't depend on attachDom existing. 2019-04-10 16:27:33 -07:00
Steven Orvell
707a3760e1 Merge branch 'master' into shadydom-upgrade 2019-04-10 16:26:41 -07:00