IntenseFinance/firefly-iii
3
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-02-25 18:45:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

Cleanup tests.

Browse Source
This commit is contained in:
James Cole
2015-05-23 21:23:51 +02:00
parent 41e20664de
commit 11e3696191
3 changed files with 40 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/Repositories/Account/AccountRepository.php
View File

@@ -306,7 +306,7 @@ class AccountRepository implements AccountRepositoryInterface
if ($journal->destination_account->id == $account->id) {
return $journal;
}
}
} // @codeCoverageIgnore
);
return $filtered;

31
tests/repositories/CategoryRepositoryTest.php
View File

@@ -99,14 +99,29 @@ class CategoryRepositoryTest extends TestCase
$category->save();
}
// another journal, same category:
$journal = FactoryMuffin::create('FireflyIII\Models\TransactionJournal');
$journal->user_id = $user->id;
$journal->date = new Carbon('2015-02-11');
$journal->transaction_type_id = $type->id;
$category->transactionjournals()->save($journal);
$journal->save();
$category->save();
for ($i = 0; $i < 5; $i++) {
$journal1 = FactoryMuffin::create('FireflyIII\Models\TransactionJournal');
$journal2 = FactoryMuffin::create('FireflyIII\Models\TransactionJournal');
/** @var Category $category */
$category = FactoryMuffin::create('FireflyIII\Models\Category');
$journal1->user_id = $user->id;
$journal1->date = new Carbon('2015-02-11');
$journal1->transaction_type_id = $type->id;
$journal2->user_id = $user->id;
$journal2->date = new Carbon('2015-02-11');
$journal2->transaction_type_id = $type->id;
$category->user_id = $user->id;
$category->transactionjournals()->save($journal1);
$category->transactionjournals()->save($journal2);
$journal1->save();
$journal2->save();
$category->save();
}
$this->be($user);
$set = $this->object->getCategoriesAndExpensesCorrected(new Carbon('2015-02-01'), new Carbon('2015-02-28'));

16
tests/repositories/JournalRepositoryTest.php
View File

@@ -92,6 +92,8 @@ class JournalRepositoryTest extends TestCase
*/
public function testGetAmountBefore()
{
$transaction = FactoryMuffin::create('FireflyIII\Models\Transaction');
$before = $this->object->getAmountBefore($transaction->transactionjournal, $transaction);
@@ -167,6 +169,8 @@ class JournalRepositoryTest extends TestCase
/**
* @covers FireflyIII\Repositories\Journal\JournalRepository::store
* @covers FireflyIII\Repositories\Journal\JournalRepository::storeAccounts
* @covers FireflyIII\Repositories\Journal\JournalRepository::storeWithdrawalAccounts
* @covers FireflyIII\Repositories\Journal\JournalRepository::storeDepositAccounts
*/
public function testStore()
{
@@ -199,6 +203,8 @@ class JournalRepositoryTest extends TestCase
/**
* @covers FireflyIII\Repositories\Journal\JournalRepository::store
* @covers FireflyIII\Repositories\Journal\JournalRepository::storeAccounts
* @covers FireflyIII\Repositories\Journal\JournalRepository::storeWithdrawalAccounts
* @covers FireflyIII\Repositories\Journal\JournalRepository::storeDepositAccounts
*/
public function testStoreDeposit()
{
@@ -236,6 +242,8 @@ class JournalRepositoryTest extends TestCase
/**
* @covers FireflyIII\Repositories\Journal\JournalRepository::store
* @covers FireflyIII\Repositories\Journal\JournalRepository::storeAccounts
* @covers FireflyIII\Repositories\Journal\JournalRepository::storeWithdrawalAccounts
* @covers FireflyIII\Repositories\Journal\JournalRepository::storeDepositAccounts
*/
public function testStoreExpenseWithCash()
{
@@ -272,6 +280,8 @@ class JournalRepositoryTest extends TestCase
/**
* @covers FireflyIII\Repositories\Journal\JournalRepository::store
* @covers FireflyIII\Repositories\Journal\JournalRepository::storeAccounts
* @covers FireflyIII\Repositories\Journal\JournalRepository::storeWithdrawalAccounts
* @covers FireflyIII\Repositories\Journal\JournalRepository::storeDepositAccounts
* @expectedException Symfony\Component\HttpKernel\Exception\HttpException
*/
public function testStoreInvalidFromAccount()
@@ -311,6 +321,8 @@ class JournalRepositoryTest extends TestCase
/**
* @covers FireflyIII\Repositories\Journal\JournalRepository::store
* @covers FireflyIII\Repositories\Journal\JournalRepository::storeAccounts
* @covers FireflyIII\Repositories\Journal\JournalRepository::storeWithdrawalAccounts
* @covers FireflyIII\Repositories\Journal\JournalRepository::storeDepositAccounts
* @expectedException Symfony\Component\HttpKernel\Exception\HttpException
*/
public function testStoreInvalidToAccount()
@@ -350,6 +362,8 @@ class JournalRepositoryTest extends TestCase
/**
* @covers FireflyIII\Repositories\Journal\JournalRepository::store
* @covers FireflyIII\Repositories\Journal\JournalRepository::storeAccounts
* @covers FireflyIII\Repositories\Journal\JournalRepository::storeWithdrawalAccounts
* @covers FireflyIII\Repositories\Journal\JournalRepository::storeDepositAccounts
*/
public function testStoreRevenueWithCash()
{
@@ -387,6 +401,8 @@ class JournalRepositoryTest extends TestCase
/**
* @covers FireflyIII\Repositories\Journal\JournalRepository::store
* @covers FireflyIII\Repositories\Journal\JournalRepository::storeAccounts
* @covers FireflyIII\Repositories\Journal\JournalRepository::storeWithdrawalAccounts
* @covers FireflyIII\Repositories\Journal\JournalRepository::storeDepositAccounts
*/
public function testStoreTransfer()
{