IntenseFinance/firefly-iii
3
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-01-26 16:26:35 -06:00
Code Issues Packages Projects Releases Wiki Activity

Removed some todo's

Browse Source
This commit is contained in:
James Cole 2014-11-21 19:18:44 +01:00
parent 36f6bda525
commit 13c2db5378
2 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/controllers/TransactionController.php
View File

@ -351,9 +351,6 @@ class TransactionController extends BaseController
*/ */
public function update(TransactionJournal $journal) public function update(TransactionJournal $journal)
{ {
/*
* TODO if the piggybank_id is set to 0, does this undo all piggy bank event(s)?
*/
/** @var \FireflyIII\Database\TransactionJournal $repos */ /** @var \FireflyIII\Database\TransactionJournal $repos */
$repos = App::make('FireflyIII\Database\TransactionJournal'); $repos = App::make('FireflyIII\Database\TransactionJournal');

8
bootstrap/start.php
View File

@ -111,8 +111,8 @@ Event::subscribe('FireflyIII\Event\TransactionJournal');
// direct calls to models are BAD // direct calls to models are BAD
// cleanup everything related to reminders because it still feels a bit sloppy. // cleanup everything related to reminders because it still feels a bit sloppy.
// use a Database\Reminder thing instead of self-made ORM. // use a Database\Reminder thing instead of self-made ORM.
// TODO create static calls instead of all the App::make() things. // create static calls instead of all the App::make() things.
// TODO see if the various has-many-throughs actually get used. // see if the various has-many-throughs actually get used.
// TODO set very tight rules on all models // set very tight rules on all models
// TODO create custom uniquely rules. // create custom uniquely rules.
return $app; return $app;