IntenseFinance/firefly-iii
3
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2024-12-30 10:47:06 -06:00
Code Issues Packages Projects Releases Wiki Activity

New check for journals with 0.00 amount.

Browse Source
This commit is contained in:
James Cole 2019-02-23 07:47:41 +01:00
parent 07048cb5fb
commit 36c2f27d59
1 changed files with 32 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
app/Console/Commands/VerifyDatabase.php
View File

@ -26,6 +26,7 @@ declare(strict_types=1);
namespace FireflyIII\Console\Commands;
use DB;
use Exception;
use FireflyIII\Models\Account;
use FireflyIII\Models\AccountMeta;
use FireflyIII\Models\AccountType;
@ -43,6 +44,7 @@ use FireflyIII\User;
use Illuminate\Console\Command;
use Illuminate\Database\Eloquent\Builder;
use Illuminate\Support\Collection;
use Log;
use Schema;
use stdClass;
@ -97,6 +99,7 @@ class VerifyDatabase extends Command
$this->fixBadMeta();
$this->removeBills();
$this->enableCurrencies();
$this->reportZeroAmount();
return 0;
}
@ -688,4 +691,33 @@ class VerifyDatabase extends Command
);
}
}
/**
* Collect all journals with empty amount.
*/
private function reportZeroAmount(): void
{
$set = Transaction::where('amount', 0)->get(['transaction_journal_id'])->pluck('transaction_journal_id')->toArray();
$set = array_unique($set);
/** @var Collection $journals */
$journals = TransactionJournal::whereIn('id', $set)->get();
/** @var TransactionJournal $journal */
foreach ($journals as $journal) {
$message = sprintf(
'Transaction "%s" (#%d), owned by user %s, has amount zero (0.00). It has been deleted.', $journal->description,
$journal->id, $journal->user->email
);
$this->error($message);
try {
foreach($journal->transactions as $t) {
$t->delete();
}
$journal->delete();
} catch (Exception $e) {
Log::debug(sprintf('Could not delete journal: %s', $e->getMessage()));
}
}
}
}