IntenseFinance/firefly-iii
3
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-02-25 18:45:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix #4071

Browse Source
This commit is contained in:
James Cole 2020-11-20 06:22:43 +01:00
parent 5e703c6e7f
commit 3dbc74b040
No known key found for this signature in database
GPG Key ID: B5669F9493CDE38D
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/Repositories/PiggyBank/ModifiesPiggyBanks.php
View File

@ -62,7 +62,7 @@ trait ModifiesPiggyBanks
$repetition->save();
// create event
$this->createEvent($piggyBank, $amount);
//$this->createEvent($piggyBank, $amount);
return true;
}

8
app/Validation/FireflyValidator.php
View File

@ -34,6 +34,7 @@ use FireflyIII\Models\TransactionType;
use FireflyIII\Repositories\Account\AccountRepositoryInterface;
use FireflyIII\Repositories\Bill\BillRepositoryInterface;
use FireflyIII\Repositories\Budget\BudgetRepositoryInterface;
use FireflyIII\Repositories\PiggyBank\PiggyBankRepositoryInterface;
use FireflyIII\Services\Password\Verifier;
use FireflyIII\Support\ParseDateString;
use FireflyIII\TransactionRules\Triggers\TriggerInterface;
@ -289,10 +290,11 @@ class FireflyValidator extends Validator
return null !== $account;
}
// must be numeric for piggy bank things:
if ('update_piggy' === $actionType) {
$value = str_replace(',', '.', $value);
return '' !== $value && is_numeric($value);
/** @var PiggyBankRepositoryInterface $repository */
$repository = app(PiggyBankRepositoryInterface::class);
$piggy = $repository->findByName($value);
return null !== $piggy;
}
// return true for the rest.