IntenseFinance/firefly-iii
3
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-02-25 18:45:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

Basic logging for willMatchEverything #322

Browse Source
This commit is contained in:
James Cole
2016-09-21 20:30:09 +02:00
parent d221ea68d0
commit a31b4ccf01
18 changed files with 108 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/Rules/Factory/ActionFactory.php
View File

@@ -8,14 +8,13 @@ declare(strict_types = 1);
* of the MIT license. See the LICENSE file for details.
*/
declare(strict_types = 1);
namespace FireflyIII\Rules\Factory;
use FireflyIII\Exceptions\FireflyException;
use FireflyIII\Models\RuleAction;
use FireflyIII\Rules\Actions\ActionInterface;
use FireflyIII\Support\Domain;
use Log;
/**
* Interface ActionInterface
@@ -39,6 +38,7 @@ class ActionFactory
public static function getAction(RuleAction $action): ActionInterface
{
$class = self::getActionClass($action->action_type);
Log::debug(sprintf('self::getActionClass("%s") = "%s"', $action->action_type, $class));
return new $class($action);
}

3
app/Rules/Factory/TriggerFactory.php
View File

@@ -46,6 +46,9 @@ class TriggerFactory
$class = self::getTriggerClass($triggerType);
$obj = $class::makeFromTriggerValue($trigger->trigger_value);
Log::debug(sprintf('self::getTriggerClass("%s") = "%s"', $triggerType, $class));
Log::debug(sprintf('%s::makeFromTriggerValue(%s) = object of class "%s"', $class, $trigger->trigger_value, get_class($obj)));
return $obj;
}

2
app/Rules/Triggers/AmountExactly.php
View File

@@ -13,6 +13,7 @@ namespace FireflyIII\Rules\Triggers;
use FireflyIII\Models\TransactionJournal;
use Log;
/**
* Class AmountExactly
@@ -43,6 +44,7 @@ final class AmountExactly extends AbstractTrigger implements TriggerInterface
if (!is_null($value)) {
return false;
}
Log::error(sprintf('Cannot use %s with a null value.', self::class));
return true;
}

2
app/Rules/Triggers/AmountLess.php
View File

@@ -13,6 +13,7 @@ namespace FireflyIII\Rules\Triggers;
use FireflyIII\Models\TransactionJournal;
use Log;
/**
* Class AmountLess
@@ -43,6 +44,7 @@ final class AmountLess extends AbstractTrigger implements TriggerInterface
if (!is_null($value)) {
return false;
}
Log::error(sprintf('Cannot use %s with a null value.', self::class));
return true;
}

10
app/Rules/Triggers/AmountMore.php
View File

@@ -13,6 +13,7 @@ namespace FireflyIII\Rules\Triggers;
use FireflyIII\Models\TransactionJournal;
use Log;
/**
* Class AmountMore
@@ -41,9 +42,16 @@ final class AmountMore extends AbstractTrigger implements TriggerInterface
public static function willMatchEverything($value = null)
{
if (!is_null($value)) {
return bccomp('0', strval($value)) === 0;
$res = bccomp('0', strval($value)) === 0;
if ($res === true) {
Log::error(sprintf('Cannot use %s with a value equal to 0.', self::class));
}
return $res;
}
Log::error(sprintf('Cannot use %s with a null value.', self::class));
return true;
}

10
app/Rules/Triggers/DescriptionContains.php
View File

@@ -13,6 +13,7 @@ namespace FireflyIII\Rules\Triggers;
use FireflyIII\Models\TransactionJournal;
use Log;
/**
* Class DescriptionContains
@@ -41,9 +42,16 @@ final class DescriptionContains extends AbstractTrigger implements TriggerInterf
public static function willMatchEverything($value = null)
{
if (!is_null($value)) {
return strval($value) === '';
$res = strval($value) === '';
if ($res === true) {
Log::error(sprintf('Cannot use %s with "" as a value.', self::class));
}
return $res;
}
Log::error(sprintf('Cannot use %s with a null value.', self::class));
return true;
}

10
app/Rules/Triggers/DescriptionEnds.php
View File

@@ -12,6 +12,7 @@ declare(strict_types = 1);
namespace FireflyIII\Rules\Triggers;
use FireflyIII\Models\TransactionJournal;
use Log;
/**
* Class DescriptionEnds
@@ -40,9 +41,16 @@ final class DescriptionEnds extends AbstractTrigger implements TriggerInterface
public static function willMatchEverything($value = null)
{
if (!is_null($value)) {
return strval($value) === '';
$res = strval($value) === '';
if ($res === true) {
Log::error(sprintf('Cannot use %s with "" as a value.', self::class));
}
return $res;
}
Log::error(sprintf('Cannot use %s with a null value.', self::class));
return true;
}

3
app/Rules/Triggers/DescriptionIs.php
View File

@@ -12,6 +12,7 @@ declare(strict_types = 1);
namespace FireflyIII\Rules\Triggers;
use FireflyIII\Models\TransactionJournal;
use Log;
/**
* Class DescriptionIs
@@ -43,6 +44,8 @@ final class DescriptionIs extends AbstractTrigger implements TriggerInterface
return false;
}
Log::error(sprintf('Cannot use %s with a null value.', self::class));
return true;
}

10
app/Rules/Triggers/DescriptionStarts.php
View File

@@ -12,6 +12,7 @@ declare(strict_types = 1);
namespace FireflyIII\Rules\Triggers;
use FireflyIII\Models\TransactionJournal;
use Log;
/**
* Class DescriptionStarts
@@ -40,9 +41,16 @@ final class DescriptionStarts extends AbstractTrigger implements TriggerInterfac
public static function willMatchEverything($value = null)
{
if (!is_null($value)) {
return strval($value) === '';
$res = strval($value) === '';
if ($res === true) {
Log::error(sprintf('Cannot use %s with "" as a value.', self::class));
}
return $res;
}
Log::error(sprintf('Cannot use %s with a null value.', self::class));
return true;
}

9
app/Rules/Triggers/FromAccountContains.php
View File

@@ -13,6 +13,7 @@ namespace FireflyIII\Rules\Triggers;
use FireflyIII\Models\Account;
use FireflyIII\Models\TransactionJournal;
use Log;
/**
* Class FromAccountContains
@@ -41,8 +42,14 @@ final class FromAccountContains extends AbstractTrigger implements TriggerInterf
public static function willMatchEverything($value = null)
{
if (!is_null($value)) {
return strval($value) === '';
$res = strval($value) === '';
if ($res === true) {
Log::error(sprintf('Cannot use %s with "" as a value.', self::class));
}
return $res;
}
Log::error(sprintf('Cannot use %s with a null value.', self::class));
return true;
}

9
app/Rules/Triggers/FromAccountEnds.php
View File

@@ -13,6 +13,7 @@ namespace FireflyIII\Rules\Triggers;
use FireflyIII\Models\Account;
use FireflyIII\Models\TransactionJournal;
use Log;
/**
* Class FromAccountEnds
@@ -41,8 +42,14 @@ final class FromAccountEnds extends AbstractTrigger implements TriggerInterface
public static function willMatchEverything($value = null)
{
if (!is_null($value)) {
return strval($value) === '';
$res = strval($value) === '';
if ($res === true) {
Log::error(sprintf('Cannot use %s with "" as a value.', self::class));
}
return $res;
}
Log::error(sprintf('Cannot use %s with a null value.', self::class));
return true;
}

3
app/Rules/Triggers/FromAccountIs.php
View File

@@ -13,7 +13,7 @@ namespace FireflyIII\Rules\Triggers;
use FireflyIII\Models\Account;
use FireflyIII\Models\TransactionJournal;
use Log;
/**
* Class FromAccountIs
*
@@ -43,6 +43,7 @@ final class FromAccountIs extends AbstractTrigger implements TriggerInterface
if (!is_null($value)) {
return false;
}
Log::error(sprintf('Cannot use %s with a null value.', self::class));
return true;
}

9
app/Rules/Triggers/FromAccountStarts.php
View File

@@ -13,6 +13,7 @@ namespace FireflyIII\Rules\Triggers;
use FireflyIII\Models\Account;
use FireflyIII\Models\TransactionJournal;
use Log;
/**
* Class FromAccountStarts
@@ -41,8 +42,14 @@ final class FromAccountStarts extends AbstractTrigger implements TriggerInterfac
public static function willMatchEverything($value = null)
{
if (!is_null($value)) {
return strval($value) === '';
$res = strval($value) === '';
if ($res === true) {
Log::error(sprintf('Cannot use %s with "" as a value.', self::class));
}
return $res;
}
Log::error(sprintf('Cannot use %s with a null value.', self::class));
return true;
}

9
app/Rules/Triggers/ToAccountContains.php
View File

@@ -13,6 +13,7 @@ namespace FireflyIII\Rules\Triggers;
use FireflyIII\Models\Account;
use FireflyIII\Models\TransactionJournal;
use Log;
/**
* Class ToAccountContains
@@ -41,8 +42,14 @@ final class ToAccountContains extends AbstractTrigger implements TriggerInterfac
public static function willMatchEverything($value = null)
{
if (!is_null($value)) {
return strval($value) === '';
$res = strval($value) === '';
if ($res === true) {
Log::error(sprintf('Cannot use %s with "" as a value.', self::class));
}
return $res;
}
Log::error(sprintf('Cannot use %s with a null value.', self::class));
return true;
}

9
app/Rules/Triggers/ToAccountEnds.php
View File

@@ -13,6 +13,7 @@ namespace FireflyIII\Rules\Triggers;
use FireflyIII\Models\Account;
use FireflyIII\Models\TransactionJournal;
use Log;
/**
* Class ToAccountEnds
@@ -41,8 +42,14 @@ final class ToAccountEnds extends AbstractTrigger implements TriggerInterface
public static function willMatchEverything($value = null)
{
if (!is_null($value)) {
return strval($value) === '';
$res = strval($value) === '';
if ($res === true) {
Log::error(sprintf('Cannot use %s with "" as a value.', self::class));
}
return $res;
}
Log::error(sprintf('Cannot use %s with a null value.', self::class));
return true;
}

9
app/Rules/Triggers/ToAccountIs.php
View File

@@ -13,6 +13,7 @@ namespace FireflyIII\Rules\Triggers;
use FireflyIII\Models\Account;
use FireflyIII\Models\TransactionJournal;
use Log;
/**
* Class ToAccountIs
@@ -41,8 +42,14 @@ final class ToAccountIs extends AbstractTrigger implements TriggerInterface
public static function willMatchEverything($value = null)
{
if (!is_null($value)) {
return false;
$res = strval($value) === '';
if ($res === true) {
Log::error(sprintf('Cannot use %s with "" as a value.', self::class));
}
return $res;
}
Log::error(sprintf('Cannot use %s with a null value.', self::class));
return true;
}

9
app/Rules/Triggers/ToAccountStarts.php
View File

@@ -13,6 +13,7 @@ namespace FireflyIII\Rules\Triggers;
use FireflyIII\Models\Account;
use FireflyIII\Models\TransactionJournal;
use Log;
/**
* Class ToAccountStarts
@@ -41,8 +42,14 @@ final class ToAccountStarts extends AbstractTrigger implements TriggerInterface
public static function willMatchEverything($value = null)
{
if (!is_null($value)) {
return strval($value) === '';
$res = strval($value) === '';
if ($res === true) {
Log::error(sprintf('Cannot use %s with "" as a value.', self::class));
}
return $res;
}
Log::error(sprintf('Cannot use %s with a null value.', self::class));
return true;
}

2
app/Rules/Triggers/TransactionType.php
View File

@@ -12,6 +12,7 @@ declare(strict_types = 1);
namespace FireflyIII\Rules\Triggers;
use FireflyIII\Models\TransactionJournal;
use Log;
/**
* Class TransactionType
@@ -42,6 +43,7 @@ final class TransactionType extends AbstractTrigger implements TriggerInterface
if (!is_null($value)) {
return false;
}
Log::error(sprintf('Cannot use %s with a null value.', self::class));
return true;
}