Code cleanup

This commit is contained in:
James Cole
2019-08-17 10:47:29 +02:00
parent 23479790fe
commit c2296c3ad5
95 changed files with 463 additions and 507 deletions

View File

@@ -33,9 +33,9 @@ class Amount implements ConverterInterface
* Some people, when confronted with a problem, think "I know, I'll use regular expressions." Now they have two problems.
* - Jamie Zawinski.
*
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.NPathComplexity)
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
*
*
*
* @param $value
*
* @return string

View File

@@ -46,7 +46,7 @@ class FakeJobConfiguration implements JobConfigurationInterface
* if stage is not "new", then album must be 'station to station'
*
* @return bool
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
*
*/
public function configurationComplete(): bool
{
@@ -70,7 +70,7 @@ class FakeJobConfiguration implements JobConfigurationInterface
*
* @return MessageBag
*
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
*
*/
public function configureJob(array $data): MessageBag
{
@@ -128,7 +128,7 @@ class FakeJobConfiguration implements JobConfigurationInterface
*
* @return string
*
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
*
*/
public function getNextView(): string
{

View File

@@ -89,10 +89,10 @@ class FileJobConfiguration implements JobConfigurationInterface
/**
* Returns the view of the next step in the job configuration.
*
* @throws FireflyException
* @return string
*
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
*
*@throws FireflyException
*/
public function getNextView(): string
{
@@ -132,7 +132,7 @@ class FileJobConfiguration implements JobConfigurationInterface
* @return FileConfigurationInterface
* @throws FireflyException
*
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
*
*/
private function getConfigurationObject(): FileConfigurationInterface
{

View File

@@ -111,7 +111,7 @@ class SpectreJobConfiguration implements JobConfigurationInterface
* @return SpectreJobConfigurationInterface
* @throws FireflyException
*
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
*
*/
private function getHandler(): SpectreJobConfigurationInterface
{

View File

@@ -109,7 +109,7 @@ class YnabJobConfiguration implements JobConfigurationInterface
* @return YnabJobConfigurationInterface
* @throws FireflyException
*
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
*
*/
private function getHandler(): YnabJobConfigurationInterface
{

View File

@@ -52,8 +52,8 @@ class FakeRoutine implements RoutineInterface
* @return void
* @throws FireflyException
*
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
*
*
*/
public function run(): void
{

View File

@@ -49,8 +49,8 @@ class SpectreRoutine implements RoutineInterface
*
* @throws FireflyException
*
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
*
*
*/
public function run(): void
{

View File

@@ -64,7 +64,7 @@ class AbnAmroDescription implements SpecificInterface
*
* @return array
*
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
*
*/
public function run(array $row): array
{
@@ -132,8 +132,8 @@ class AbnAmroDescription implements SpecificInterface
*
* @return bool true if the description is SEPA format, false otherwise
*
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
*
*
*/
protected function parseSepaDescription(): bool
{
@@ -189,8 +189,8 @@ class AbnAmroDescription implements SpecificInterface
*
* @return bool true if the description is TRTP format, false otherwise
*
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
*
*
*/
protected function parseTRTPDescription(): bool
{

View File

@@ -61,7 +61,7 @@ class Belfius implements SpecificInterface
*
* @return array
*
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
*
*/
public function run(array $row): array
{

View File

@@ -59,7 +59,7 @@ class IngBelgium implements SpecificInterface
*
* @return array
*
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
*
*/
public function run(array $row): array
{

View File

@@ -66,7 +66,7 @@ class IngDescription implements SpecificInterface
*
* @return array
*
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
*
*/
public function run(array $row): array
{

View File

@@ -59,7 +59,7 @@ class RabobankDescription implements SpecificInterface
*
* @return array
*
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
*
*/
public function run(array $row): array
{

View File

@@ -51,7 +51,7 @@ use Log;
*
* Class ImportArrayStorage
*
* @SuppressWarnings(PHPMD.CouplingBetweenObjects)
*
*/
class ImportArrayStorage
{
@@ -201,8 +201,8 @@ class ImportArrayStorage
* @return Collection
* @throws FireflyException
*
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
*
*
*/
private function storeGroupArray(): Collection
{
@@ -388,9 +388,9 @@ class ImportArrayStorage
*
* @return bool
*
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
* @SuppressWarnings(PHPMD.ExcessiveMethodLength)
* @SuppressWarnings(PHPMD.NPathComplexity)
*
*
*
*/
private function transferExists(array $transaction): bool
{