IntenseFinance/firefly-iii
3
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-02-25 18:45:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

Better compare for amounts because floatval can be inaccurate.

Browse Source
This commit is contained in:
James Cole 2015-07-17 17:35:04 +02:00
parent 31114a2ca5
commit ce5beeaf2c
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/Repositories/Journal/JournalRepository.php
View File

@ -252,13 +252,13 @@ class JournalRepository implements JournalRepositoryInterface
// update the from and to transaction. // update the from and to transaction.
/** @var Transaction $transaction */ /** @var Transaction $transaction */
foreach ($journal->transactions()->get() as $transaction) { foreach ($journal->transactions()->get() as $transaction) {
if (floatval($transaction->amount) < 0) { if ($transaction->amount < 0) {
// this is the from transaction, negative amount: // this is the from transaction, negative amount:
$transaction->amount = $data['amount'] * -1; $transaction->amount = $data['amount'] * -1;
$transaction->account_id = $fromAccount->id; $transaction->account_id = $fromAccount->id;
$transaction->save(); $transaction->save();
} }
if (floatval($transaction->amount) > 0) { if ($transaction->amount > 0) {
$transaction->amount = $data['amount']; $transaction->amount = $data['amount'];
$transaction->account_id = $toAccount->id; $transaction->account_id = $toAccount->id;
$transaction->save(); $transaction->save();