Various code cleanup.

app/Events/RequestedNewPassword.php

@@ -34,6 +34,7 @@ class RequestedNewPassword extends Event
      *
      * @param  User  $user
      * @param string $token
+     * @param string $ipAddress
      */
     public function __construct(User $user, string $token, string $ipAddress)
     {

app/Http/Controllers/AccountController.php

@@ -251,6 +251,7 @@ class AccountController extends Controller
     }
 
     /**
+     * @param ARI     $repository
      * @param Account $account
      *
      * @return View

app/Http/Controllers/Auth/LoginController.php

@@ -75,7 +75,8 @@ class LoginController extends Controller
         // If the class is using the ThrottlesLogins trait, we can automatically throttle
         // the login attempts for this application. We'll key this by the username and
         // the IP address of the client making these requests into this application.
-        if ($lockedOut = $this->hasTooManyLoginAttempts($request)) {
+        $lockedOut = $this->hasTooManyLoginAttempts($request);
+        if ($lockedOut) {
             $this->fireLockoutEvent($request);
 
             return $this->sendLockoutResponse($request);

app/Http/Controllers/BudgetController.php

@@ -326,26 +326,30 @@ class BudgetController extends Controller
     }
 
     /**
-     * @param BudgetRepositoryInterface  $repository
-     * @param AccountRepositoryInterface $accountRepository
-     * @param Budget                     $budget
-     * @param LimitRepetition            $repetition
+     * @param Budget          $budget
+     * @param LimitRepetition $repetition
      *
      * @return View
      * @throws FireflyException
      */
-    public function showWithRepetition(
-        BudgetRepositoryInterface $repository, AccountRepositoryInterface $accountRepository, Budget $budget, LimitRepetition $repetition
-    ) {
+    public function showWithRepetition(Budget $budget, LimitRepetition $repetition)
+    {
         if ($repetition->budgetLimit->budget->id != $budget->id) {
             throw new FireflyException('This budget limit is not part of this budget.');
         }
-        $start    = $repetition->startdate;
-        $end      = $repetition->enddate;
-        $page     = intval(Input::get('page')) == 0 ? 1 : intval(Input::get('page'));
-        $pageSize = intval(Preferences::get('transactionPageSize', 50)->data);
-        $subTitle = trans('firefly.budget_in_month', ['name' => $budget->name, 'month' => $repetition->startdate->formatLocalized($this->monthFormat)]);
-        $accounts = $accountRepository->getAccountsByType([AccountType::DEFAULT, AccountType::ASSET, AccountType::CASH]);
+
+        /** @var BudgetRepositoryInterface $repository */
+        $repository = app(BudgetRepositoryInterface::class);
+        /** @var AccountRepositoryInterface $accountRepository */
+        $accountRepository = app(AccountRepositoryInterface::class);
+        $start             = $repetition->startdate;
+        $end               = $repetition->enddate;
+        $page              = intval(Input::get('page')) == 0 ? 1 : intval(Input::get('page'));
+        $pageSize          = intval(Preferences::get('transactionPageSize', 50)->data);
+        $subTitle          = trans(
+            'firefly.budget_in_month', ['name' => $budget->name, 'month' => $repetition->startdate->formatLocalized($this->monthFormat)]
+        );
+        $accounts          = $accountRepository->getAccountsByType([AccountType::DEFAULT, AccountType::ASSET, AccountType::CASH]);
 
 
         // collector:

app/Http/Controllers/Chart/AccountController.php

@@ -203,9 +203,12 @@ class AccountController extends Controller
     }
 
     /**
-     * @param Account $account
-     * @param Carbon  $start
-     * @param Carbon  $end
+     * @param JournalCollectorInterface $collector
+     * @param Account                   $account
+     * @param Carbon                    $start
+     * @param Carbon                    $end
+     *
+     * @return \Illuminate\Http\JsonResponse
      */
     public function incomeByCategory(JournalCollectorInterface $collector, Account $account, Carbon $start, Carbon $end)
     {

app/Http/Controllers/TransactionController.php

@@ -53,8 +53,9 @@ class TransactionController extends Controller
     }
 
     /**
-     * @param Request $request
-     * @param string  $what
+     * @param Request                    $request
+     * @param JournalRepositoryInterface $repository
+     * @param string                     $what
      *
      * @return View
      */
@@ -141,6 +142,8 @@ class TransactionController extends Controller
      * @param Request $request
      * @param string  $what
      *
+     * @param string  $date
+     *
      * @return View
      */
     public function indexDate(Request $request, string $what, string $date)

app/Models/Account.php

@@ -15,7 +15,6 @@ namespace FireflyIII\Models;
 
 use Carbon\Carbon;
 use Crypt;
-use DB;
 use FireflyIII\Exceptions\FireflyException;
 use Illuminate\Contracts\Encryption\DecryptException;
 use Illuminate\Database\Eloquent\Builder as EloquentBuilder;

app/Support/Preferences.php

@@ -59,7 +59,7 @@ class Preferences
     }
 
     /**
-     * @param User  $user
+     * @param \FireflyIII\User  $user
      * @param array $list
      *
      * @return array