Commit Graph

60 Commits

Author SHA1 Message Date
James Cole
4e51f0abc4
Clean up some code. 2020-10-13 06:35:33 +02:00
James Cole
59ab0c9f0d
Fix #3739 2020-08-26 18:18:53 +02:00
Aniruddha Maru
9d409a7412 Fix recurring transactions create
- If there's a lot of accounts to calculate balances for, then recurring transactions create page
  doesn't load. Partly because it has to calculate a lot of balances, but partly because the cache
  isn't being used at all because date is `new Date` rather than say, end of month.

Fix: Change Steam balance calculator to always default cache using end of month. Since cache is
'invalidated' upon any edit, there's no reason to use current datetime anywhere its not explicitly
required by user flow.
Fix: Don't calculate balances for revenue / expense accounts since those are unbounded.

Issue: #3597
2020-07-25 16:16:29 -07:00
James Cole
43436ae942
Fix issue with casting. 2020-04-19 06:00:11 +02:00
James Cole
61521cf478
Use correct methods. 2020-03-31 07:39:57 +02:00
James Cole
9e4b7f8bb4
Add IBAN to account validator. 2020-03-31 07:04:00 +02:00
James Cole
5445752588
Update some phpdocs, courtesy of Psalm. 2020-03-25 07:03:23 +01:00
James Cole
2b6c3fd743
Code cleanup that (hopefully) matches style CI 2020-03-17 15:01:00 +01:00
James Cole
3771cc3b75
Update email address 2020-01-31 07:32:04 +01:00
James Cole
92158e52ef
Update copyright of Firefly III to the GNU Affero General Public License as suggested by @nxxxse in #2607. This applies to all code in this commit from this moment onwards. 2019-10-02 06:37:26 +02:00
James Cole
79cf61b653
Fix #2434 2019-08-17 08:29:35 +02:00
James Cole
3eb695f2ad
Fix test for convert controller. 2019-07-13 20:57:06 +02:00
James Cole
7fd3f77c3e
Make sure the convert controller works again. 2019-07-05 19:43:16 +02:00
James Cole
c07ef3658b Refactor installer. 2019-03-30 11:03:39 +01:00
James Cole
f80de95bb0
Refactor code to traits. 2018-12-31 08:11:57 +01:00
James Cole
e117222dc2 Fix for #1679 2018-09-13 20:01:41 +02:00
James Cole
b33f8b70d4 Improve code coverage. 2018-09-07 20:12:22 +02:00
James Cole
136f983353
Move isOpeningBalance() to trait 2018-08-09 16:13:13 +02:00
James Cole
7943164375
Change scope of methods, add some notes. Prep for refactoring. 2018-08-09 16:07:33 +02:00
James Cole
4d5bdd25a8 Add phpdocs everywhere. 2018-07-22 08:10:16 +02:00
James Cole
ec7ef3a813
Various fixes for tests and code quality. 2018-07-20 20:53:48 +02:00
James Cole
44fb307da4
Code cleanup. 2018-07-20 14:34:56 +02:00
James Cole
7b41c5b301 Cast all translations to strings. 2018-07-15 09:38:49 +02:00
James Cole
b315882f58 Various code cleanup. 2018-07-08 12:08:53 +02:00
James Cole
db149ca6e1 Fix tests. 2018-07-01 09:27:22 +02:00
James Cole
4a12d4d156 Code cleanup [skip ci] 2018-06-06 21:23:00 +02:00
James Cole
48357d1cc9
Fix #1273 and #1272 2018-04-24 19:48:42 +02:00
James Cole
f78b8f9267
Some code for #1272 2018-04-24 19:26:16 +02:00
James Cole
8032684ad0
Some code cleanup for #1272 2018-04-22 17:10:11 +02:00
James Cole
a3c34e6b3c
Code cleanup 2018-04-02 15:10:40 +02:00
James Cole
c86b207b1c
Fix #1297 2018-03-26 20:48:47 +02:00
James Cole
a5fd821e0c
Code to implement #1168 and #1197. 2018-03-07 10:18:22 +01:00
James Cole
54ba18975a
Use different method for finding objects. 2018-02-28 20:23:45 +01:00
James Cole
1b304bf85e
use journal repository instead of direct calls. 2018-02-25 19:09:05 +01:00
James Cole
8bd76d1ff0
Various code cleanup. 2017-12-22 18:32:43 +01:00
James Cole
ff9ad859b3
Update copyright [skip ci] 2017-12-17 14:41:58 +01:00
James Cole
78335e5814
Expand tests, do code cleanup. 2017-12-17 14:30:53 +01:00
James Cole
9086259a65
Small code change for controllers. 2017-12-16 19:46:36 +01:00
James Cole
ffca858b8d
Code clean up. 2017-11-15 12:25:49 +01:00
James Cole
649dca77f5
Code clean up. 2017-11-15 10:52:29 +01:00
James Cole
ac461d64a8
New copyright notice. 2017-10-21 08:40:00 +02:00
James Cole
6e80b2f4c8
Update tests. 2017-09-12 19:47:29 +02:00
James Cole
04a8a0e6a1
Code clean up 2017-06-24 13:04:41 +02:00
James Cole
e5db5a7b5c
Various code clean up. 2017-06-07 07:38:58 +02:00
James Cole
17fb6983d8
Fix issue #637 with cash accounts. 2017-05-07 19:45:40 +02:00
James Cole
595596d73f
Apparently this is changed in PHPStorm’s formatting templates so there you go [skip ci]. 2017-04-09 07:44:22 +02:00
James Cole
176c44e2b9
Remove newline [skip ci] 2017-03-08 20:38:08 +01:00
James Cole
9d22bbee1c
Add code coverage ignore instructions. 2017-03-04 11:19:44 +01:00
James Cole
d9aa074330
Large commit to get rid of a lot of static methods. 2017-03-04 07:18:35 +01:00
James Cole
47aa996b6b
This fixes #567 2017-02-15 15:12:46 +01:00