IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Avoid the potential negative left shift in test_xaccAccountType_Compatibility()

Browse Source 
ACCT_TYPE_NONE is -1 but it should always be masked out by compat;
explicitly check for this instead of relying on that.

Add parenthesis to be clear that the default precedence is what's intended.
This commit is contained in:
Simon Arlott
2023-06-24 12:40:29 +01:00
parent d7b2b06bae
commit 069eb61a3f
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
libgnucash/engine/test/utest-Account.cpp
View File

@@ -2587,7 +2587,7 @@ test_xaccAccountType_Compatibility (void)
else if (type == ACCT_TYPE_TRADING)
g_assert_cmpint (compat, == , trading_compat);
for (auto parent = ACCT_TYPE_NONE; parent < ACCT_TYPE_LAST; ++parent)
if (1 << parent & compat)
if (parent != ACCT_TYPE_NONE && (1 << parent) & compat)
g_assert (xaccAccountTypesCompatible (parent, type));
else
g_assert (!xaccAccountTypesCompatible (parent, type));