Regularize the naming of the Finance::Quote auxiliary scripts. Remove

the obsolete gnc-prices script.  Move the to the bin directory the
scripts that weren't already there.


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@13303 57a11ea4-9604-0410-9ed3-97b8803252fd

ChangeLog

@@ -1,3 +1,19 @@
+2006-02-19  David Hampton  <hampton@employees.org>
+
+	* src/quotes/finance-quote-helper.in:
+	* src/quotes/dump-finance-quote:
+	* src/quotes/update-finance-quote.in:
+	* src/quotes/Makefile.am:
+	* src/quotes/value_portfolio:
+	* src/quotes/gnc-prices:
+	* src/quotes/README:
+	* src/quotes/finance-quote-check.in:
+	* src/core-utils/gw-core-utils-spec.scm:
+	* src/scm/price-quotes.scm: Regularize the naming of the
+	Finance::Quote auxiliary scripts. Remove the obsolete gnc-prices
+	script.  Move the to the bin directory the scripts that weren't
+	already there.
+
 2006-02-19  Joshua Sled  <jsled@asynchronous.org>
 
 	* src/app-utils/gnc-account-merge.[ch]: Remove placeholder-difference

src/core-utils/gw-core-utils-spec.scm

@@ -44,4 +44,12 @@
    '()
    "Is debugging mode on?")
 
+  (gw:wrap-function
+   ws
+   'g:find-program-in-path
+   '(<gw:mchars> callee-owned const)
+   "g_find_program_in_path"
+   '(((<gw:mchars> caller-owned) program))
+   "Get a boolean value from gconf.")
+
 )

src/quotes/Makefile.am

@@ -1,23 +1,18 @@
-
-gncsharedir = ${GNC_SHAREDIR}
-
-bin_SCRIPTS = dump-finance-quote gnc-prices update-finance-quote
-gncshare_SCRIPTS = finance-quote-helper finance-quote-check
+bin_SCRIPTS = gnc-fq-check gnc-fq-dump gnc-fq-helper gnc-fq-update
 
 EXTRA_DIST = \
   Quote_example.pl \
-  finance-quote-check.in \
-  finance-quote-helper.in \
-  gnc-prices \
-  update-finance-quote.in \
-  value_portfolio \
-  dump-finance-quote
+  gnc-fq-check.in \
+  gnc-fq-dump \
+  gnc-fq-helper.in \
+  gnc-fq-update.in \
+  gnc-value-portfolio
 
 ## We borrow guile's convention and use @-...-@ as the substitution
 ## brackets here, instead of the usual @...@.  This prevents autoconf
 ## from substituting the values directly into the left-hand sides of
 ## the sed substitutions.
-finance-quote-helper: finance-quote-helper.in Makefile
+gnc-fq-helper: gnc-fq-helper.in Makefile
 	rm -f $@.tmp
 	sed < $< > $@.tmp \
             -e 's:@-PERL-@:${PERL}:g' \
@@ -25,7 +20,7 @@ finance-quote-helper: finance-quote-helper.in Makefile
 	chmod +x $@.tmp
 	mv $@.tmp $@
 
-finance-quote-check: finance-quote-check.in Makefile
+gnc-fq-check: gnc-fq-check.in Makefile
 	rm -f $@.tmp
 	sed < $< > $@.tmp \
             -e 's:@-PERL-@:${PERL}:g' \
@@ -33,7 +28,7 @@ finance-quote-check: finance-quote-check.in Makefile
 	chmod +x $@.tmp
 	mv $@.tmp $@
 
-update-finance-quote: update-finance-quote.in Makefile
+gnc-fq-update: gnc-fq-update.in Makefile
 	rm -f $@.tmp
 	sed < $< > $@.tmp \
             -e 's:@-PERL-@:${PERL}:g' \
@@ -41,4 +36,4 @@ update-finance-quote: update-finance-quote.in Makefile
 	chmod +x $@.tmp
 	mv $@.tmp $@
 
-CLEANFILES = finance-quote-helper finance-quote-check update-finance-quote
+CLEANFILES = gnc-fq-helper gnc-fq-check gnc-fq-update

src/quotes/README

@@ -2,18 +2,30 @@
 
 This directory contains assorted stock quote scripts.
 
-finance-quote-helper.in:
+gnc-fq-check.in:
 
-  Source file for finance-quote-helper which is a perl script that
+  Source file for gnc-fq-check which is a perl script that allows
+  gnucash to determine if Finance::Quote is installed properly.  The
+  responses is a scheme form.
+
+gnc-fq-dump:
+
+  A perl script that retrieves a quote from Finance::Quote and dumps
+  the response to the terminal.  Its useful for determining problems
+  with F::Q.
+
+gnc-fq-helper.in:
+
+  Source file for gnc-fq-helper which is a perl script that
   allows gnucash to communicate with Finance::Quote over pipes from
   guile.  The requests and responses are scheme forms.
 
-gnc-prices:
+gnc-fq-update.in:
 
-  Deprecated wrapper to support old setup.  Use "gnucash --add-quotes
-  filename" instead.
+  Source file for gnc-fq-update which is a perl script that updates
+  Finance::Quote from CPAN.
 
-value_portfolio:
+gnc-value-portfolio:
 
   A stand-alone perl script for updating and printing the value of a
   portfolio.  To use this script, edit the the first few lines at the

src/quotes/gnc-prices

@@ -1,23 +0,0 @@
-#!/bin/sh
-#
-# Usage: gnc-prices <datafile>
-
-# Vestigal script for adding current prices to a gnucash data file for
-# all the accounts having a price source.
-
-if [ "$#" -ne 1 ]
-then
-  echo "Usage: gnc-prices <file>"
-  exit 1
-fi
-
-echo -n "gnc-prices is obsolete: "
-
-if [ "$1"x = x ]
-then
-  echo "please use gnucash --add-price-quotes <file>"
-else
-  echo "please use gnucash --add-price-quotes $1"
-fi
-
-exec gnucash --add-price-quotes "$1"

src/scm/price-quotes.scm

@@ -31,6 +31,7 @@
 (use-modules (srfi srfi-1))
 (use-modules (gnucash main) (g-wrapped gw-gnc)) ;; FIXME: delete after we finish modularizing.
 (use-modules (gnucash gnc-module))
+(use-modules (g-wrapped gw-core-utils))
 (use-modules (g-wrapped gw-gnome-utils))
 
 (gnc:module-load "gnucash/app-utils" 0)
@@ -242,7 +243,7 @@
 ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
 
 (define gnc:*finance-quote-check*
-  (gnc:gnome-locate-data-file "finance-quote-check"))
+  (g:find-program-in-path "gnc-fq-check"))
 
 (define (gnc:fq-check-sources)
   (let ((program #f))
@@ -290,7 +291,7 @@
 ;; src/engine/gnc-pricedb.h
 
 (define gnc:*finance-quote-helper*
-  (gnc:gnome-locate-data-file "finance-quote-helper"))
+  (g:find-program-in-path "gnc-fq-helper"))
 
 (define (gnc:fq-get-quotes requests)
   ;; requests should be a list where each item is of the form
@@ -310,7 +311,7 @@
   ;; symbol if the corresponding method call fails, or a list
   ;; otherwise. A quote-result list will contain the symbol
   ;; representing the item being quoted, followed by an alist
-  ;; detailing the quote data from finance-quote-helper.
+  ;; detailing the quote data from gnc-fq-helper.
   ;;
   ;; Possible error symbols and their meanings are:
   ;;   missing-lib    One of the required perl libs is missing
@@ -327,7 +328,7 @@
   ;;
   ;; Also note that any given value in the alist might be
   ;; 'failed-conversion if the Finance::Quote result for that field
-  ;; was unparsable.  See the finance-quote-helper for more details
+  ;; was unparsable.  See the gnc-fq-helper for more details
   ;; about it's output.
 
   (let ((quoter #f))
@@ -387,7 +388,7 @@
     ;; Finance::Quote method.
     ;; 
     ;; Returns a list of the info needed for a set of calls to
-    ;; finance-quote-helper.  Each item will of the list will be of the
+    ;; gnc-fq-helper.  Each item will of the list will be of the
     ;; form:
     ;;
     ;; (("yahoo" (commodity-1 currency-1 tz-1)
@@ -418,7 +419,7 @@
 	    ;; Now collect symbols going to the same backend.
 	    (item-list->hash! commodity-list quote-hash car cdr hash-ref hash-set! #t)
 
-	    ;; Now translate to just what finance-quote-helper expects.
+	    ;; Now translate to just what gnc-fq-helper expects.
 	    (append
 	     (hash-fold
 	      (lambda (key value prior-result)
@@ -645,9 +646,9 @@
       (if (gnc:ui-is-running?)
           (gnc:error-dialog #f
            (_ "You are missing some needed Perl libraries.
-Run 'update-finance-quote' as root to install them."))
+Run 'gnc-fq-update' as root to install them."))
           (gnc:warn (_ "You are missing some needed Perl libraries.
-Run 'update-finance-quote' as root to install them.") "\n")))
+Run 'gnc-fq-update' as root to install them.") "\n")))
      ((member 'system-error fq-results)
       (set! keep-going? #f)
       (if (gnc:ui-is-running?)