IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Bug 797514 - Changing transaction unreconciles a split inconsistently

Browse Source 
Partial: This make sure that the split's reconcile status gets updated
before the transaction is committed.
This commit is contained in:
John Ralls
2020-09-24 17:49:35 -07:00
parent 9ef405a358
commit 0ef70ab7c9
1 changed files with 23 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
gnucash/register/ledger-core/split-register.c
View File

@@ -1677,6 +1677,26 @@ gnc_split_register_save_to_copy_buffer (SplitRegister *reg,
return TRUE;
}
static void
unreconcile_splits (SplitRegister* reg)
{
if (reg->unrecn_splits == NULL)
return; //Nothing to do.
PINFO ("Unreconcile %d splits of reconciled transaction",
g_list_length (reg->unrecn_splits));
for (GList* node = reg->unrecn_splits; node; node = node->next)
{
Split* split = node->data;
Transaction* txn = xaccSplitGetParent (split);
if (!xaccTransIsOpen (txn))
PWARN ("Unreconcile of split failed because its parent transaction wasn't open for editing");
else if (xaccSplitGetReconcile (split) == YREC)
xaccSplitSetReconcile (split, NREC);
}
g_list_free (reg->unrecn_splits);
reg->unrecn_splits = NULL;
}
gboolean
gnc_split_register_save (SplitRegister* reg, gboolean do_commit)
@@ -1756,6 +1776,7 @@ gnc_split_register_save (SplitRegister* reg, gboolean do_commit)
info->pending_trans_guid = *guid_null ();
PINFO ("committing trans (%p)", trans);
unreconcile_splits (reg);
xaccTransCommitEdit (trans);
gnc_resume_gui_refresh ();
@@ -1807,6 +1828,7 @@ gnc_split_register_save (SplitRegister* reg, gboolean do_commit)
if (xaccTransIsOpen (pending_trans))
{
g_warning ("Impossible? committing pending %p", pending_trans);
unreconcile_splits (reg);
xaccTransCommitEdit (pending_trans);
}
else if (pending_trans)
@@ -1934,29 +1956,10 @@ gnc_split_register_save (SplitRegister* reg, gboolean do_commit)
pending_trans = NULL;
info->pending_trans_guid = *guid_null ();
}
unreconcile_splits (reg);
xaccTransCommitEdit (trans);
}
/* If there are splits in the unreconcile list and we are committing
* we need to unreconcile them */
if (do_commit && (reg->unrecn_splits != NULL))
{
GList* node;
PINFO ("Unreconcile %d splits of reconciled transaction",
g_list_length (reg->unrecn_splits));
for (node = reg->unrecn_splits; node; node = node->next)
{
Split* split = node->data;
if (xaccSplitGetReconcile (split) == YREC)
xaccSplitSetReconcile (split, NREC);
}
g_list_free (reg->unrecn_splits);
reg->unrecn_splits = NULL;
}
gnc_table_clear_current_cursor_changes (reg->table);
gnc_resume_gui_refresh ();