IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Create specialized popup items their respective source files

Browse Source 
The extracted function in gnc_item_edit was unneeded and confusing
This commit is contained in:
Geert Janssens 2017-03-09 20:32:59 +01:00
parent 58bfd3e1e9
commit 131462ca41
4 changed files with 6 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/register/register-gnome/combocell-gnome.c
View File

@ -753,9 +753,10 @@ gnc_combo_cell_gui_realize (BasicCell *bcell, gpointer data)
box->sheet = sheet;
box->item_edit = item_edit;
if (cell->shared_store)
box->item_list = gnc_item_edit_new_list(box->item_edit, cell->shared_store);
box->item_list = GNC_ITEM_LIST (gnc_item_list_new (cell->shared_store));
else
box->item_list = gnc_item_edit_new_list(box->item_edit, box->tmp_store);
box->item_list = GNC_ITEM_LIST (gnc_item_list_new (box->tmp_store));
gtk_widget_show_all (GTK_WIDGET(box->item_list));
gtk_layout_put (GTK_LAYOUT(sheet),
GTK_WIDGET(box->item_list), 0, 0);
g_object_ref_sink(box->item_list);

5
src/register/register-gnome/datecell-gnome.c
View File

@ -52,7 +52,7 @@
typedef struct _PopBox
{
GnucashSheet *sheet;
GncItemEdit *item_edit;
GncItemEdit *item_edit;
GNCDatePicker *date_picker;
gboolean signals_connected; /* date picker signals connected? */
@ -607,7 +607,8 @@ gnc_date_cell_realize (BasicCell *bcell, gpointer data)
/* initialize gui-specific, private data */
box->sheet = sheet;
box->item_edit = item_edit;
box->date_picker = gnc_item_edit_new_date_picker (box->item_edit);
box->date_picker = GNC_DATE_PICKER (gnc_date_picker_new ());
gtk_widget_show_all (GTK_WIDGET(box->date_picker));
gtk_layout_put (GTK_LAYOUT(sheet),
GTK_WIDGET(box->date_picker), 0, 0);
g_object_ref_sink(box->date_picker);

25
src/register/register-gnome/gnucash-item-edit.c
View File

@ -1217,31 +1217,6 @@ gnc_item_edit_new (GnucashSheet *sheet)
}
GncItemList *
gnc_item_edit_new_list (GncItemEdit *item_edit, GtkListStore *shared_store)
{
GncItemList *item_list;
g_return_val_if_fail (GNC_IS_ITEM_EDIT(item_edit), NULL);
item_list = GNC_ITEM_LIST (gnc_item_list_new (shared_store));
return item_list;
}
GNCDatePicker *
gnc_item_edit_new_date_picker (GncItemEdit *item_edit)
{
GNCDatePicker *gdp;
g_return_val_if_fail (GNC_IS_ITEM_EDIT (item_edit), NULL);
gdp = GNC_DATE_PICKER (gnc_date_picker_new ());
return gdp;
}
void
gnc_item_edit_show_popup (GncItemEdit *item_edit)
{

3
src/register/register-gnome/gnucash-item-edit.h
View File

@ -117,9 +117,6 @@ void gnc_item_edit_get_pixel_coords (GncItemEdit *item_edit,
GtkWidget *gnc_item_edit_new (GnucashSheet *sheet);
GncItemList * gnc_item_edit_new_list (GncItemEdit *item_edit, GtkListStore *shared_store);
GNCDatePicker * gnc_item_edit_new_date_picker (GncItemEdit *item_edit);
void gnc_item_edit_set_popup (GncItemEdit *item_edit,
GtkWidget *popup_item,
GetPopupHeight get_popup_height,