IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix GNCInteractor_hadErrors() that reported too many errors. Fixes #339504.

Browse Source 
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@13867 57a11ea4-9604-0410-9ed3-97b8803252fd
This commit is contained in:
Christian Stimming
2006-04-27 20:44:22 +00:00
parent a05c7944eb
commit 16add32a83
4 changed files with 26 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
ChangeLog
View File

@@ -1,3 +1,9 @@
2006-04-27 Christian Stimming <stimming@tuhh.de>
* src/import-export/hbci/hbci-interaction.c: Fix
GNCInteractor_hadErrors() that reported too many errors. Fixes
#339504.
2006-04-26 Joshua Sled <jsled@asynchronous.org>
* src/gnome/dialog-scheduledxaction.c

2
src/import-export/hbci/gnc-hbci-utils.c
View File

@@ -453,7 +453,7 @@ gnc_AB_BANKING_execute (GtkWidget *parent, AB_BANKING *api,
}
GNCInteractor_set_cache_valid (inter, TRUE);
if (resultcode <= 20 && (! GNCInteractor_hadErrors(inter)) ) {
if (resultcode <= 20 && (! GNCInteractor_errorsLogged (inter)) ) {
return TRUE;
}
else {

13
src/import-export/hbci/hbci-interaction.c
View File

@@ -216,8 +216,17 @@ void GNCInteractor_reparent (GNCInteractor *i, GtkWidget *new_parent)
gboolean GNCInteractor_hadErrors (const GNCInteractor *i)
{
g_assert (i);
return (i->msgBoxError != 0) ||
(i->min_loglevel < AB_Banking_LogLevelNotice);
return (i->msgBoxError != 0);
}
gboolean GNCInteractor_errorsLogged (const GNCInteractor *i)
{
g_assert (i);
/* Note: Unfortunately this does not mean at all that there actually
has been any error. Old aqbanking versions had some debugging
messages set at "error" level, and there can also be errors when
closing connection that don't affect the job result at all. */
return (i->min_loglevel < AB_Banking_LogLevelNotice);
}
/* ************************************************************

8
src/import-export/hbci/hbci-interaction.h
View File

@@ -46,7 +46,15 @@ gboolean GNCInteractor_get_cache_valid(const GNCInteractor *i);
void GNCInteractor_set_cache_valid(GNCInteractor *i, gboolean value);
GtkWidget *GNCInteractor_parent(GNCInteractor *i);
void GNCInteractor_add_log_text (GNCInteractor *i, const char *msg);
/** Returns true if aqbanking requested to show a msgBox of type
error. (Note: This happens very seldomly.) */
gboolean GNCInteractor_hadErrors (const GNCInteractor *i);
/** Returns true if any error messages have been logged. Note:
Unfortunately this does not mean at all that there actually has
been any error. Old aqbanking versions had some debugging messages
set at "error" level, and there can also be errors when closing
connection that don't affect the job result at all. */
gboolean GNCInteractor_errorsLogged (const GNCInteractor *i);
#endif