IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2026-08-19 01:15:04 -05:00
Code Issues Packages Projects Releases Wiki Activity

Don't g_strdup char* returned by scm_to_locale_string

Browse Source 
Previous code was returning a duplicated string and released the
original one. It's no better than returning the original returned
char* instead.
This commit is contained in:
Christopher Lam
2021-10-16 22:50:09 +08:00
parent 19a91f041e
commit 171ce9413b
1 changed files with 2 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
bindings/engine.i
+2 -10
View File
@@ -243,16 +243,11 @@ time64 time64CanonicalDayTime(time64 t);
{
SCM key_scm = SCM_CAR (path_scm);
char *key;
gchar* gkey;
if (!scm_is_string (key_scm))
break;
key = scm_to_locale_string (key_scm);
gkey = g_strdup (key);
free (key);
path = g_list_prepend (path, gkey);
path = g_list_prepend (path, key);
path_scm = SCM_CDR (path_scm);
}
@@ -462,13 +457,10 @@ void qof_book_set_string_option(QofBook* book, const char* opt_name, const char*
{
SCM key_scm = SCM_CAR (path_scm);
char *key;
gchar* gkey;
if (!scm_is_string (key_scm))
break;
key = scm_to_locale_string (key_scm);
gkey = g_strdup (key);
free (key);
path = g_list_prepend (path, gkey);
path = g_list_prepend (path, key);
path_scm = SCM_CDR (path_scm);
}
$1 = g_list_reverse (path);