IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Bug 798695 - Deleting everything from the "Transfer" cell after suggestions pop-up restricts search to the first 30 accounts

Browse Source 
The combo box list is capable of displaying all accounts if expanded
without starting searching, so changing the search string to "" shouldn't
only return a small subset of accounts with no way to fix it.

Skip the search and return all accounts in the combo box as it normally
does if the account list is opened without searching for something.
This commit is contained in:
Simon Arlott 2023-05-29 21:14:00 +01:00
parent 8e360bbe84
commit 2555c5b0b9
No known key found for this signature in database
GPG Key ID: DF001BFD83E75990
1 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
gnucash/register/register-gnome/combocell-gnome.c
View File

@ -633,6 +633,20 @@ gnc_combo_cell_type_ahead_search (const gchar* newval,
gtk_list_store_clear (box->tmp_store);
unblock_list_signals (cell);
if (strlen (newval) == 0) {
/* Deleting everything in the cell shouldn't provide a search result for
* "" because that will just be the first MAX_NUM_MATCHES accounts which
* isn't very useful.
*
* Skip the search show the popup again with all accounts. Clear the
* temp store or the cell will be pre-filled with the first account.
*/
gnc_item_list_set_temp_store (box->item_list, NULL);
gnc_item_edit_show_popup (box->item_edit);
box->list_popped = TRUE;
goto cleanup;
}
while (valid && num_found < MAX_NUM_MATCHES)
{
gchar* str_data = NULL;
@ -659,6 +673,8 @@ gnc_combo_cell_type_ahead_search (const gchar* newval,
gnc_item_edit_show_popup (box->item_edit);
box->list_popped = TRUE;
}
cleanup:
g_regex_unref (regex);
return match_str;
}
@ -1213,4 +1229,3 @@ gnc_combo_cell_set_autosize (ComboCell* cell, gboolean autosize)
box->autosize = autosize;
}