Bug 798335 - No longer possible to change trading account

Strip trading splits only if "Use Trading Accounts" is enabled
for the book so that users who want to manage trading accounts by
hand may do so.
This commit is contained in:
John Ralls 2021-10-14 17:21:13 -07:00
parent 003b0a5deb
commit 2f4438ab28

View File

@ -789,11 +789,8 @@ xaccTransScrubImbalance (Transaction *trans, Account *root,
ENTER ("()");
/* Must look for orphan splits and remove trading splits even if
* there is no imbalance and we're not using trading accounts.
*/
/* Must look for orphan splits even if there is no imbalance. */
xaccTransScrubSplits (trans);
xaccTransClearTradingSplits (trans);
/* Return immediately if things are balanced. */
if (xaccTransIsBalanced (trans))
@ -805,10 +802,11 @@ xaccTransScrubImbalance (Transaction *trans, Account *root,
if (! xaccTransUseTradingAccounts (trans))
{
gnc_transaction_balance_no_trading (trans, root, account);
LEAVE ("transaction balanced, no trading accounts");
LEAVE ("transaction balanced, no managed trading accounts");
return;
}
xaccTransClearTradingSplits (trans);
imbalance = xaccTransGetImbalanceValue (trans);
if (! gnc_numeric_zero_p (imbalance))
{