IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Valgrind: fix "definitely lost" memory from get_random_string() - test-job

Browse Source 
==88779== 8 bytes in 1 blocks are definitely lost in loss record 9 of 461
==88779==    at 0x4848A13: calloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so)
==88779==    by 0x503C550: g_malloc0 (in /usr/lib/x86_64-linux-gnu/libglib-2.0.so.0.7600.1)
==88779==    by 0x10B871: get_random_string_without (test-stuff.c:312)
==88779==    by 0x10B8EE: get_random_string (test-stuff.c:333)
==88779==    by 0x10AB9F: test_string_fcn (test-job.c:157)
==88779==    by 0x10A7B1: test_job (test-job.c:87)
==88779==    by 0x10AFF3: main (test-job.c:262)

+ 3 more
This commit is contained in:
Richard Cohen 2023-07-07 18:21:31 +01:00
parent 49240e9b5a
commit 30b47d1669
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
libgnucash/engine/test/test-job.c
View File

@ -113,13 +113,13 @@ test_job (void)
}
#endif
{
const char *str = get_random_string();
const char *res;
char *str = get_random_string();
gncJobSetName (job, str);
res = qof_object_printable (GNC_ID_JOB, job);
const char *res = qof_object_printable (GNC_ID_JOB, job);
do_test (res != NULL, "Printable NULL?");
do_test (g_strcmp0 (str, res) == 0, "Printable equals");
g_free (str);
}
{
GList *list;
@ -154,7 +154,7 @@ test_string_fcn (QofBook *book, const char *message,
const char * (*get)(const GncJob *))
{
GncJob *job = gncJobCreate (book);
char const *str = get_random_string ();
char *str = get_random_string ();
do_test (!qof_instance_is_dirty (QOF_INSTANCE(job)), "test if start dirty");
gncJobBeginEdit (job);
@ -169,6 +169,7 @@ test_string_fcn (QofBook *book, const char *message,
*/
// do_test (!qof_instance_is_dirty (QOF_INSTANCE(job)), "test dirty after commit");
do_test (g_strcmp0 (get (job), str) == 0, message);
g_free (str);
gncJobSetActive (job, FALSE);
count++;
}