IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

[transaction] convert collector map to for-each

Browse Source 
collectors are accumulator-type objects, being mutated with each call,
rather than functional objects. (map) is meant for functional
constructs, returning a list to current continuation. We're not using
the (map) output, so, change it to (for-each) to emphasise this.
This commit is contained in:
Christopher Lam
2018-08-20 10:34:39 +08:00
parent 83ad9e4b89
commit 353eee58cb
1 changed files with 15 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
gnucash/report/standard-reports/transaction.scm
View File

@@ -1605,23 +1605,23 @@ be excluded from periodic reporting.")
(add-split-row othersplits calculated-cells def:alternate-row-style #f))
(delete current (xaccTransGetSplitList (xaccSplitGetParent current)))))
(map (lambda (collector value)
(if value
(collector 'add (gnc:gnc-monetary-commodity value) (gnc:gnc-monetary-amount value))))
primary-subtotal-collectors
split-values)
(for-each
(lambda (collector value)
(if value
(collector 'add (gnc:gnc-monetary-commodity value) (gnc:gnc-monetary-amount value))))
primary-subtotal-collectors split-values)
(map (lambda (collector value)
(if value
(collector 'add (gnc:gnc-monetary-commodity value) (gnc:gnc-monetary-amount value))))
secondary-subtotal-collectors
split-values)
(for-each
(lambda (collector value)
(if value
(collector 'add (gnc:gnc-monetary-commodity value) (gnc:gnc-monetary-amount value))))
secondary-subtotal-collectors split-values)
(map (lambda (collector value)
(if value
(collector 'add (gnc:gnc-monetary-commodity value) (gnc:gnc-monetary-amount value))))
total-collectors
split-values)
(for-each
(lambda (collector value)
(if value
(collector 'add (gnc:gnc-monetary-commodity value) (gnc:gnc-monetary-amount value))))
total-collectors split-values)
(if (and primary-subtotal-comparator
(or (not next)