IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix two places where we were letting the split values become incoherent

Browse Source 
with account balances.
   Comment two possible bugs related to capgains and dirtying (or not) Splits.


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@13134 57a11ea4-9604-0410-9ed3-97b8803252fd
This commit is contained in:
Chris Shoemaker
2006-02-06 20:41:40 +00:00
parent 720dd91074
commit 3908088b52
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/engine/Transaction.c
View File

@@ -503,6 +503,8 @@ xaccSplitLookup (const GUID *guid, QofBook *book)
* to send out a change event.
*/
/* CHECKME: This function modifies the Split without dirtying or
checking its parent. Is that correct? */
void
xaccSplitDetermineGainStatus (Split *split)
{
@@ -1632,7 +1634,7 @@ xaccTransSetCurrency (Transaction *trans, gnc_commodity *curr)
}
qof_instance_set_dirty(QOF_INSTANCE(trans));
mark_trans (trans);
mark_trans(trans); /* Dirty balance of every account in trans */
qof_commit_edit(QOF_INSTANCE(trans));
}
@@ -2090,7 +2092,7 @@ xaccTransIsOpen (const Transaction *trans)
return trans ? (0 < trans->inst.editlevel) : FALSE;
}
/* Only used by postgres backend. Not sure if they should dirty the trans. */
/* Only used by postgres backend. Not sure if it should dirty the trans. */
void
xaccTransSetVersion (Transaction *trans, gint32 vers)
{
@@ -2202,7 +2204,8 @@ xaccTransAppendSplit (Transaction *trans, Split *split)
if (gnc_numeric_check (new_value) == GNC_ERROR_OK)
split->value = new_value;
SET_GAINS_VDIRTY(split);
SET_GAINS_VDIRTY(split); /* Is this right? Dirty gains even if error? */
mark_split(split);
}
qof_commit_edit(QOF_INSTANCE(trans));
}
@@ -3387,6 +3390,7 @@ xaccTransReverse (Transaction *trans)
SET_GAINS_A_VDIRTY(split);
split->reconciled = NREC;
xaccSplitSetDateReconciledSecs (split, 0);
mark_split(split);
}
if (trans->splits)