Never include "config.h" from a header file. Doing so makes it nigh

impossible to override configuration settings.


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@13549 57a11ea4-9604-0410-9ed3-97b8803252fd

ChangeLog

@@ -1,3 +1,8 @@
+2006-03-09  David Hampton  <hampton@employees.org>
+
+	* numerous: Never include "config.h" from a header file. Doing so
+	makes it nigh impossible to override configuration settings.
+
 2006-03-08  David Hampton  <hampton@employees.org>
 
 	* numerous: Remove more functions to be deprecated in

lib/libc/setenv.c

@@ -20,6 +20,8 @@
  *
 \********************************************************************/
 
+#include "config.h"
+
 #include <glib.h>
 #include <glib/gprintf.h>
 #include <stdlib.h>

lib/libc/setenv.h

@@ -23,8 +23,6 @@
 #ifndef __SETENV_H
 #define __SETENV_H
 
-#include "config.h"
-
 #ifndef HAVE_SETENV
 
 int setenv(const char *name, const char *value, int overwrite);

lib/libqof/backend/file/qsf-backend.c

@@ -23,6 +23,9 @@
 
 #define _GNU_SOURCE
 
+#include "config.h"
+#undef G_DISABLE_DEPRECATED /* for g_strncasecmp */
+
 #include "qof.h"
 #include "qof-backend-qsf.h"
 #include "qsf-xml.h"

lib/libqof/backend/file/qsf-xml-map.c

@@ -23,6 +23,8 @@
 
 #define _GNU_SOURCE
 
+#include "config.h"
+
 #include <libxml/xmlversion.h>
 #include <libxml/xmlmemory.h>
 #include <libxml/tree.h>

lib/libqof/backend/file/qsf-xml.c

@@ -23,6 +23,8 @@
 
 #define _GNU_SOURCE
 
+#include "config.h"
+
 #include <libxml/xmlversion.h>
 #include "qof.h"
 #include "qof-backend-qsf.h"

lib/libqof/qof/deprecated.c

@@ -21,6 +21,7 @@
  *                                                                  *
 \********************************************************************/
 
+#include "config.h"
 #include "qof.h"
 
 /* Don't be fooled: gnc_trace_num_spaces has external linkage and

lib/libqof/qof/gnc-engine-util.h

@@ -35,7 +35,6 @@
 
 #include <glib.h>
 #include <stddef.h>
-#include "config.h"
 #include "qof.h"
 
 /* Macros *****************************************************/

lib/libqof/qof/kvp-util-p.h

@@ -23,8 +23,6 @@
 #ifndef XACC_KVP_UTIL_P_H
 #define XACC_KVP_UTIL_P_H
 
-#include "config.h"
-
 #include "guid.h"
 #include "kvp_frame.h"
 

lib/libqof/qof/kvp-util.h

@@ -33,8 +33,6 @@
 #ifndef GNC_KVP_UTIL_H
 #define GNC_KVP_UTIL_H
 
-#include "config.h"
-
 typedef struct {
   gpointer key;
   gpointer value;

lib/libqof/qof/qof_book_merge.c

@@ -21,6 +21,7 @@
  *                                                                   *
  ********************************************************************/
 
+#include "config.h"
 #include "qof.h"
 
 static QofLogModule log_module = QOF_MOD_MERGE;

lib/libqof/qof/qofbackend-p.h

@@ -41,7 +41,6 @@
 #ifndef QOF_BACKEND_P_H
 #define QOF_BACKEND_P_H
 
-#include "config.h"
 #include "qof-be-utils.h"
 #include "qofbackend.h"
 #include "qofbook.h"

lib/libqof/qof/qofchoice.c

@@ -21,6 +21,7 @@
  *  Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  */
 
+#include "config.h"
 #include <glib.h>
 #include "qof.h"
 #include "qofchoice.h"

lib/libqof/qof/qofgobj.c

@@ -20,6 +20,7 @@
  *                                                                  *
 \********************************************************************/
 
+#include "config.h"
 #include "qof.h"
 #include "qofgobj.h"
 

lib/libqof/qof/qofinstance.c

@@ -27,6 +27,7 @@
  * Copyright (C) 2003 Linas Vepstas <linas@linas.org>
  */
 
+#include "config.h"
 #include "qof.h"
 #include "kvp-util-p.h"
 #include "qofbook-p.h"

lib/libqof/qof/qofquery-deserial.c

@@ -21,7 +21,7 @@
  *                                                                  *
 \********************************************************************/
 
-// #include "config.h"
+#include "config.h"
 
 /* NOTE: Development of this idea has ceased and this file is
 no longer included in the QOF library. It remains in CVS for now.*/

lib/libqof/qof/qofreference.c

@@ -21,6 +21,7 @@
  *  Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
  */
  
+#include "config.h"
 #include "qofreference.h"
 
 static void

lib/libqof/qof/qofsql.c

@@ -28,10 +28,11 @@
 */
 #define _GNU_SOURCE
 
+#include "config.h"
+
 #include <stdlib.h>   /* for working atoll */
 #include <errno.h>
 #include "glib.h"
-#include "config.h"
 #ifdef HAVE_GDA
 #include <sql/sql_parser.h>
 #else

src/RecnWindow.h

@@ -27,8 +27,6 @@
 #ifndef RECONCILE_H
 #define RECONCILE_H
 
-#include "config.h"
-
 #include "gnc-ui-common.h"
 #include "Account.h"
 

src/app-utils/gnc-exp-parser.h

@@ -20,8 +20,6 @@
 #ifndef GNC_EXP_PARSER_H
 #define GNC_EXP_PARSER_H
 
-#include "config.h"
-
 #include <glib.h>
 
 #include "qof.h"

src/app-utils/gnc-ui-common.h

@@ -25,10 +25,6 @@
 #ifndef GNC_UI_COMMON_H
 #define GNC_UI_COMMON_H
 
-#ifdef HAVE_CONFIG_H
-#include "config.h"
-#endif
-
 #if defined(GNOME)
   #include <gtk/gtk.h>
 #elif defined(MOTIF)

src/app-utils/gnc-ui-util.h

@@ -32,8 +32,6 @@
 #ifndef GNC_UI_UTIL_H
 #define GNC_UI_UTIL_H
 
-#include "config.h"
-
 #include <glib.h>
 #include <locale.h>
 

src/app-utils/gw-app-utils-spec.scm

@@ -26,6 +26,7 @@
    ws
    (lambda (wrapset client-wrapset) 
      (list 
+      "#include <config.h>\n"
       "#include <option-util.h>\n"
       "#include <gnc-euro.h>\n"
       "#include <gnc-exp-parser.h>\n"

src/backend/file/gnc-xml-helper.h

@@ -25,8 +25,6 @@
 #ifndef GNC_XML_HELPER_H
 #define GNC_XML_HELPER_H
 
-#include "config.h"
-
 #include <libxml/xmlversion.h>
 
 #  include <libxml/SAX.h>

src/backend/file/gnc-xml.h

@@ -25,8 +25,6 @@
 #ifndef GNC_XML_H
 #define GNC_XML_H
 
-#include "config.h"
-
 #include "FreqSpec.h"
 #include "SchedXaction.h"
 #include "gnc-engine.h"

src/backend/file/sixtp-dom-generators.h

@@ -24,8 +24,6 @@
 #ifndef SIXTP_DOM_GENERATORS_H
 #define SIXTP_DOM_GENERATORS_H
 
-#include "config.h"
-
 #include <glib.h>
 
 #include "gnc-xml-helper.h"

src/backend/file/sixtp-dom-parsers.h

@@ -24,8 +24,6 @@
 #ifndef SIXTP_DOM_PARSERS_H
 #define SIXTP_DOM_PARSERS_H
 
-#include "config.h"
-
 #include <glib.h>
 
 #include "gnc-xml-helper.h"

src/backend/file/test/test-file-stuff.h

@@ -5,8 +5,6 @@
 #ifndef TEST_FILE_STUFF_H
 #define TEST_FILE_STUFF_H
 
-#include "config.h"
-
 #include <glib.h>
 
 #include "gnc-commodity.h"

src/backend/postgres/checkpoint.c

@@ -33,6 +33,8 @@
  * 
  */
 
+#include "config.h"
+
 #define _GNU_SOURCE
 #include <glib.h>
 #include <stdio.h>

src/business/business-gnome/gw-business-gnome-spec.scm

@@ -32,6 +32,7 @@
    ws
    (lambda (wrapset client-wrapset)
      (list
+      "#include <config.h>\n"
       "#include <gtk/gtk.h>\n"
       "#include <business-urls.h>\n"
       "#include <dialog-billterms.h>\n"

src/business/dialog-tax-table/gw-dialog-tax-table-spec.scm

@@ -32,6 +32,7 @@
    ws
    (lambda (wrapset client-wrapset)
      (list
+      "#include <config.h>\n"
       "#include <dialog-tax-table.h>\n"
       )))
 

src/engine/AccountP.h

@@ -39,7 +39,6 @@
 #ifndef XACC_ACCOUNT_P_H
 #define XACC_ACCOUNT_P_H
 
-#include "config.h"
 #include "Account.h"
 #include "gnc-commodity.h"
 #include "gnc-engine.h"

src/engine/FreqSpec.h

@@ -59,7 +59,6 @@
 #ifndef XACC_FREQSPEC_H
 #define XACC_FREQSPEC_H
 
-#include "config.h"
 #include "gnc-engine.h"
 #include <glib.h>
 #include "qof.h"

src/engine/GroupP.h

@@ -36,7 +36,6 @@
 #ifndef XACC_GROUP_P_H
 #define XACC_GROUP_P_H
 
-#include "config.h"
 #include "Group.h"
 #include "Transaction.h"
 

src/engine/SX-book.h

@@ -38,8 +38,6 @@
 #ifndef GNC_SX_BOOK_H
 #define GNC_SX_BOOK_H
 
-#include "config.h"
-
 #include <glib.h>
 #include "qof.h"
 

src/engine/SX-ttinfo.h

@@ -25,8 +25,6 @@
 #ifndef GNC_SX_TTINFO_H
 #define GNC_SX_TTINFO_H
 
-#include "config.h"
-
 #include <glib.h>
 #include "qof.h"
 #include "SchedXaction.h"

src/engine/ScrubP.h

@@ -28,8 +28,6 @@
 #ifndef XACC_SCRUB_P_H
 #define XACC_SCRUB_P_H
 
-#include "config.h"
-
 #include "Account.h"
 #include "gnc-commodity.h"
 #include "gnc-engine.h"

src/engine/SplitP.h

@@ -45,8 +45,6 @@
 #ifndef XACC_SPLIT_P_H
 #define XACC_SPLIT_P_H
 
-#include "config.h"
-
 #include <time.h>
 #include <glib.h>
 

src/engine/TransLog.h

@@ -43,8 +43,6 @@
 #ifndef XACC_TRANS_LOG_H
 #define XACC_TRANS_LOG_H
 
-#include "config.h"
-
 #include "Account.h"
 #include "Transaction.h"
 

src/engine/TransactionP.h

@@ -45,8 +45,6 @@
 #ifndef XACC_TRANSACTION_P_H
 #define XACC_TRANSACTION_P_H
 
-#include "config.h"
-
 #include <time.h>
 #include <glib.h>
 

src/engine/test-core/test-engine-stuff.h

@@ -5,8 +5,6 @@
 #ifndef TEST_ENGINE_STUFF_H
 #define TEST_ENGINE_STUFF_H
 
-#include "config.h"
-
 #include <glib.h>
 #include <stdlib.h>
 

src/gnome-utils/QuickFill.h

@@ -50,8 +50,6 @@
 #ifndef QUICKFILL_H
 #define QUICKFILL_H
 
-#include "config.h"
-
 #include <gdk/gdk.h>
 #include <glib.h>
 

src/gnome-utils/dialog-account.h

@@ -24,8 +24,6 @@
 #ifndef DIALOG_ACCOUNT_H
 #define DIALOG_ACCOUNT_H
 
-#include "config.h"
-
 #include "Account.h"
 #include "Group.h"
 

src/gnome-utils/gw-gnome-utils-spec.scm

@@ -29,6 +29,7 @@
    ws
    (lambda (wrapset client-wrapset) 
      (list
+      "#include <config.h>\n"
       "#include <dialog-options.h>\n"
       "#include <dialog-utils.h>\n"
       "#include <druid-utils.h>\n"

src/gnome/dialog-chart-export.c

@@ -24,6 +24,8 @@
  *  02110-1301, USA.
  */
  
+#include "config.h"
+
 #include <gtk/gtk.h>
 #include <glib/gi18n.h>
 #include <time.h>

src/gnome/dialog-fincalc.h

@@ -23,8 +23,6 @@
 #ifndef DIALOG_FINCALC_H
 #define DIALOG_FINCALC_H
 
-#include "config.h"
-
 typedef struct _FinCalcDialog FinCalcDialog;
 
 void gnc_ui_fincalc_dialog_create(void);

src/gnome/dialog-print-check.h

@@ -24,8 +24,6 @@
 #ifndef DIALOG_PRINT_CHECK_H
 #define DIALOG_PRINT_CHECK_H
 
-#include "config.h"
-
 #include <libguile.h>
 
 #include "print-session.h"

src/gnome/gw-gnc-spec.scm

@@ -26,6 +26,7 @@
    ws
    (lambda (wrapset client-wrapset)
      (list
+      "#include <config.h>\n"
       "#include <glib.h>\n"
       "#include <gnc-ui.h>\n"
       "#include <gnc-ui-util.h>\n"

src/register/register-core/gtable.h

@@ -23,8 +23,6 @@
 #ifndef G_TABLE_H
 #define G_TABLE_H
 
-#include "config.h"
-
 #include <glib.h>
 
 

src/register/register-core/gw-register-core-spec.scm

@@ -18,9 +18,9 @@
   (gw:wrapset-add-cs-declarations!
    ws
    (lambda (wrapset client-wrapset) 
-     (if (eq? wrapset client-wrapset)
-         '()
-         "#include <basiccell.h>\n")))
+     (list
+      "#include <config.h>\n"
+      "#include <basiccell.h>\n" )))
   
   (gw:wrap-as-wct ws '<gnc:basic-cell> "BasicCell*" "const BasicCell*")
 

src/register/register-gnome/gncmod-register-gnome.c

@@ -5,6 +5,8 @@
  * Copyright (c) 2001 Linux Developers Group, Inc. 
  *********************************************************************/
 
+#include "config.h"
+
 #include <glib.h>
 
 #include "combocell.h"

src/report/report-gnome/gw-report-gnome-spec.scm

@@ -27,6 +27,7 @@
    ws
    (lambda (wrapset client-wrapset)
      (list
+      "#include <config.h>\n"
       "#include <gtk/gtk.h>\n"
       "#include <dialog-column-view.h>\n"
       "#include <gnc-plugin-page-report.h>\n"

src/test-core/test-stuff.h

@@ -34,8 +34,6 @@ Otherwise, only failures are printed out.
 #ifndef TEST_STUFF_H
 #define TEST_STUFF_H
 
-#include "config.h"
-
 #include <glib.h>
 #include <stdlib.h>