IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-20 11:48:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix a missed g_value_dup_string and some no longer used variables.

Browse Source
This commit is contained in:
John Ralls 2023-02-27 16:09:27 -08:00
parent 8a7c539258
commit 7f0353adc4
2 changed files with 1 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
libgnucash/engine/Transaction.c
View File

@ -2385,7 +2385,6 @@ xaccTransGetDocLink (const Transaction *trans)
g_return_val_if_fail (trans, NULL);
GValue v = G_VALUE_INIT;
Transaction *t = (Transaction*) trans;
qof_instance_get_kvp (QOF_INSTANCE (trans), &v, 1, doclink_uri_str);
const char* doclink = G_VALUE_HOLDS_STRING (&v) ? g_value_get_string (&v) : NULL;
g_value_unset (&v);
@ -2399,9 +2398,8 @@ xaccTransGetNotes (const Transaction *trans)
g_return_val_if_fail (trans, NULL);
GValue v = G_VALUE_INIT;
Transaction *t = (Transaction*) trans;
qof_instance_get_kvp (QOF_INSTANCE (trans), &v, 1, trans_notes_str);
const char *notes = G_VALUE_HOLDS_STRING (&v) ? g_value_dup_string (&v) : NULL;
const char *notes = G_VALUE_HOLDS_STRING (&v) ? g_value_get_string (&v) : NULL;
g_value_unset (&v);
return notes;
@ -2412,7 +2410,6 @@ xaccTransGetIsClosingTxn (const Transaction *trans)
{
if (!trans) return FALSE;
Transaction* trans_nonconst = (Transaction*) trans;
GValue v = G_VALUE_INIT;
gboolean rv;
qof_instance_get_kvp (QOF_INSTANCE (trans), &v, 1, trans_is_closing_str);

15
libgnucash/engine/kvp-frame.cpp
View File

@ -238,17 +238,6 @@ int compare(const KvpFrameImpl & one, const KvpFrameImpl & two) noexcept
return 0;
}
static void
gvalue_list_from_kvp_value (KvpValue *kval, gpointer pList)
{
GList **gvlist = NULL;
GValue *gval = gvalue_from_kvp_value (kval);
gvlist = (GList**)pList;
if (G_VALUE_TYPE (gval))
*gvlist = g_list_prepend (*gvlist, gval);
}
static void
kvp_value_list_from_gvalue (GValue *gval, gpointer pList)
{
@ -263,10 +252,6 @@ kvp_value_list_from_gvalue (GValue *gval, gpointer pList)
GValue*
gvalue_from_kvp_value (const KvpValue *kval, GValue* val)
{
gnc_numeric num;
Time64 tm;
GDate gdate;
if (kval == NULL) return NULL;
if (!val)
val = g_slice_new0 (GValue);