IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary g_strdup_printf.

Browse Source 
SQL_OPTION_TO_REMOVE is substituted during preprocessing so it can be
inlined in the string initialization, no need for heap allocation or
runtime composition.
This commit is contained in:
John Ralls
2016-05-19 14:08:55 -07:00
parent ef8f63759f
commit 818fe73a05
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/backend/dbi/gnc-backend-dbi.c
View File

@@ -802,11 +802,11 @@ adjust_sql_options_string (const gchar *str)
gchar* regex_str = NULL;
gchar* answer = NULL;
regex_str = g_strdup_printf( "(?:,%s$|\\b%s\\b,?)",
SQL_OPTION_TO_REMOVE, SQL_OPTION_TO_REMOVE );
/* Build a regex string that will find the pattern at the beginning, end or
* within the string as a whole word, comma separated.
*/
regex_str = "(?:," SQL_OPTION_TO_REMOVE "$|\\b"
SQL_OPTION_TO_REMOVE "\\b,?)";
// compile the regular expression and check for errors
regex = g_regex_new (regex_str, 0, 0, &err);
@@ -822,7 +822,6 @@ adjust_sql_options_string (const gchar *str)
{
answer = g_strdup (str);
}
g_free( regex_str );
g_regex_unref (regex);
return answer;
}