IntenseFinance/gnucash
3
0 Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2026-10-24 15:17:39 -05:00
Code Issues Packages Projects Releases Wiki Activity

[sixtp-dom-generators.cpp] don't heap allocate 0.5KiB for date

Browse Source 
32 bytes on stack is more than adequate for YYYY-MM-DD
and it's ASCII, no need to utf8 sanitize
This commit is contained in:
Christopher Lam committed 2026-10-18 20:07:55 +08:00
1 parent 53d34ccdb3
commit 874207e1cc
1 file changed
+4 -6
Download Patch File Download Diff File Expand all files Collapse all files
libgnucash/backend/xml/sixtp-dom-generators.cpp
+4 -6
View File
@@ -149,18 +149,16 @@ xmlNodePtr
gdate_to_dom_tree (const char* tag, const GDate* date)
{
xmlNodePtr ret;
gchar* date_str = NULL;
gchar date_str[32];
g_return_val_if_fail (date, NULL);
date_str = g_new (gchar, 512);
g_date_strftime (date_str, 512, "%Y-%m-%d", date);
if (!g_date_strftime (date_str, sizeof (date_str), "%Y-%m-%d", date))
date_str[0] = '\0';
ret = xmlNewNode (NULL, BAD_CAST tag);
xmlNewTextChild (ret, NULL, BAD_CAST "gdate", checked_char_cast (date_str));
g_free (date_str);
xmlNewTextChild (ret, NULL, BAD_CAST "gdate", BAD_CAST date_str);
return ret;
}