IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-16 18:25:11 -06:00
Code Issues Packages Projects Releases Wiki Activity

Bug 795944 - Cannot store change to Business Suppliers data

Browse Source 
The underlying problem was that the vendor object remained in infant state
That confused the backend code so it used an sql INSERT statement instead
of an UPDATE statement to write back the changes. As the object already
existed in the db this would fail.
The fix is to ensure the object doesn't remain in infant state during
sql loading. See the bug report for a more detailed explanation.
This commit is contained in:
Geert Janssens 2018-06-23 13:15:38 +02:00
parent 92ea3ba8a6
commit a438a59513
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
libgnucash/backend/sql/gnc-sql-column-table-entry.hpp
View File

@ -544,9 +544,19 @@ void set_parameter(T object, P item, QofSetterFunc setter)
template <typename T, typename P>
void set_parameter(T object, P item, const char* property)
{
qof_instance_increase_editlevel(object);
// Properly use qof_begin_edit and qof_commit_edit{_part2}
// here. This is needed to reset the infant state of objects
// when loading them initially from sql. Failing to do so
// could prevent future editing of these objects
// Example of this is https://bugzilla.gnome.org/show_bug.cgi?id=795944
qof_begin_edit(QOF_INSTANCE(object));
g_object_set(object, property, item, nullptr);
qof_instance_decrease_editlevel(object);
if (!qof_commit_edit(QOF_INSTANCE(object))) return;
// FIXME I can't use object specific callbacks in generic code
// so for now these will silently fail. As the GObject based method
// of setting qof objects should go away eventually I won't bother
// finding a proper solution for this.
qof_commit_edit_part2(QOF_INSTANCE(object), nullptr, nullptr, nullptr);
};
/**