IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Revert "[assistant-stock-transaction] refresh_handler: avoid leaking GList*"

Browse Source 
macOS clang optimizes away the return value so g_hash_table_find always
returns the item pointer, causing premature destruction when a
GncAccountSel-created account edit dialog completes, leading to a
use-after-free crash.
This commit is contained in:
John Ralls 2023-09-18 14:14:03 -07:00
parent ee84938276
commit a8c3b4b078
1 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
gnucash/gnome/assistant-stock-transaction.cpp
View File

@ -2655,12 +2655,6 @@ stock_assistant_cancel_cb (GtkAssistant *assistant, gpointer user_data)
}
static bool
is_destroying (gpointer key, EventInfo* change, gpointer user_data)
{
return (change->event_mask & QOF_EVENT_DESTROY);
};
static void
refresh_handler (GHashTable *changes, gpointer user_data)
{
@ -2671,12 +2665,18 @@ refresh_handler (GHashTable *changes, gpointer user_data)
* should be only one entry, so just get the value and see if it
* matches QOF_EVENT_DESTROY.
*/
if (g_hash_table_find (changes, (GHRFunc)is_destroying, nullptr))
auto list = g_hash_table_get_values(changes);
for (auto node = list; node; node = g_list_next(node))
{
PWARN ("Stock account destroyed, cancelling assistant.");
auto controller = static_cast<StockAssistantController*>(user_data);
gnc_close_gui_component_by_data(ASSISTANT_STOCK_TRANSACTION_CM_CLASS, controller);
auto change{static_cast<EventInfo*>(node->data)};
if (change->event_mask & QOF_EVENT_DESTROY)
{
PWARN ("Stock account destroyed, cancelling assistant.");
auto controller = static_cast<StockAssistantController*>(user_data);
gnc_close_gui_component_by_data(ASSISTANT_STOCK_TRANSACTION_CM_CLASS, controller);
}
}
g_list_free (list);
}
static void