IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Ability to clear out variable bindings in the SLR dialog; better logging.

Browse Source 
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@15546 57a11ea4-9604-0410-9ed3-97b8803252fd
This commit is contained in:
Joshua Sled
2007-02-10 02:30:43 +00:00
parent 8ebec0de11
commit c042a51768
2 changed files with 19 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/doc/sx.rst
View File

@@ -65,25 +65,25 @@ TODO
- bugs
- [ ] with SLR open (with instances), add variables to SX; only newly-created instances will have appropriate variable tables.
- [ ] sx-from-trans: "unknown get.type [3]" [dh20070120]_
- [ ] auto-create (+notify) txns not in review list. [ve20070209]_
! - [x] crash with two sx lists open and SX mutation
- I'm pretty sure this is due to SX lists not getting cleaned up on page close, somehow.
- [ ] sx-from-trans: "unknown get.type [3]" [dh20070120]_
- [ ] no way to clear a variable entry [ve20070209]_
- [ ] auto-create (+notify) txns not in review list. [ve20070209]_
- [x] no way to clear a variable entry [ve20070209]_
.. _[dh20070120]: http://lists.gnucash.org/pipermail/gnucash-devel/2007-January/019667.html
.. _[ve20070209]: http://lists.gnucash.org/pipermail/gnucash-devel/2007-February/019834.html
- sx list page
! - [ ] use gnc-tree-view?
! - [x] save/restore state
! - [ ] save/restore size
- [/] make into split panel
- [ ] fix slider position
- [ ] {0, 1, 2, 4, 8, 12} month selection for dense calendar
! - [x] save/restore state
- sx editor
- [ ] clean up source formatting

15
src/gnome/dialog-sx-since-last-run.c
View File

@@ -903,8 +903,19 @@ variable_value_changed_cb(GtkCellRendererText *cell,
if (!xaccParseAmount(value, TRUE, &parsed_num, &endStr)
|| gnc_numeric_check(parsed_num) != GNC_ERROR_OK)
{
g_critical("@@fixme: better parse error handling");
// @fixme: set location (back) to "(need value)"
gchar *value_copy = g_strdup(value);
g_debug("value=[%s] endStr[%s]", value, endStr);
if (strlen(g_strstrip(value_copy)) == 0)
{
gnc_numeric invalid_num = gnc_numeric_error(GNC_ERROR_ARG);
// @fixme? Change to gnc_sx_slr_model_clear_variable(...)?
gnc_sx_slr_model_change_variable(dialog->editing_model, inst, var, &invalid_num);
}
else
{
g_warning("error parsing value [%s]", value);
}
g_free(value_copy);
return;
}
gnc_sx_slr_model_change_variable(dialog->editing_model, inst, var, &parsed_num);