IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

When creating lists of database objects, use g_list_prepend() rather than g_list_append(). There may be cases where the list order is significant and thus needs to be reversed, but that is not true in these cases. This provides a large improvement in database loading performance.

Browse Source 
Analysis and basis patch supplied by Donald Allen.


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@18724 57a11ea4-9604-0410-9ed3-97b8803252fd
This commit is contained in:
Phil Longstaff
2010-02-24 20:11:22 +00:00
parent 61937bc3dd
commit cd0b4fe145
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend/sql/gnc-budget-sql.c
View File

@@ -331,7 +331,7 @@ load_all_budgets( GncSqlBackend* be )
while( row != NULL ) {
b = load_single_budget( be, row );
if( b != NULL ) {
list = g_list_append( list, b );
list = g_list_prepend( list, b );
}
row = gnc_sql_result_get_next_row( result );
}

2
src/backend/sql/gnc-schedxaction-sql.c
View File

@@ -245,7 +245,7 @@ load_all_sxes( GncSqlBackend* be )
sx = load_single_sx( be, row );
if( sx != NULL ) {
gnc_sxes_add_sx( sxes, sx );
list = g_list_append( list, sx );
list = g_list_prepend( list, sx );
}
row = gnc_sql_result_get_next_row( result );
}

4
src/backend/sql/gnc-transaction-sql.c
View File

@@ -235,7 +235,7 @@ load_splits_for_tx_list( GncSqlBackend* be, GList* list )
Split* s;
s = load_single_split( be, row );
if( s != NULL ) {
split_list = g_list_append( split_list, s );
split_list = g_list_prepend( split_list, s );
}
row = gnc_sql_result_get_next_row( result );
}
@@ -382,7 +382,7 @@ query_transactions( GncSqlBackend* be, GncSqlStatement* stmt )
while( row != NULL ) {
tx = load_single_tx( be, row );
if( tx != NULL ) {
tx_list = g_list_append( tx_list, tx );
tx_list = g_list_prepend( tx_list, tx );
}
row = gnc_sql_result_get_next_row( result );
}