Various bug fixes.

git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/branches/gnucash-gnome2-dev@9929 57a11ea4-9604-0410-9ed3-97b8803252fd

AUTHORS

@@ -171,6 +171,7 @@ G. Allen Morris III <gam3@ann.softgams.com> for QIF core dump
 Steven Murdoch <sjmurdoch@bigfoot.com> gnc-prices fix for London exchange
 Jose Carlos Nascimento <joseca@psabs.com> Brazilian Portuguese translation
 Brent Neal <brent@baton.phys.lsu.edu> TIAA-CREF support.
+Christian Neumair <chris@gnome-de.org> Various gnome2 fixes/HIG work.
 Johnny Ernst Nielsen <j.e.nielsen@iname.com> messages Danish translation
 Stefan Nobis <stefan-ml@snobis.de> German translation patch
 Martin Norb<72>ck <d95mback@dtek.chalmers.se> Swedish translation

GNOME2_STATUS

@@ -73,17 +73,13 @@ Register Core - MINIMALLY FUNCTIONAL
 
 	- Insertion point not shown. (fix gnucash-item-edit.c)
 	- Cannot hilight text with mouse (fix gnucash-item-edit.c)
-	- Popup buttons don't appear. (gnucash-item-edit.c ?)
 
 	- The first time it is used, the account popup immediately
 	  selects the first account. After that it functions normally.
 
 
-Find - MINIMALLY FUNCTIONAL
+Find - Somewhat Functional
 	- Can generate a query in the dialog.
-	- Use of the "Date" selection sometimes crashes gnucash (not
-	  when you select it, but then you change from "Date" to
-	  something else.
 
 View Summarybar - Summarybar not ported yet. Where should it go?
 	Wouldn't look good between the toolbar and the notebook tabs.

src/gnome-search/search-date.c

@@ -111,6 +111,9 @@ gnc_search_date_finalize (GObject *obj)
   GNCSearchDate *o = (GNCSearchDate *)obj;
   g_assert (IS_GNCSEARCH_DATE (o));
 
+  if (o->priv->entry)
+    gtk_widget_destroy (o->priv->entry);
+
   g_free(o->priv);
 	
   G_OBJECT_CLASS (parent_class)->finalize(obj);
@@ -261,6 +264,7 @@ gncs_get_widget (GNCSearchCoreType *fe)
   entry = gnc_date_edit_new_ts (fi->ts, FALSE, FALSE);
   g_signal_connect (G_OBJECT (entry), "date_changed", G_CALLBACK (date_changed), fe);
   gtk_box_pack_start (GTK_BOX (box), entry, FALSE, FALSE, 3);
+  g_object_ref (entry);
   fi->priv->entry = entry;
 
   /* And return the box */

src/gnome-utils/gnc-tree-model-account.c

@@ -400,7 +400,6 @@ gnc_tree_model_account_get_iter (GtkTreeModel *tree_model,
 	Account *account = NULL;
 	AccountGroup *group = NULL, *children;
 	gint i = 0, *indices;
-	GtkTreePath *path_copy;
 
 	{
 	  gchar *path_string = gtk_tree_path_to_string(path);
@@ -411,8 +410,6 @@ gnc_tree_model_account_get_iter (GtkTreeModel *tree_model,
 
 	model = GNC_TREE_MODEL_ACCOUNT (tree_model);
 
-	path_copy = gtk_tree_path_copy (path);
-
 	if (model->priv->toplevel != NULL) {
 		if (gtk_tree_path_get_depth (path) > 1) {
 			i++;
@@ -661,6 +658,7 @@ gnc_tree_model_account_get_value (GtkTreeModel *tree_model,
 			string = gnc_ui_account_get_print_balance(xaccAccountGetReconciledBalanceInCurrency,
 								  account, FALSE, &negative);
 			g_value_set_static_string (value, negative ? "red" : "black");
+			g_free (string);
 			break;
 
 		case GNC_TREE_MODEL_ACCOUNT_COL_FUTURE_MIN:
@@ -680,6 +678,7 @@ gnc_tree_model_account_get_value (GtkTreeModel *tree_model,
 			string = gnc_ui_account_get_print_balance(xaccAccountGetProjectedMinimumBalanceInCurrency,
 								  account, FALSE, &negative);
 			g_value_set_static_string (value, negative ? "red" : "black");
+			g_free (string);
 			break;
 
 		case GNC_TREE_MODEL_ACCOUNT_COL_TOTAL:
@@ -699,6 +698,7 @@ gnc_tree_model_account_get_value (GtkTreeModel *tree_model,
 			string = gnc_ui_account_get_print_balance(xaccAccountGetBalanceInCurrency,
 								  account, TRUE, &negative);
 			g_value_set_static_string (value, negative ? "red" : "black");
+			g_free (string);
 			break;
 
 		case GNC_TREE_MODEL_ACCOUNT_COL_NOTES:

src/register/register-gnome/gnucash-sheet.c

@@ -1284,6 +1284,8 @@ gnucash_button_press_event (GtkWidget *widget, GdkEventButton *event)
                         return TRUE;
                 case 3:
                         do_popup = (sheet->popup != NULL);
+			if (!do_popup)
+				return FALSE;
                         break;
                 case 4:
                 case 5: