IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Bug 798162 - Type Ahead Initialization Problem

Browse Source 
If navigating by the keyboard and you tab to the transfer cell and then
type a letter, we get to gnc_item_edit_show_popup which starts to
create and hopefully show the pop up list.

But on first use, cell height obtained by gnc_item_list_get_cell_height
can be 1 pixel less than required. This should be corrected by the
check_popup_height_is_true function which calls gnc_item_edit_update
via an idle function. As part of that function, a check is made for
item_edit->show_popup being set but that was only getting set in the
gnc_item_edit_popup_toggled call back so the pop up would not show.

To fix set item_edit->show_popup after setting the toggle button arrow
direction.
This commit is contained in:
Robert Fewell 2021-06-19 12:43:18 +01:00
parent a13311bea7
commit ea2a54bf9e
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
gnucash/register/register-gnome/gnucash-item-edit.c
View File

@ -1082,6 +1082,7 @@ gnc_item_edit_show_popup (GncItemEdit *item_edit)
// set the popup arrow direction up // set the popup arrow direction up
item_edit->popup_toggle.arrow_down = FALSE; item_edit->popup_toggle.arrow_down = FALSE;
item_edit->show_popup = TRUE;
if (item_edit->popup_set_focus) if (item_edit->popup_set_focus)
item_edit->popup_set_focus (item_edit->popup_item, item_edit->popup_set_focus (item_edit->popup_item,