IntenseFinance/gnucash
3
0
Fork 0
mirror of https://github.com/Gnucash/gnucash.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

fix yet another intermediate-math overflow bug.

Browse Source 
comparing two numbers gave incorrect results because
intermediate calculation overflowed


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@10153 57a11ea4-9604-0410-9ed3-97b8803252fd
This commit is contained in:
Linas Vepstas
2004-07-04 03:56:40 +00:00
parent 5ff6c419d6
commit f76b3ad534
1 changed files with 24 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
src/engine/gnc-numeric.c
View File

@@ -216,24 +216,36 @@ gnc_numeric_positive_p(gnc_numeric a)
********************************************************************/
int
gnc_numeric_compare(gnc_numeric a, gnc_numeric b) {
gint64 ab, ba;
gnc_numeric_compare(gnc_numeric a, gnc_numeric b)
{
gint64 aa, bb;
if(gnc_numeric_check(a) || gnc_numeric_check(b)) {
if(gnc_numeric_check(a) || gnc_numeric_check(b))
{
return 0;
}
ab = a.num * b.denom;
ba = b.num * a.denom;
if(ab == ba) {
return 0;
}
else if(ab > ba) {
return 1;
}
else {
if (a.denom == b.denom)
{
if(a.num == b.num) return 0;
if(a.num > b.num) return 1;
return -1;
}
if ((a.denom > 0) && (b.denom > 0))
{
/* Avoid overflows using 128-bit intermediate math */
qofint128 l = mult128 (a.num, b.denom);
qofint128 r = mult128 (b.num, a.denom);
return cmp128 (l,r);
}
aa = a.num * a.denom;
bb = b.num * b.denom;
if(aa == bb) return 0;
if(aa > bb) return 1;
return -1;
}