Commit Graph
100 Commits
Author SHA1 Message Date
Charles Day 11dbaf1c87 Bug 575778: QIF Import: Fix crash when a security list omits the "T" (type) line.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@18279 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-08-25 21:01:46 +00:00
Charles Day dc998a7408 GNCDateEdit: Fix r18237 by including localtime_r.h if necessary.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@18238 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-08-05 20:52:46 +00:00
Charles Day fbb485c7ee Use localtime_r() instead of localtime() in GNCDateEdit. From audit of r17459.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@18237 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-08-03 22:21:15 +00:00
Charles Day 5318f379fd Patch by John Ralls. Integrates the gnucash menus into the MacOSX menubar.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@18208 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-07-13 20:40:45 +00:00
Charles Day afe64deb46 Patch by John Ralls. Permits binreloc to work from inside a MacOSX application bundle.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@18207 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-07-13 20:39:44 +00:00
Charles Day cd3df9ae82 Patch by John Ralls. Provides (and installs when appropriate) a special gnucash-setup-env for OSX.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@18206 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-07-13 20:38:44 +00:00
Charles Day f729c3ec94 Patch by John Ralls. Adjust configure.in for Mac compilation with Quartz.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@18205 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-07-13 20:34:42 +00:00
Charles Day ac30591d8b Bug #587913: Register: Don't mark the account cell as changed if the name hasn't changed.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@18188 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-07-07 21:15:01 +00:00
Charles Day 6c1a471a72 Register: Clarify a debugging message.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@18187 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-07-07 20:09:14 +00:00
Charles Day 677aa0cc6f Bug #567709: Register: Don't assume that cells outside the cursor are valid.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@18177 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-07-05 22:16:03 +00:00
Charles Day c18ab75030 Bug 563598: QSF XML Export: Remove the tooltip from the GtkCalendar. It was causing a crash, probably due to bug 586896.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@18176 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-07-04 22:57:50 +00:00
Charles Day b34e82722b Bug #580968: Register: Keep track of the account when an exchange rate is set, and don't reset the rate unless the commodity changes. Previously the rate would be reset whenever focus left the account cell, even if the commodity hadn't changed.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@18166 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-07-01 23:05:24 +00:00
Charles Day f163d536a6 QIF Import: Documentation .txt file patch by Daniel Convissor. I've added some unrelated whitespace fixes.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@18115 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-06-08 19:37:37 +00:00
Charles Day d354ebc2aa Register: Add some header comments for a confusing function.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@18099 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-06-02 00:50:54 +00:00
Charles Day 1eadc9c581 QIF Import: Create transactions in the user-specified currency rather than the default currency. For example, if the default currency is pesos and the user has specified that the QIF transactions are all USD, the transaction currency should be USD too.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@18067 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-05-06 20:34:33 +00:00
Charles Day 914fd9730c Bug #478106: Add sanity check to currency exchange dialog.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@18065 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-05-01 23:04:27 +00:00
Charles Day f07425f1b0 QIF Import: Add support for German "Oth S" accounts.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@18055 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-04-23 21:51:02 +00:00
Charles Day 9f7c476d58 Reverse an unintended change from r18034.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@18035 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-04-10 15:30:27 +00:00
Charles Day c6ceaa75b7 Register: Add an ENTER/LEAVE pair.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@18034 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-04-10 15:28:47 +00:00
Charles Day b5911ecf2e Bug #478055: Adjust read syntax of symbol names that include spaces. This old syntax doesn't work in guile 1.8, at least not on Fedora 9 64-bit.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@18031 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-04-07 20:20:23 +00:00
Charles Day 3b096be543 Register: Force scroll to the current row if the row height may have changed and pushed the current row out of sight.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@18024 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-04-06 17:00:03 +00:00
Charles Day 8493afcc37 Bug #432021: Register: Recompute block offsets if the cell heights may have changed.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@18023 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-04-06 16:27:21 +00:00
Charles Day 673bdf5496 Register: Add some gnome-related debugging messages.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@18022 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-04-06 16:21:02 +00:00
Charles Day fd4f497103 Register: Add some new debugging messages to the ledger display functions.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@18021 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-04-06 16:13:21 +00:00
Charles Day 908813cf34 QIF Import: Throw an error immediately upon failing to parse a category. Previously a bad value was returned, which could then cause a failure in the caller.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@18000 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-03-25 00:52:32 +00:00
Charles Day 77c174f5c0 QIF: Replicate the fix from r17998 in two other QIF-related places.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17999 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-03-22 17:48:34 +00:00
Charles Day dfa30891c7 QIF Import: Support backslash characters in category names. There was a mistake the regular expression, as a pipe symbol shouldn't be escaped with a backslash when used inside brackets.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17998 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-03-22 17:24:58 +00:00
Charles Day c3b86442c0 Reports: Speed up the report infrastructure. Patch by Mike Alexander.
One set of changes speeds up the three functions in report-utilities.scm:
gnc:account-get-comm-balance-interval
gnc:accountlist-get-comm-balance-interval
gnc:accountlist-get-comm-balance-at-date

These can all be implemented as calls to
gnc:account-get-trans-type-balance-interval (with a minor change to it to
ignore the type parameter if it is #f) and it is much faster since it does a
single query instead of a loop over an account list.

The other set of changes is in gnc:html-acct-table-add-accounts! in
html-acct-table.scm.  This functions starts off by building a hash table of
account balances it cares about.  The code to do this did a recursive loop over
the relevant accounts.  I changed it to do a query to find the splits in the
accounts it cares about and build the hash table from them.  This speeds it up
by a couple of orders of magnitude.


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17988 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-03-09 20:14:46 +00:00
Charles Day 2d2e2d5b0e Register: Fix the file name in a comment.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17987 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-03-09 20:07:51 +00:00
Charles Day 08a8d60401 Register: Add a few debugging calls.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17986 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-03-09 20:07:09 +00:00
Charles Day e3477bc041 Register core: Start doxygen documentation of table-allgui.h
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17985 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-03-09 19:47:58 +00:00
Charles Day 4165e0ed62 Bug #523982: Fix the Enter key in double-line mode. The register had wrongly assumed one physical row per virtual row.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17984 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-03-09 18:23:25 +00:00
Charles Day 0621803bd6 QIF Import: Correct case of cleared status code "c" in documentation text file.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17982 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-03-08 19:14:41 +00:00
Charles Day 1c8761d6d1 QIF Import: Allow "R" or "r" for reconciled, and "C" or "c" for cleared.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17981 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-03-08 18:58:17 +00:00
Charles Day 573d809b4a QIF Import: Add a section for "cleared status" and fix some inconsistent whitespace.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17980 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-03-07 19:48:06 +00:00
Charles Day 5456ef6eba Business ledger: Don't leave the account cell if the user chooses not to create a new account when prompted. This allows any typo to be quickly fixed. Previously the account cell text was blanked and focus moved to the next cell.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17971 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-03-04 15:31:22 +00:00
Charles Day 69379901ca Register: Fix an unbalanced ENTER().
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17970 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-03-03 22:48:18 +00:00
Charles Day 7014c66c6f Bug #343217: Register: Don't leave the account cell if the user chooses not to create a new account when prompted. This allows any typo to be quickly fixed. Previously the account cell text was blanked and focus moved to the next cell.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17969 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-03-03 19:02:09 +00:00
Charles Day 48c7f72430 Bug #499215, #530819, #551643: Register: Fix transaction pasting, which was fairly broken. Pasting was being committed immediately, the transaction was not checked properly before opening, the blank split was being destroyed while the transaction was left pending, and more. These problems left the register in an inconsistent state that was being noticed in g_assert() calls in several spots. GnuCash would then crash.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17962 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-02-25 19:10:23 +00:00
Charles Day 575b8ca3d0 Register: White space fixes.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17961 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-02-25 18:20:22 +00:00
Charles Day 5b9b685d4b Register: Fix a bug that appears in basic and auto-split ledger modes when entering a new transaction. Entering multiple splits for the register's account would cause the 2nd though nth splits to be displayed above the new transaction, making them appear to be non-new.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17960 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-02-25 16:50:30 +00:00
Charles Day 199c0c309d Register: Add debugging to gnc_split_register_changed().
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17959 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-02-25 00:11:01 +00:00
Charles Day 5a7650b0cc Register: Make all account cells right-justified. Previously a mix of left- and right-justification was used.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17958 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-02-25 00:03:13 +00:00
Charles Day 18cf9f4e20 Register: Tweak some comments and slightly reorganize the register cleanup code for ease of reading.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17950 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-02-23 22:56:06 +00:00
Charles Day a98bc56de6 Bug #570887: Fix a typo in r17939.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17940 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-02-20 05:00:08 +00:00
Charles Day 0c09333ce8 Bug #570887: Change the swig type mapping for GUID* so that Scheme can tell the difference between a GUID* that is NULL, and a GUID* pointing to storage containing the "null" GUID. Previously the former case returned SCM_UNDEFINED to Scheme, which would unbind Scheme variables and make crashes. Now SCM_BOOL_F is used instead, and Scheme code can check for a NULL by comparing to #f.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17939 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-02-20 04:37:28 +00:00
Charles Day 6d1e0b75e1 Register: Add debugging code for the copy and cut operations.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17938 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-02-20 03:03:05 +00:00
Charles Day 5760020652 Bug #565421: Remove dependency on GTK+ 2.10 in date edit control.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17930 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-02-17 18:14:04 +00:00
Charles Day f4f9fed740 Doxygen: Adjust the style of a comment block for consistency and to eliminate a splint warning.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17929 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-02-17 16:49:52 +00:00
Charles Day ac066ecabb Register: Don't set info at declaration; wait until reg is checked.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17918 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-02-15 00:40:24 +00:00
Charles Day d81a92fef9 Register: Add a few safety checks to the register loading routines.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17917 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-02-15 00:38:15 +00:00
Charles Day bb05a6957c Bug #570166: Update win32 packaging to use GTK version 2.14.7
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17897 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-02-12 17:00:50 +00:00
Charles Day c2d0851b5f Engine: Update the documentation of xaccTransDestroy().
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17896 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-02-12 05:47:34 +00:00
Charles Day 94c6d61fdd Register: Fix a memory leak by adding a "commit" step (if needed) when destroying the blank transaction as the register closes.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17895 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-02-12 05:18:14 +00:00
Charles Day 98fe842ae2 Bug 426111: Register: Fix a bug that caused the blank split GUID to be nulled even if the split wasn't actually being committed. This would cause the bottom transaction of the register to be treated like an existing transaction instead of a new one. I've fixed that and reorganized the logic to combine two sections and make it harder to get them out of sync.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17894 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-02-11 23:07:51 +00:00
Charles Day 1ea8e0f8bf Register: Add one new debugging message and tweak some others.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17893 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-02-11 22:11:30 +00:00
Charles Day 4c09bec1f9 Register: Another tweak to doxygen documentation.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17892 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-02-11 22:03:39 +00:00
Charles Day 90af51c3e3 Register: Add a lot of doxygen documentation, add/revise some commenting inside functions, and massage a few debugging messages.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17854 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-01-29 11:42:39 +00:00
Charles Day 375be2acaf Register: Add doxygen documentation for some register functions. Fix and reorganize of some of the existing documentation.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17844 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-01-24 12:16:00 +00:00
Charles Day 53c47c1ad6 Register: Adjust some debugging messages to be more clear.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17843 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-01-24 12:12:41 +00:00
Charles Day a0a034f2ce Documentation: Fix a wide range of small mistakes in doxygen comments, including a few spots where .c and .h function declarations didn't agree on parameter names.
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17841 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-01-22 21:14:08 +00:00
Charles Day 47aee550b3 Register: Add additional debugging output during register cleanup. Also rename a variable for clarity and to match typical usage in the rest of the ledger code.
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17840 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-01-21 18:58:21 +00:00
Charles Day d9ef69a973 Register: Add a few more debugging lines to the gnome code.
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17838 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-01-21 10:53:22 +00:00
Charles Day 74e3640504 Register: Add additional debugging output to several ledger modules.
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17837 57a11ea4-9604-0410-9ed3-97b8803252fd
2009-01-20 23:15:30 +00:00
Charles Day b7af977eb4 Bug #393383, #426111: Stop the register from thinking that brand-new transactions are being edited in multiple registers. This appears to have been a special case that was being missed.
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17628 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-10-17 02:50:36 +00:00
Charles Day 425ec8eb68 Reporting: Fix the Average Cost price source computation for a certain case. As this is a signed computation with the sign indicating the direction of buy/sell, it is necessary to flip the sign if you ever flip the sense of buy or sell.
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17627 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-10-16 03:02:20 +00:00
Charles Day 78ab3222ba Register: Add a couple of missing calls to functions that use gnc_suspend_gui_refresh() so that they cannot exit without calling gnc_resume_gui_refresh(). Also add a gnc_suspend_gui_refresh()/gnc_resume_gui_refresh() pair around a commit that was missing it.
This partially fixes bug #393383 and bug #426111, as it resolves the problem of being unable to enter new transactions after the message box appears. (The message box should still not appear in the first place, however.)
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17623 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-10-12 16:51:54 +00:00
Charles Day 6c0dc2d7fc QIF Import: Remove the changes for bug #141003 but leave the fix to bug #141002 intact. A reworked fix for bug #141003 will be committed separately.
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17598 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-09-26 23:32:07 +00:00
Charles Day 63b33d5cec GNCDateEdit: Eliminate the need to click the button twice to pop the calendar down in some cases.
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17588 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-09-22 21:10:30 +00:00
Charles Day 461d7b3c69 Revision to simplify r17555 (no functional change).
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17576 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-09-19 20:51:53 +00:00
Charles Day d3929697c8 Bug #549738: Set the default start and end dates to "start of accounting period" and "today", respectively, on customer, vendor, and employee reports.
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17575 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-09-19 20:45:23 +00:00
Charles Day 018473e855 Price Editor: Set the correct source for new, user-entered prices. This builds on r17525 to fix this problem, which was introduced in r17444.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17556 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-09-18 22:21:54 +00:00
Charles Day 3d67fcd62f Fix printing of fractions when parentheses are shown for negative values.
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17555 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-09-18 20:49:01 +00:00
Charles Day ad6df218a0 gnc_numeric: Support reciprocals (negative denominators) in gnc_numeric_to_decimal().
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17554 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-09-18 08:33:27 +00:00
Charles Day a7e8bd5499 GNCAmountEdit: Put the text through the expression parser once instead of twice. This caused a problem in locales that print negative numbers in parentheses. For example, if you entered "-4/3", after the first parse the displayed text would change to "(1 + 1/3)", meaning negative one and one-third. Parsing that text a second time changes the text to "1 + 1/3" since, to the expression parser, parentheses indicate grouping rather than sign.
The reason the GNCAmountEdit was putting the text through the parser twice was that it was setting gae->need_to_parse FALSE, but then immediately calling gtk_entry_set_text(), which issues a "changed" signal. The callback for that signal was setting gae->need_to_parse back to TRUE. So I simply changed the order of the statements.
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17553 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-09-18 02:26:51 +00:00
Charles Day e803ad8245 Bug #141003: Revise r17489 to escape the British Pound symbol in Scheme with "\xa3" (for strings) or #\243 (for characters).
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17509 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-09-14 20:03:48 +00:00
Charles Day 8e9551af98 Bug #551038: Don't destroy the options database before destroying the options dialog that depends on it.
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17508 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-09-14 17:48:58 +00:00
Charles Day 6f4cecf48e Bug #340041, #436342: Make the register keep track of whether the exchange rate has been reset. This prevents a zero exchange rate from being ambiguous: previously the register could not tell the difference between "the user has not specified an exchange rate" and "the user has specified a rate of zero".
Much of this patch consists of new ENTER(), DEBUG() and LEAVE() calls for debugging. Nearly all of the rest is refactoring. The code that detected and acted on changes to the account cell has been placed into its own function, gnc_split_register_check_account(). The several calls needed to checking a cell for changes have been combined in gnc_split_register_check_cell().

About 15 lines represent actual changes in functionality. Specifically, the code does a better job of recognizing when an exchange rate needs to be requested from the user, and when it does not. When an account cell is changed in the register, and the new account is denominated in the same commodity as the original, the original exchange rate is used. On the other hand, if the commodity differs, the rate is reset to zero. The register remembers that the zero exchange rate is due to the reset (i.e. was not user-entered) so that the the exchange rate dialog can be presented. Finally, the cell contents are checked before doing a save; previously the checks were missed in certain cases, e.g. if the user pressed "Enter" or clicked the close button.
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17507 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-09-14 16:52:34 +00:00
Charles Day a22d84c1a2 Register: Log some debugging information just before crashing because of g_assert_not_reached(). This should hopefully provide some new information to help track down the underlying cause of bug #414407, #420409, #468106, and #551643.
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17506 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-09-14 16:05:53 +00:00
Charles Day 737473bce4 Bug #378734, #520570, #545316, #549115: Fix GNCDateEdit widget popup calendar problems.
-Fix popup button behavior (sometimes non-responsive)
-Make calendar clickable in modal dialogs
-Update design to be more like GtkComboBox, less like GtkCombo
-Adjust a few signal names, e.g. "focus-out-event" vs. "focus_out_event"
-Lose the GtkFrame shadowing; perhaps the GtkFrame is no longer needed 
-Add comments
-Add a few ENTER() and LEAVE() calls for debugging
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17493 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-09-05 05:08:33 +00:00
Charles Day da0415bfb5 Bug #141002: QIF Import: Allow minus signs at the end of numeric values, e.g. "$10.00-".
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17490 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-09-03 00:11:32 +00:00
Charles Day b55b08e4cf Bug #141003: QIF Import: Allow the British Pound symbol and the dollar symbol to be used interchangeably.
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17489 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-09-02 20:20:09 +00:00
Charles Day c2eb587552 Bug 549738: Make "today" the default date of the aging reports.
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17483 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-08-31 23:30:56 +00:00
Charles Day a1dd4517b9 Win32 build: Fix a typo to get trunk working on win32/mingw again.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17479 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-08-26 17:09:03 +00:00
Charles Day fd987c0b3d Bug #548891: QIF Import: Prevent crashing when the mapping preferences can't be saved.
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17477 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-08-21 17:47:10 +00:00
Charles Day a8820e769b AUTHORS: Add Frank Ellenberger and update my own details.
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17476 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-08-21 00:13:36 +00:00
Charles Day 390fbb00e7 Bug #543061: Fix the smallest fraction of IDR currency to match ISO 4217.
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17472 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-08-15 17:04:36 +00:00
Charles Day 9a69bfd8c2 Bug #454340: Prevent duplicate rows after editing a security. These changes are similar to what was done for the price tree model in r17441 and r17470.
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17471 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-08-14 16:41:33 +00:00
Charles Day 6209ea2f0f Update a few comments to fix typos and inaccuracies, or to add further clarification.
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17470 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-08-14 15:52:34 +00:00
Charles Day 8ed5e2853a Usability: Security Editor: Previously, nothing happened when a namespace row was activated. Now these rows will expand or collapse. It is often easier to double-click the row than hunt for the expander.
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17469 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-08-13 17:47:08 +00:00
Charles Day 9a653982fe Usability: Sort commodity trees on the commodity name by default. This allows for a consistent default sort even if commodities are quickly removed from and re-added to the model. This can happen, for example, when a commodity is edited in the Security Editor.
BP 


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17468 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-08-13 17:44:11 +00:00
Charles Day fca4b45dcc Prices: Emit a qof event when a price is changed. This allows the Price Editor to immediately update its display. Previously, price changes would only get shown when the mouse happened to pass over the affected row. Theoretically other parts of GnuCash, such as reports, could now be made to watch for price changes and automatically refresh themselves.
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17467 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-08-12 20:12:37 +00:00
Charles Day b3c41e46ce Transfer dialog: Don't round quotes pulled from the price db.
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17463 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-08-12 18:05:37 +00:00
Charles Day d89d96ce88 Bug #547335: Get the exchange rate dialog "to" amount working again when launched via the register instead of the menu.
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17462 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-08-11 21:55:50 +00:00
Charles Day c20038064f Bug #545722: Get the GNCDateEdit control working on Win32 again. Don't assume that the content returned by localtime() will not be changed out from under you.
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17459 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-08-08 23:38:45 +00:00
Charles Day 10df25faca Bug #522095: Refresh the summary bar when new prices are downloaded.
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17458 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-08-08 21:36:48 +00:00
Charles Day 5dd0c682ed Don't round values that will be displayed as expressions. Save some space in fractional displays by, for example, showing "1 + 1/8" instead of "1 + 1 / 8". Simplify fractional display of values less than 1 by, for example, showing "1/3" instead of "0 + 1 / 3".
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17457 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-08-07 19:40:15 +00:00
Charles Day eb29fc8e6d Make gnc_numeric values of zero always convertible to decimal form.
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17456 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-08-07 18:18:00 +00:00
Charles Day 96863860d0 Bug #541970: When finding a "nearest in time" price, break ties by preferring the older price. This has the benefit of using a price that actually existed at the given time, and better addresses the case in which both price times have been defaulted to midnight. Previously, the newer price was preferred.
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17454 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-08-04 16:41:15 +00:00
Charles Day 0bdc6aa496 Bug #543780: Scrub the transfer dialog calculation of the "to" amount:
-Check account value to avoid causing a CRIT message.
-Reorganize function for smaller size and more readability.
-Add some comments (there were none).
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17451 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-08-02 21:53:23 +00:00