Commit Graph

21316 Commits

Author SHA1 Message Date
Christopher Lam
2a6a4e34d6 [price-quotes] compact commodity-tz-quote-triple->price 2019-08-13 18:50:59 +08:00
Christopher Lam
e15f2610ba [price-quotes] compact gnc:book-add-quotes 2019-08-13 18:50:57 +08:00
Christopher Lam
4a4f81b320 [price-quotes] compact book->commodity->fq-call-data
make function more readable.
2019-08-13 18:50:55 +08:00
Christopher Lam
5e8663772a [price-quotes] compact gnc:fq-get-quotes 2019-08-13 18:50:53 +08:00
Christopher Lam
d5122c97ea [price-quotes] compact gnc:fq-check-sources
improve locality of vars.
2019-08-13 18:50:51 +08:00
Christopher Lam
fab1c8db3e [price-quotes] show if F::Q not installed, remove dead code 2019-08-13 18:50:48 +08:00
Christopher Lam
112cf99d2d [test-report-html] add coverage and function test
* function gnc:html-table-add-labeled-amount-line! has full coverage
test.

* function gnc:make-html-acct-table/env/accts has good coverage
confirming nothing crashes.
2019-08-13 18:50:13 +08:00
Christopher Lam
a42f1211d8 [html-acct-table] modernise to srfi-9 records 2019-08-13 18:50:13 +08:00
Christopher Lam
81b20d0a62 [html-acct-table] timepair -> time64
* fix timepair -> time64 - this is technically dead code.
2019-08-12 23:33:44 +08:00
Christopher Lam
0c3f460e9f [invoice] deprecate easy/fancy-invoice creation hooks 2019-08-11 23:32:51 +08:00
Frank H. Ellenberger
55e196ab5b Dutch RGS template: Replace a ":" in an account name
The colon is the account delimiter.
2019-08-11 10:55:24 +02:00
Geert Janssens
7d2d392829 Fix intermittent build dependency issue
eguile-html-utilities now depends on eguile-gnc so make sure
the latter is built before the former

Note the master branch has gone a different route:
eguile-html-utilities and eguile-utilities are no longer modules
there but included into eguile-gnc via load-from-path
Hence the dependecy tree is actually the other way around there.
To keep in mind when merging maint into master next time.
2019-08-10 21:49:24 +02:00
Christopher Lam
c7e60c1d53 [qif/test-qif-parse] increase coverage 2019-08-08 08:08:55 +08:00
Christian Stimming
100ef2a01d Online banking: Usage of gnucash registration key is available in more aqbanking versions.
To be precise, it is in aqbanking-5.7.8-git-1 and to-be-released
aqbanking-5.7.9 as well as aqbanking-5.99.24-git-1 and
to-be-released aqbanking-5.99.25. As it is needed mid-September 2019
for all bank users in Germany, we better make it available for both branches.
2019-08-07 22:37:31 +02:00
John Ralls
bbcfc9da42 [test-commodity-utils] Don't try to free the pricedb twice.
It's freed by gnc-clear-current-session, so freeing it explicitly
causes a double-free.
2019-08-05 10:04:52 -07:00
Christopher Lam
6252de21fd [qif/qif-parse] restore handle non-4-digit dates, and erratum
db93aec58 contained logic error in date-handling, would invalidate
2-digit years.

Also parse-bang-field needs to trim trailing space.
2019-08-05 18:16:49 +08:00
Christopher Lam
08de1a0ab0 [qif/qif-import] fix whitespace 2019-08-04 11:35:46 +08:00
Christopher Lam
409b97a988 [qif/string] compact function 2019-08-04 11:35:43 +08:00
Christopher Lam
944e78144e [qif/qif-merge-groups] speed up duplicate-transaction finding
old method would scan the new-xtn-list (i.e. imported qif
transactions), create a query for each, and run query to find
candidate old-transactions to match each new-transaction.

new method creates 1 query only to scan old-transactions within 1 week
of earliest and latest new-transaction date. then creates a match list
using same heuristics:

* account full name must match
* split value must match
* dates must differ by 1 week maximum
2019-08-04 11:35:24 +08:00
Christopher Lam
b2d1ad526c [qif/qif-merge-groups] compact functions 2019-08-04 11:35:22 +08:00
Christopher Lam
a146d2cd58 [qif/qif-parse] compact functions 2019-08-04 11:35:19 +08:00
Christopher Lam
a3150f383f [qif/test-qif-merge-groups] initial commit 2019-08-03 22:50:19 +08:00
Christopher Lam
277ba729d1 [qif/test-qif-parse] increase coverage 2019-08-03 19:09:51 +08:00
Christopher Lam
1873c2f705 [qif/assistant-qif-import.c] gfec_apply requires a list of arguments
* instead of argument, send a list of arguments.
* the undo scm function would never run otherwise
2019-08-03 17:25:49 +08:00
Christopher Lam
8b7093e8d0 [qif/test-qif-parse] initial commit
near-100% coverage for qif-parse.scm
2019-08-01 20:19:25 +08:00
Christopher Lam
a7a3f78648 [qif/test-qif-imp] initial commit
* strings.scm
* qif-objects.scm
2019-08-01 20:19:09 +08:00
Robert Fewell
19114cc111 Fix register tooltip crash
When the register is in double line mode, a tooltip for the transaction
association column can be shown if one is present by hovering the mouse
over the cell. If the register 'cursor' is highlighting any transaction
row this works but if the 'cursor' is on a split and mouse moves to an
association cell with an entry, Gnucash will crash. To fix this use the
SheetBlockStyle from block instead of the GnucashCursor.
2019-07-30 15:11:12 +01:00
Christopher Lam
db93aec58d [qif-utils] use srfi-13 instead of regexp functions 2019-07-30 18:17:52 +08:00
Christopher Lam
fbb6a95600 [simple-obj] deprecate this module
* it's only a wrapper for make-record-type
* use record-types directly in modules
2019-07-30 18:17:52 +08:00
Robert Fewell
76ba133174 Account Picker dialogue warning message placement
Currently this message is below the dialogue buttons so move the
message to above them.
2019-07-30 09:58:11 +01:00
Robert Fewell
d4dd289113 Error when cancelling the create a new account in register
When you are asked whether you want to create a new account on the
register, possibly due to a typo and you answer no, the same dialogue
will appear another three times before resetting the account cell to
the original value.

These changes eliminate that by returning you back to the cell with the
invalid entry so that you can amend / cancel or use the dialogue again
to create a new account based on an amended entry.
2019-07-30 09:58:11 +01:00
Robert Fewell
aca8a734b0 Error when creating a new account on expanded transaction
With the register in journal mode and you edit the account field so the
'Account x does not exist, do you want to create it' dialogue is shown
you get the following error...

gboolean boolean_from_key(const Account*, const std::vector<std::
__cxx11::basic_string<char> >&): assertion 'GNC_IS_ACCOUNT(acc)' failed

This was tracked down to a refresh being triggered with the account
dialogue so add a check for a valid account as part of the placeholder
test.
2019-07-30 09:58:11 +01:00
Robert Fewell
69f76c6378 Bug 797301/2 - Sub-account register not seeing changes to sub accounts.
If you have a sub account register open and you create another account
that is a descendant of the top account the transaction will not be
seen as the query used for the sub account register does not include
the new account. Add a check to 'refresh_handler' to check for the same
number of sub accounts, if different recreate query.
2019-07-30 09:58:11 +01:00
Robert Fewell
b56203e06f Bug 797301/1 - Menu View->Refresh not refreshing register
The Menu 'View->Refresh' only worked for the report page which reloaded
the report so added functions for other pages as follows. The Register
and Budget pages are reloaded with the remaining pages being redrawn
with a call to gtk_widget_queue_draw.
2019-07-30 09:58:11 +01:00
Mike Evans
aadb3d1462 Bug 797085 - Import Bills & Invoices – headers not translated.
Make strings translatable.

Translators: This adds 22 new translatable strings.
2019-07-29 14:01:31 +01:00
Christopher Lam
5de4b27b25 [balsheet-eg] dedupe functions 2019-07-28 22:57:46 +08:00
Christopher Lam
8cd7c6f755 [taxinvoice-eg] fix html
<nobr> has never been standard. Don't need it because (nbsp ...) will
insert <span white-space=nowrap> tags.
2019-07-28 22:57:46 +08:00
Christopher Lam
326927215c [eguile-html-utilities] dedupe, fix html
* prefer srfi-13 over regex
* instead of <nobr> use <span style="white-space:nowrap">
* reuse functions defined in eguile-gnc and eguile-utilities
* compact functions
* move make-regexp toplevel to ensure one compilation
2019-07-28 22:57:46 +08:00
Christopher Lam
c81e9354f7 [eguile-gnc] fix whitespace 2019-07-28 22:57:46 +08:00
Christopher Lam
955a5651d8 [eguile-gnc] use string-for-each instead of regex 2019-07-28 22:57:46 +08:00
Christopher Lam
e506b7c332 [eguile-utilities] compact functions
* whitespace
* move string-repeat to eguile-html-utilities where it's used
2019-07-28 22:57:25 +08:00
Christopher Lam
e3a695d0d4 [qif-imp/string] fix argument order for string-delete
Guile formerly used the wrong argument order for string-delete and
string-filter. Fix to correct order.

See bug report http://savannah.gnu.org/bugs/?31681
2019-07-28 20:03:12 +08:00
Christopher Lam
e8a41bbf54 [options] compact lookup-option 2019-07-28 12:16:58 +08:00
Christopher Lam
bd0cbbf931 [test-options] initial commit
* test lookup option changed section/name
2019-07-28 12:16:58 +08:00
Christopher Lam
66511f17bb [c-interface] compact functions
fix whitespace. this module has good coverage in test-c-interface.scm.
2019-07-28 12:16:58 +08:00
John Ralls
887f7fac32 Bug 746937 - Template transaction splits are loaded in reverse order...
and then not sorted before saving.

Actually not sorted after loading because the template accounts weren't
being committed.
2019-07-27 15:15:55 -07:00
John Ralls
456ab2241f Remove unused ifdefs for IMPLEMENT_BOOK_DOM_TREES_LATER.
Apparently stub code for a different way of generating the DOM tree, never implemented.
2019-07-26 16:17:09 -07:00
Frank H. Ellenberger
a0a0ffbb77 Bug 797319 - Mauritanian ouguiya MRO shows too few decimals
Add info about cash vs. banking
2019-07-25 23:51:50 +02:00
Frank H. Ellenberger
c77607c8c0 Bug 797316 - New Mauritanian ouguiya MRU not supported
Add info, which Mauritanian ouguiya is recent
2019-07-25 23:33:42 +02:00
Christopher Lam
7c9d5ee7ee Bug 797158 - gnc:make-account-sel-limited-option is not working
Option was being deliberately reset to default_value every time.
2019-07-25 20:22:12 +08:00