Commit Graph

21180 Commits

Author SHA1 Message Date
Robert Fewell
7345a4adfa Change dialog-job to use GtkGrids 2019-05-10 12:20:37 +01:00
Robert Fewell
1a40caee9d Change dialog-order to use GtkGrids 2019-05-10 12:20:37 +01:00
Robert Fewell
3b73c49e80 Change dialog-invoice to use GtkGrid widgets
There was a column alignment error between the labels and widgets as
they were using separate vboxs so moving them all to a Gtkgrid
eliminates this.
2019-05-10 12:20:31 +01:00
Robert Fewell
a26a7c5908 Change assistant-ab-initial.glade so it displays correctly
The text on the first page was squashed as the width could not be
negotiated properly as all the text was set to wrap automaticity and on
subsequent pages there was no wide widgets. Moved the first text row to
a separate widget and not wrap-able so a decent width can be negotiated.
2019-05-10 11:56:23 +01:00
Robert Fewell
5846543279 Bug 797232 - Convert dialog-ab.glade to gtk3 2019-05-10 11:55:40 +01:00
John Ralls
d624894099 Bug 797186 - gtk crash closing parent window edit->stylesheets
Free then NULL, not the other way around.
2019-05-09 19:33:08 -05:00
Christopher Zimmermann
7b6b86000d Bug 797230 - Use after free in
gnucash__sheet_style_destroy.
2019-05-09 19:13:41 -05:00
Christopher Lam
48c3c8bc51 [commodity-utils] partially revert eac79bd506
The eac79bd506 commit was slightly overzealous - if pair was #f,
originally this make-exchange-function would create a function that
returns (gnc:make-gnc-monetary domestic 0); I thought it was
acceptable to return #f instead but this would lead to report
crash. Revert previous behaviour.
2019-05-07 20:36:40 +08:00
John Ralls
810d283e73 "Second fix, revert extraneous change in prior fix." 2019-05-06 21:41:17 -07:00
John Ralls
eec00c8a3f Fix Travis failure. 2019-05-06 21:17:54 -07:00
Frank H. Ellenberger
f1fe106d5c de.po: Remove forgotten fuzzy flag from "Issue _SEPA Transaction..."
5219 übersetzte Meldungen, 39 ungenaue Übersetzungen, 2 unübersetzte
Meldungen.

https://lists.gnucash.org/pipermail/gnucash-de/2019-May/010593.html
2019-05-06 19:35:27 +02:00
Mike Evans
0cb60dd224 Repair unintended indent changes,
This happened in commit 126dc3a for bug 797168
2019-05-06 13:40:21 +01:00
Mike Evans
9e43f6bc42 Implement "printing" to a pdf.
This removes the export to PDF button and uses the standard print
dialog with an option to print tp pdf.
The filename is pre-populated, with the path set to the default, $HOME
on linux.
There is no remembering of past output directories.  Maybe a later
update will do this.
2019-05-05 14:19:34 +01:00
Christopher Lam
6e246ef8ad [options] compact option-setter in generator
slightly more compact, avoids confusing structure whereby 'option' is
both the lambda's argument and the definition of argument.
2019-05-04 06:19:59 +08:00
Christopher Lam
6dd04cfa58 [stylesheet-plain] compact functions 2019-05-04 06:19:59 +08:00
Christopher Lam
1338162d14 [stylesheets] *reindent/delete-trailing-whitespace/untabify* 2019-05-04 06:19:59 +08:00
Christopher Lam
375013f9ea [commodity-utils] simplify gnc:make-exchange-function
Remove assigning exchangelist to exchange-alist.

Removes need to test foreign-amount against 0 - multiplication will
result in 0 anyway. The only functional change is the condition
whereby foreign's commodity is not present in exchangelist; previously
it would return (gnc:make-gnc-monetary domestic 0); now it returns #f.

This function *is* allowed to return #f for invalid or missing prices;
see the (and foreign ...) conditional.
2019-05-04 06:19:59 +08:00
Christopher Lam
e111c5bb07 [commodity-utils] use scheme division instead of gnc-numeric
with small change to test due to increased precision
2019-05-04 06:19:59 +08:00
Christopher Lam
f2aacf94cc [commodity-utils] remove price-is-not-zero? and work-done
because now we're not adding invalid prices to pricelist, and avoids
set! calls

also fix typo in deprecation message
2019-05-04 06:19:59 +08:00
Christopher Lam
fbcf488237 [commodity-utils] refactor resolve-unknown-comm 2019-05-04 06:19:59 +08:00
Christopher Lam
ce675eaac6 [commodity-utils] refactor get-exchange-cost-totals 2019-05-04 06:19:59 +08:00
Christopher Lam
b2dc906bcd [commodity-utils] refactor get-exchange-totals 2019-05-04 06:19:59 +08:00
Christopher Lam
9ef2a2f3dd [commodity-utils] refactor inst price calculator 2019-05-04 06:19:59 +08:00
Christopher Lam
91f3e9fefe [commodity-utils] refactor totalavg price calculator
use exact rationals, therefore test suite amended
2019-05-04 06:19:59 +08:00
Frank H. Ellenberger
76936bc646 [I18N] Improve doc-page of CSV transaction importer
Text based on
https://lists.gnucash.org/pipermail/gnucash-devel/2019-May/043795.html
2019-05-03 23:08:43 +02:00
John Ralls
8fb2111636 Merge Christoph Holtermann's 'pycons-more-verbose' into maint. 2019-05-03 13:26:42 -07:00
c-holtermann
24ac69d8a9 make python shell startup more understandable 2019-05-03 18:13:52 +02:00
Frank H. Ellenberger
53e4e8a976 Use standard buttons in "Tip of the Day" 2019-05-03 13:15:32 +02:00
Frank H. Ellenberger
275463d3b8 N[I18N] "Next" is the new "Forward"
From GTK2 to 3 the button label changed. So several texts referenced a
no longer existing button.

For changed strings also unify quotation to \"
2019-05-03 13:15:15 +02:00
Robert Fewell
8d71fcaf2f Bug 797223 - Preference missing tooltip
The Preferences 'Register/Tab order includes Transfer on Memorised
Transaction' was not displaying its tooltip even though it was in the
glade file. Recreated the Register notebook page and the business page
as it also had a missing tooltip.
2019-05-03 11:42:47 +01:00
Robert Fewell
38dfc6ecd2 Use the commodity on selected parent rows in price tree view
If the parent row for prices in a price tree view is used for a new
price the security value can be wrong so get the commodity of this row
and use it for a temporary price which is cloned for editing.
2019-05-03 11:37:42 +01:00
Robert Fewell
c782e7a4da Bug 797051 - Follow up - Change defaults for new price
Set the default date of a new price to today and the value to 0
2019-05-03 11:31:26 +01:00
John Ralls
7c9f01ff3b GetUserDefaultLocaleName returns a Windows-style locale too. 2019-05-02 11:27:23 -07:00
Christopher Lam
653d8cb5c3 [general-ledger] remove dependency on transaction.scm 2019-05-01 19:06:53 +08:00
Christopher Lam
ff3a34711a [income-gst-statement] remove dependency on transaction.scm 2019-05-01 19:06:50 +08:00
Christopher Lam
b87d693a77 [trep-engine] modularise trep-engine 2019-05-01 18:58:39 +08:00
Christopher Lam
14b3255933 [reconcile-report] pull reconcile-report into separate file 2019-05-01 18:58:39 +08:00
Mike Evans
29416292a9 Remove FIX ME
Since it works fine and I can't remember why I put it in.
2019-05-01 11:46:42 +01:00
Mike Evans
c28196fb06 Fix indents, 2019-05-01 11:45:43 +01:00
Mike Evans
126dc3a790 Bug-797168 Proposed fix. 2019-05-01 11:45:43 +01:00
John Ralls
bfbb89f6e2 Rewire and corrected Doxygen comment for gnc_get_locale() c++ function.
There's no point in going through the cache dance on MinGW, that will
just throw.
2019-04-30 15:00:06 -07:00
John Ralls
529a6cb067 Call setlocale(LC_ALL, "") exactly once.
And in Windows only with the value from the environment if there is one.
Calling it with "" in Windows ignores the environment and sets it to the
system settings.
2019-04-30 14:56:43 -07:00
John Ralls
d30cf25c45 Call setlocale() with the right form of locale code on Windows.
Perversely Windows uses the form xx-YY for its own localization
functions but xx_YY for the posix ones including setlocale().
2019-04-30 14:53:46 -07:00
John Ralls
114efe5936 Transcode non-constant strings before passing them to scm_eval_string.
Instead of using scm_c_eval_string, which transcodes with
scm_from_locale_string. That doesn't work on Windows.
2019-04-29 15:00:54 -07:00
Frank H. Ellenberger
1c1fa36023 de.po: update PO-Revision-Date
Follow up of commit 6b10c2f
2019-04-29 23:16:03 +02:00
pianoslum
6b10c2f284 Fix small typo in German translation 2019-04-29 21:36:25 +02:00
John Ralls
a711497130 Fix Travis failure.
Maybe. Can't reproduce it so trying something that looks reasonable.
2019-04-28 21:53:56 -07:00
John Ralls
e42c811341 Make TreeView toggle-buttons not activatable if no toggle callback.
So that it's clear in the UI that clicking on the box won't do anything.
The case that triggered this is the Get-online-quotes item in the
Securities Editor tree view.
2019-04-28 17:09:02 -07:00
John Ralls
3feb864691 Add an optionally-compiled diagnostic console on Windows. 2019-04-28 16:59:51 -07:00
John Ralls
6c7ccbd9e7 Bug 797134 - Decimal separator: Windows configured as dot,...
Gnucash shows comma.

This was introduced by 8f88b7f2b. It turns out that Windows
implementation of setlocale works only if the POSIX locale environment
variables (i.e. LC_FOO or LANG) are set, otherwise it returns NULL. We
were unknowingly relying on Guile to retrieve the Windows environment
for us and that would do the wrong thing if the user had set the locale
in the environment file, so 8f88b7f2b restored it... unfortunately to
the C locale.

This commit changes the set_win32_thread_locale function to work in
both directions, setting both locales from the environment variables
if any are set and calling setlocale with the result of
GetUserDefaultLocaleName if not.
2019-04-28 16:34:58 -07:00