Commit Graph

16550 Commits

Author SHA1 Message Date
Geert Janssens
531335a8f9 Move some utility functions from gui code to engine
And reduce some of the clutter in these functions and their callers.
2016-03-25 14:40:07 +01:00
Geert Janssens
163c4dd44a Update POTFILES.in after previous commit 2016-03-25 10:39:13 +01:00
Geert Janssens
39bfeba930 Merge reg and reg2 variant of print check dialog back into one file
There was nothing in the duplicate file that was different
from the original one except for the plugin_page parameter
initially passed in. Turns out we don't need anything
from the plugin_page except for the very generic GtkWindow
which is actually a member of the generic GncPluginPage
base object. So pass that window instead and avoid the
need for differentiation.
2016-03-24 22:49:27 +01:00
Geert Janssens
cde9d78465 Bug 693342 - Print (bottom) prints to middle for 3-check pages 2016-03-24 19:22:10 +01:00
Geert Janssens
f168cb2e1f Revert "Bug 118391 - Long currency names untranslated"
This reverts commit 9f984c05eb.

The change causes the windows build to crash. Needs more
investigation.
2016-03-23 21:43:07 +01:00
Geert Janssens
f7b0cb65bc Disable debug message that got enabled by accident last year 2016-03-23 21:28:45 +01:00
Geert Janssens
139e3ea569 Bug 687504 - Not possible to reset an invoice/bill counter format 2016-03-23 18:29:08 +01:00
Geert Janssens
0e91583754 Bug 642292 - General Ledger report - 'Primary Sort Key' value is not persistent 2016-03-23 14:48:21 +01:00
John Ralls
e003cb07db New Xcode, new errors, sigh. 2016-03-22 17:24:41 -07:00
Geert Janssens
aec61497f2 Bug 482186 - Customer and vendor report for partners who get invoiced/paid in foreign currency show total labeled with the symbol of the default currency. 2016-03-22 18:33:49 +01:00
Geert Janssens
0114a7317b Bug 728074 - Posting bill converts currency to itself using 0 rate 2016-03-21 17:11:05 +01:00
Geert Janssens
9f984c05eb Bug 118391 - Long currency names untranslated
Fix for Win32
2016-03-21 11:30:44 +01:00
Geert Janssens
6242524789 Fix typo 2016-03-21 09:49:12 +01:00
John Ralls
2059f06f27 Open correct xea directory if user has worked around bug 725296
Bug 725296 reports that setting LANG=sv_SE fails to set the language.
This turns out to be an error in gettext, but it can be worked around
by setting LANG=Swedish_Sweden. That broke looking up the localized
account directory, so this special-cases "Swedish_Sweden" and
"Swedish_Finland" when looking up the account directory.
2016-03-20 15:52:07 -07:00
John Ralls
9854876c70 OSX: Get the locale for account trees from the OS instead of setlocale().
It's possible for OSX to create locales that while legal aren't
supported by setlocale, and we have account trees for some of these.
Retrieving the locale from NSLocale ignores the fixup done in
gnucash-bin to ensure that a reasonable and supported locale is used.
2016-03-20 15:15:37 -07:00
Geert Janssens
dca13d6248 Fix doxigen comment after changed const behaviour 2016-03-19 15:31:46 +01:00
Geert Janssens
6c2c2d73a3 Bug 620281 - Adding reversing transaction to bill transactions creates undeleteable transactions 2016-03-19 14:32:14 +01:00
Geert Janssens
d1e148ef87 Refuse to void read-only transactions.
Add test case to verify
2016-03-19 14:13:46 +01:00
Geert Janssens
0f66e20005 Bug 754209 - Bills can be posted multiple times from "find bill" search results - follow up
This commit adds code to check & repair that removes the read only status of the bogus transactions so the user can go in the AP/AR account and delete these bad transactions.

Translators: this commit introduces a new translatable string.
2016-03-19 14:13:44 +01:00
John Ralls
d45886f73b Bug 733164 - Command-H Invokes Help->Help Contents
Override the Gtk-supplied accelerator for the help menu.
2016-03-17 16:51:46 -07:00
John Ralls
3109b6f6c3 Set the transaction currency during auto-completion.
When auto-completing a transaction that was originally created in another
account with a different currency the balancing code will try to apply
conversions in the wrong direction if one edits the transaction. Explicitly
setting the transaction currency to the current register's currency
prevents the conversions being applied and allows the transaction to
balance correctly.
2016-03-17 15:42:12 -07:00
John Ralls
d0e103be08 Correctly re-value splits when the transaction currency is changed.
When a transaction with existing splits had its currency changed, the
function would change the values to use the new currency's denominator
without changing the actual value. The balancing code would then apply
the price of the the new "other" split to the amount, changing it as
well. Changing the transaction currency back would convert the value in
the other split correctly so that it would equal the amount that the
balancing code wouldn't change anything. I actually detected this bug
when I wrote the test but didn't recognize it as a bug.

The new code first calculates a new price and then applies it to each
split so that the transaction balances correctly in the new transaction
currency. This also round-trips correctly
2016-03-17 15:42:12 -07:00
Geert Janssens
c2ce204434 Use PRIi64 instead of PRIx64
We obviously want our business counters to use integral numbers instead of hexadecimal...
2016-03-17 23:06:52 +01:00
Geert Janssens
a27abf766a Bug 728722 - Setting number format details appear wrong in Help, section 10.3.4. Counters Book Options Tab
This is a follow-up commit to fix the core of the issue.
With this commit gnucash is more liberal at accepting
counter formats. It will accept either li, lli, I64i and
whatever is defined for G_GINT_64 or PRIx64 on the user's
platform. Internally the code will always convert the
specifier set by the user with PRIx64, which should always
be the correct one on any platform.

Additionally a few extra tests were added to stress the
counter format code a bit more.
2016-03-17 22:37:42 +01:00
Mike Evans
8117a7c17f Bug 754209 - Bills can be posted from "find bill" search results
even if bill is already posted and results in extra $ posted to A/P

This adds a test in gncInvoice to return NULL it already posted.

Adds checks in dialog-invoice to test for already posted invoices. Messages
user and refuses to post entire selection if more than one selected.

Translators: This adds a message string.
2016-03-16 14:36:11 +00:00
Geert Janssens
1121cd0795 Bug 720934 - Barcharts with many data points have overlapping x-axis labels
Depending on the available chart width x-axis labels will be pruned
from the full list to ensure the labels that are printed will
always be readable.
2016-03-15 08:19:35 +01:00
Chris Good
ab35b571c3 Add Tip Of The Day re using multiple windows to do comparisons - Bug 762800
Note: this introduces an untranslated string to the stable series
2016-03-13 14:06:20 +01:00
Geert Janssens
ee70922c5b Fixup previous commit
Forgot to add my changes before pushing...
2016-03-13 13:54:46 +01:00
Matt G
7ef2568939 Bug 742352 - Budget Summary section does not show expense totals
Fixed buget add up issue.
https://bugzilla.gnome.org/show_bug.cgi?id=742352
2016-03-13 13:18:47 +01:00
Gilles Dartiguelongue
c56a4d9593 Bug 760015 - guile support is automagic
Make guile support selectable
2016-03-13 13:07:03 +01:00
John Ralls
18e6100411 Bug 763146 - Invalid exchange rate is recorded when entering multi-currency transaction
A bunch of little fixes grouped into a feature branch.
2016-03-11 15:46:45 -08:00
John Ralls
a406903705 Ensure numerator is positive before checking if the value is < 1. 2016-03-11 15:43:30 -08:00
John Ralls
1ca56c9d0d Ensure price is set when the amount is entered and user doesn't tab out. 2016-03-11 15:42:53 -08:00
John Ralls
c4ce44df64 Test rounded values, but don't store them, to minimize jitter in prices. 2016-03-11 15:10:12 -08:00
John Ralls
e26e598cdc Check price_source precedence first to save computation. 2016-03-11 15:08:11 -08:00
John Ralls
ba4acdfef1 Ensure that xferData->price_source is always set correctly.
If the user doesn't tab out of the price window before pressing return
or clicking OK gnc_xfer_price_update_cb isn't called, but it does call
gnc_xfer_update_to_amount, which does get called by
gnc_xfer_dialog_response_cb.
2016-03-11 15:03:19 -08:00
John Ralls
2ed85cefa3 Fix double semicolon. 2016-03-11 13:23:23 -08:00
John Ralls
afe7dacb85 Remove price-direction code for to default currency and alphabetic order.
It's much more important to have currency exchange rates > 1 to preserve
significant digits.
2016-03-11 12:59:01 -08:00
John Ralls
56cb0327e1 Extract functions update_price and new_price from create_price. 2016-03-11 12:22:57 -08:00
John Ralls
4a60e49066 Fix typo in HTML header. 2016-03-10 10:59:53 -08:00
John Ralls
2b95816125 Bug 763111 - commodities prices editor creates hidden db entries
There were two problems: First, if there were multiple prices in the database
for a particular day only one would be displayed. Second, if one manually
created a second price on a day in the price editor the first wouldn't
be removed.
2016-03-10 10:28:41 -08:00
John Ralls
5b40df510d Bug 763279 - GnuCash has empty reports
On recent builds of gentoo, apparently because the supplied webkit dislikes
that we output xhtml in a file called foo.html. Make the header say that
we're using HTML4.
2016-03-10 10:28:41 -08:00
John Ralls
ec83e3a338 Bug 722996 - Cannot add stock price on Price Editor
gtk_combo_box_set_active() doesn't work if the model is changed after
the combo box is constructed.
2016-03-10 10:28:41 -08:00
Geert Janssens
71574b7dde Minor tweaks to Bayesian feature flag
- use shorter definition
- set correctly understood as of 2.6.12 instead of 2.7.0
2016-03-10 15:30:56 +01:00
Robert Fewell
7003a56171 Make gnucash 2.7+ rerun bayesian data conversion whenever needed
Whenever recent 2.6.x versions of gnucash store bayesian data
in the old format (full account name based), gnucash 2.7+
should perform a conversion the the new format (guid based)
on subsequent opening of the file.
2016-03-10 12:13:13 +01:00
Robert Fewell
1806515122 Allow matching accounts to be found also by their GUID
which will be used in newer versions. The
default behaviour is still to create new entries
under the account fullname.
2016-03-10 12:12:32 +01:00
Robert Fewell
712d340bf4 Introduce GUID_BAYES feature flag
This will be set by future versions of gnucash (2.7+) when
they save bayesian data using GUID's instead of full
account names. The flag will prevent older versions
(2.6.11 and older) from opening data files with such data.
2016-03-10 12:12:30 +01:00
Mike Evans
b89723a561 Bug 762971 - Duplicating multiple invoices results in invoices without an ID number
If a duplicated invoice doesn't have an ID (which it won't if multiple invoices are
duplicated) allocate it (them) the next ID.
2016-03-03 12:13:36 +00:00
Mike Evans
e4e19a4caa Bug - 761172 Importing invoices posts incorrect values.
This looks a rounding error caused by not setting the denominator to an
appropirate value. I've set it to 100x the currency fraction.

For some reason I removed the call to gnc_numeric_convert() in commit
564b987457 I shouldn't have done that. I should have adjusted the denom.
2016-03-02 09:23:10 +00:00
Phil Longstaff
cb88fe8f93 Memory leak in gnc-gsettings.c 2016-02-28 07:42:37 -05:00