Commit Graph

22663 Commits

Author SHA1 Message Date
John Ralls
53e48ab6fa Get rid of GncScrolledWindow.
It's just a pointless rename, no added value at all.
2020-05-20 16:54:40 -07:00
John Ralls
700e2dc5ac gnc_item_list_num_entries: Count the GtkListStore in use. 2020-05-19 15:38:58 -07:00
John Ralls
09a57e9bc0 Connect to the popup's size-allocate signal only once. 2020-05-19 15:26:39 -07:00
John Ralls
26fe8e7800 Use correct type of 0 for char* return value. 2020-05-19 09:53:22 -07:00
Robert Fewell
6ee485441f Bug 797754 - Account Register scrolling stops working
In an account register, scrolling stops working when the mouse pointer
re-enters the scrollbar after leaving it. This was caused by a fix for
the scrollbar not being updated in earlier versions of Gtk+. Having
removed this earlier fix and tried on Windows 10 and two flavours of
Linux with the current version of Gtk+ the earlier problem is not
evident so this commit removes that fix.
2020-05-19 11:19:13 +01:00
Robert Fewell
5640de09df Reselect the transaction rows in import-main-matcher
Once the transfer account is selected and control returned to the
Generic main matcher window the transaction rows will now be unselected.
This commit reselects the appropriate rows.
2020-05-19 10:32:11 +01:00
John Ralls
279a632b40 Bug 797760 - Broken register split activity...
cannot delete splits, unable to tab complete account name.

The final piece, commits the currently selected item in the PopBox
when tabbing out of a register combocell in type-ahead mode.
2020-05-18 14:14:08 -07:00
John Ralls
07325f796c combocell_gnome: Prevent starting off in type-ahead mode on entry
By ensuring that the list_store is set to the default and tmp_list
is empty.
2020-05-18 12:44:39 -07:00
John Ralls
9b028a7f58 combocell_gnome: Block signals for all list deletes.
Otherwise gnc_combo_cell_modify_verify is called once for every deleted
line in the gtk_list_store.
2020-05-18 12:44:39 -07:00
John Ralls
2d6953e9f4 combocell-gnome: Process deletes and inserts before performing matching. 2020-05-18 12:44:39 -07:00
Geert Janssens
2ef1dc4393 Drop unrelated source file from POTFILES.in
This is from another work in progress branch. Shouldn't have been added to master yet.
2020-05-18 19:53:31 +02:00
Geert Janssens
01333faec4 add-price-quotes doesn't use modules, so don't load them 2020-05-18 16:23:43 +02:00
Geert Janssens
9df81fa7ab Fix crash in case filter is less than 4 parameters
This apparently is not an issue on maint, but on master it results in a crash.
2020-05-18 11:46:13 +02:00
John Ralls
3e44af3c78 Ensure gnc_item_list's temp_store is NULL when list store is in use.
So that gnc_item_list_using_temp gives the right answer.
2020-05-17 16:51:30 -07:00
John Ralls
b5ebb24539 Remove redundant use of gtk_accelerator_get_default_mod_mask().
It just returns GDK_MODIFIER_INTENT_DEFAULT_MOD_MASK.
2020-05-17 16:51:29 -07:00
John Ralls
9d17b3fc28 Initialize the bounds variables in gnucash_sheet_insert_cb.
So that bogus values aren't saved if gnc_table_modify_update doesn't touch them.
2020-05-17 16:51:29 -07:00
John Ralls
4479e44363 Fix delete ignores selection in register cells.
Don't clear the selection before passing the event to the entry's
keypress handler. Instead set the sheet selection from the entry
when the handler returns.
2020-05-17 16:51:29 -07:00
John Ralls
0aeb4b54ae Remove actions on the control, shift, and alt keys.
Those keypresses are now blocked along with all other naked modifiers.
2020-05-17 16:51:29 -07:00
Robert Fewell
31825be43f Change the Options Checkbox
Change the Options GtkCheckBox to use its own built-in label and remove
the label in the first column. The GtkCheckBox will still be placed in
the second column and aligned with the other widgets.
2020-05-17 16:10:36 +01:00
Christopher Lam
5b597dfea4 [html-chart] add z-index:999 to anchor
otherwise it is not always visible
2020-05-16 23:19:09 +08:00
Christopher Lam
0f56bed0d9 [receipt.eguile] simplify
1. taxtables? was a hack to disable tax display; this is now obsolete
since bug 573645 was fixed with 8221aada. the equivalent
taxinvoice.eguile.scm hack was removed with 0eb2c2b3 but never removed
in receipt.eguile.scm

2. break out date<? comparator

3. use lispy for-each instead of pythonic for

3. compact code
2020-05-16 23:19:09 +08:00
Christopher Lam
9116fece7d [taxinvoice] remove dead code, simplify
* customer-only filter for invoice option never been in use.
2020-05-16 23:19:09 +08:00
Christopher Lam
c69153fce1 [taxinvoice.eguile] simplify
1. break out date<? comparator

2. the (if (not (null? opt-invoice)) ...) section is always run
because display-report is only called when opt-invoice isn't null

3. use lispy for-each instead of pythonic for loops
2020-05-16 23:19:09 +08:00
John Ralls
a81f155408 Fix abort in qof_log_check.
Apparently g_logv doesn't like recursive calls from its log handler.
2020-05-15 12:52:18 -07:00
John Ralls
8283263459 Restore AQBanking to operation.
And remove some dead code that had been #if-0ed since it was written.
2020-05-14 17:12:04 -07:00
Christopher Lam
09a8bee5c0 Merge branch 'speedup-aging' #638 2020-05-14 20:30:08 +08:00
Christopher Lam
8ea9e41190 [register] display $0.00 for zero-value splits 2020-05-14 20:30:05 +08:00
Christopher Lam
ecf429a49a Merge branch 'master-796932' 2020-05-14 19:38:55 +08:00
Christopher Lam
bbde69ffcd [register] price shown in transaction currency rather than account's parent currency
error in commit 710b559cc4

xaccSplitGetSharePrice is priced in the transaction
currency. gnc-account-get-currency-or-parent would only output the
correct price currency if the chart of accounts was set up properly.

also: for Dr/Cr display, small modification to ensure a "$0.00" is
rendered when the split value is neither positive nor negative.
2020-05-14 19:37:54 +08:00
Robert Fewell
86dc6dcb96 Remove some spaces and tabs from dialog-options.c 2020-05-14 12:13:08 +01:00
Robert Fewell
9f59d2cbd7 Enable the Options Checkbox label to be used to toggle
With the new the options dialogue using a GtkGrid it is required that
clicking on the label of the GtkCheckBox would also toggle the
GtkCheckBox. To this end the label is added to an event box so it can
be clicked on and a callback used to toggle the checkbox.
2020-05-14 12:07:42 +01:00
Robert Fewell
6fb50d227a Complete the move of saving register filter/sort to .gcm
This commit changes the saving of register filter and sort information
from KVP entries to using the .gcm file. On register load these
settings are transferred to the .gcm file and the KVP entries removed.
A feature flag is also set when the first register is loaded by this
version.
2020-05-14 10:26:17 +01:00
Robert Fewell
bf9c44416e Remove the setting of a comment for registers 2020-05-14 10:26:17 +01:00
Robert Fewell
b6de2981b8 Remove the state key file comment for Account filter 2020-05-14 10:26:17 +01:00
Robert Fewell
2494ad1adf Add option to save Layout for Register items
Add two menu items under windows, one to save an existing register
layout based on the register type to there respective default layouts
so the user set column widths will be used when opening registers. The
second menu item will reset the column widths to defaults and remove
the associated default layout.
Open registers will also save there column widths to the page section
so these could can temporarily have different widths.
2020-05-14 10:26:17 +01:00
Robert Fewell
74abd821b3 Add enum SplitRegisterTypeGroup to group registers
Add SplitRegisterTypeGroup to group registers that have the same layout
and it will also be used to get the default user state information for
register cell widths.
2020-05-14 10:26:17 +01:00
Robert Fewell
4c8ebfe171 Change state_section parameter for gnc_table_save_state
Change state_section to a const gchar* and update where used as required
2020-05-14 10:26:17 +01:00
Robert Fewell
2f5225ad33 Add option to save Layout for Business items
Add two menu items under windows, one to save an existing layout for
Invoices, Bills and Vouchers to there respective default layouts so the
user set column widths will be used. The second menu item will reset the
column widths to defaults and remove the default layout.
Open Business items will also save there column widths to the page
section so these can temporarily have different widths.
2020-05-14 10:26:17 +01:00
Robert Fewell
b622518fce Test for a valid register state comment before trying
to add it
2020-05-14 10:26:17 +01:00
Christopher Lam
dba9ba2f8f Bug 796932 - Invoices order when assigning payments
sorts documents in dialog-payment.c by date, then by document ID.
2020-05-13 18:39:41 +08:00
Christopher Lam
a874483b70 [register] show number columns right-aligned 2020-05-13 13:55:59 +08:00
Christopher Lam
f8bad131a5 Merge branch 'maint-797743' #720 price renderers 2020-05-13 13:20:09 +08:00
Christopher Lam
710b559cc4 [register] [bugfix] use new price renderer
also bugfix: show price in account parent currency, instead of the
original currency.
2020-05-13 13:15:50 +08:00
Christopher Lam
f9fce766c3 [trep-engine] use new price renderer 2020-05-13 13:15:47 +08:00
Christopher Lam
7557c5b54e [advanced-portfolio] use new price renderer 2020-05-13 13:15:45 +08:00
Christopher Lam
8b3841b4b5 [balsheet-eg.eguile] use new price renderer 2020-05-13 13:15:45 +08:00
Christopher Lam
d8c21c4625 [balsheet-pnl] use new price renderer 2020-05-13 13:15:42 +08:00
Christopher Lam
61afe53f0f [html-utilities] use new price renderer for exchange-rate table 2020-05-13 13:15:33 +08:00
Christopher Lam
9020c967c7 [html-style-info] export gnc:default-price-renderer
converts gnc:monetary containing a price to string
2020-05-13 11:36:22 +08:00
Christopher Lam
3d25a40d1f [gnc-ui-util] add gnc_price_print_info
similar to gnc_default_price_print_info but also accepts a use_symbol
specifier. for generating print_info for prices, either exact e.g.
$1 + 2/3, or inexact e.g. $1.3333
2020-05-13 11:36:22 +08:00