Commit Graph

19482 Commits

Author SHA1 Message Date
Geert Janssens
563d716161 Csv imp settings - internalize prefix handling
This information is not relevant outside of the settings code
The way it's implemented now each settings module defines its
own unique prefix and the generic code can just use it when
needed.
2018-03-08 18:55:20 +01:00
Geert Janssens
b577a7daf1 Csv import settings - undo rename of common methods
Use C++-style to call method with same name in parent class
2018-03-08 18:55:20 +01:00
Geert Janssens
751a3fec43 Csv importer - align file names
Done in a separate commit
2018-03-08 18:55:20 +01:00
Geert Janssens
e71f561236 Bug 793467 - GnuCash crashes when trying to open a binary file instead of a CSV
The cause was an uncaught exception from boost::tokenizer.
Fix and add test case.
2018-03-08 18:55:20 +01:00
Geert Janssens
6fe7d88548 Enable test to handle attempt to load non-existing file in csv importer 2018-03-08 18:55:20 +01:00
Geert Janssens
89c1534d51 Csv import - improve memory handling in the assistant class
Make it more RAII, in that whatever the class allocates, it should
also deallocate. This simplifies a couple of memory handling cases.
The only exception is the generic import matcher that for some reason
has chosen to deallocate itself. To be fixed when more importers are
converted to c++
2018-03-08 18:55:20 +01:00
Geert Janssens
1449d4ca68 Add some background info on memory management in CSV importers
As the assistant code combines multiple memory management models care should be taken
not to mix them up. The notes should give some insights in how to do this.

Also fix a few minor issues
- delete default copy and move constructor/assignment for the assistant gui class
- nullify a freed pointer
2018-03-08 18:55:20 +01:00
fell
f8fd9dd272 Merge branch 'maint' into unstable
PR #303
2018-03-07 05:37:42 +01:00
Di Mang
e766c71acc Remove the unnecessary comments:
<!-- Local variables: -->
<!-- mode: xml        -->
<!-- End:             -->


This comments are to help emacs recognize that the files are xml
since they don't have 'xml' as an extension
2018-03-06 20:28:08 +01:00
John Ralls
2acb6da2b8 Bug 794083 - gnucash-2.7.5: cmake+make build installs Makefile 2018-03-06 10:13:06 -08:00
John Ralls
5520fae838 Bug 793941 - 2.7.4: test failure on i686: 59 - test-gnc-timezone
Don't test before 1916, that's not a common GnuCash use-case.
2018-03-06 09:56:13 -08:00
John Ralls
36d729652b Speed up GUID equality comparison. 2018-03-06 09:48:38 -08:00
fell
d95eb0f7f3 Merge branch 'maint' into unstable
PR #300
2018-03-06 05:58:07 +01:00
Di Mang
6457b2ebe5 Adjustment of Account Hierarchy Templates.
(mentioned in PR #293 on GitHub)

1) Added namespace section (header)
2) Added missing placeholder
2018-03-05 23:04:04 +01:00
Geert Janssens
30fb1dc479 Merge branch 'unstable-bugfix' of https://github.com/christopherlam/gnucash into unstable 2018-03-05 16:57:00 +01:00
Geert Janssens
ddba926e49 Merge branch 'unstable-transfer-02' of https://github.com/DiMan/gnucash into unstable 2018-03-05 16:56:07 +01:00
Geert Janssens
e2d69b174e Merge branch 'master' of https://github.com/nielsegberts/gnucash into unstable 2018-03-05 16:54:24 +01:00
Geert Janssens
8a33864168 Merge branch 'cpack' of https://github.com/TheBiggerGuy/gnucash into unstable 2018-03-05 16:52:55 +01:00
Guy Taylor
41d79f4ef3 Fix CPack package version number
Currently running "ninja-build package" produces a file with and incorrect
version number. This patch passes the CMake version variables into CPack to get
the correct filename.

Old "gnucash-0.1.1-Linux.tar.gz" new "gnucash-2.7.5-Linux.tar.gz"
2018-03-05 15:38:41 +00:00
Christopher Lam
21ea6d56bf Modernise chart colours
This commit changes chart colours from the dated CSS defaults to
modern colours as suggested by http://clrs.cc/
2018-03-05 20:24:12 +08:00
Christopher Lam
22517f98ce taxtxf: schemify 2018-03-05 20:24:12 +08:00
Christopher Lam
41322ec3d8 <br> to <br/> and ~s to ~a 2018-03-05 20:24:12 +08:00
Christopher Lam
551e98435d remove begindate in qofquery
This was producing a date corresponding to 01-01-1970. make-zdate was
being used in aging.scm as a hack to search all splits prior to
end-date. fix the date query logic to set begin-date match to #f.
2018-03-05 11:12:13 +08:00
fell
580ce72da7 Merge branch 'maint' into unstable 2018-03-05 03:40:48 +01:00
Di Mang
fc5bdfa10b Revision and expansion of accounts for the Russian language.
In addition, replacing of commodity: USD => RUB.

Cherrypicked from unstable and adjusted to main
2018-03-05 03:05:43 +01:00
Di Mang
a72e0bdd5e Add spacing between border and text in dialog "New Accounts Hierarchy Setup".
There is no spacing between the text and the frame in the dialog
"New File" > "New Accounts Hierarchy Setup". In some cases - when
changing the window size - the text appears next to the frame.
It does not look very clean. As a solution, I have defined here a small spacing: 5px.
2018-03-04 14:09:24 +01:00
Christopher Lam
51e2511223 Bug 765846 - Expense Over Time for subaccounts: An error occurred while running the report
fix crash if acc-depth too low
2018-03-04 19:21:52 +08:00
Christian Stimming
18f0d053b0 Fix auto-selection of splits in reconcile
Really use all splits of any given day. Up to now usually the splits
of the given date were not or not all included, as the time comparison
didn't correctly ignore any given time-of-day of the splits. Instead,
all possible time-of-days should be included.
2018-03-04 00:19:38 +01:00
Di Mang
335082480d Revision and expansion of accounts for the Russian language.
In addition, replacing of commodity: USD => RUB.
2018-03-03 22:08:39 +01:00
Christopher Lam
2d983c6703 bugfix gnc_ui_new_account_window
parent -> parent_acct
fixes bug introduced in c76efd656e
2018-03-03 00:26:49 +08:00
Geert Janssens
e4884cdf09 Merge branch 'maint' into unstable
Ignoring changes in obsolete test-flat-bayes.c (was removed before on unstable)
2018-03-01 19:59:34 +01:00
Geert Janssens
cf73c93bdf Bug 792008 - gnucash 2.6.19 fails to build
Replace g_assert_true with g_assert for now
2018-03-01 19:58:07 +01:00
Geert Janssens
13e6880b34 Bug 745941 - Review of po Headers / make pot 2018-03-01 18:31:49 +01:00
Geert Janssens
a64e40dac3 Properly detect git in case of linked worktree 2018-03-01 18:21:38 +01:00
Christopher Lam
546b54c976 TR: Show "Grand Total" only if it has been generated. 2018-03-01 21:23:55 +08:00
Christopher Lam
cb18d3ca42 test-TR: Add dual-column testing 2018-03-01 20:55:17 +08:00
Christopher Lam
4f98391a27 test-TR: unit tests
initial attempt
2018-03-01 20:55:17 +08:00
Christopher Lam
5176850083 TR ENH: Add "Subtotal Summary Grid"
The subtotal summary-grid will tabulate subtotals - prime-sortkey
vertically, sec-sortkey horizontally. This will be useful, for
example, with prime-sortkey = accounts, sec-sortkey = date,
sec-subtotal = monthly... will produce a monthly time series
spreadsheet.

Introduces grid datastructure.

This is a simple list, each element is a vector
(vector row col data).

In the Transaction Report, row and col are defined
as a pair (cons sortvalue subtotal-heading), whereas:
- sortvalue = string/number used to sort the grid headers,
- subtotal-heading = string used as grid header row/col
- data = the gnc-monetary collector.
2018-03-01 20:55:17 +08:00
Geert Janssens
dd0553af6a Merge branch 'scheme-progress-1' of https://github.com/christopherlam/gnucash into unstable 2018-03-01 13:01:29 +01:00
Christopher Lam
8fef1adcc4 date-utilities: bugfix weekly render
This was introduced by 48bdab3.
2018-03-01 12:14:53 +08:00
John Ralls
93f892072c Bug 793947 - Impossible to render printable invoice
gncInvoiceGetID returs a char*, so ~a is indeed the correct code.
Odd that the scheme sprintf used %d to format it.
2018-02-28 19:45:49 -07:00
Christopher Lam
7054cc83bc Bug 793898 - 2.7.4: Incorrect copyright statement in gnucash/report/standard-reports/sx-summary.scm
no copyright claim was intended
2018-03-01 06:40:16 +08:00
Christopher Lam
872aa6b740 TR: change multichoice values from list to symbols
Context: https://wiki.gnucash.org/logs/2018/02/24.html#T05:43:50

Summary: I had formerly set some multichoice values to be a list.
However I think options.scm cannot handle list values. They must be
scheme symbols. It wasn't clear to me during TR refactoring and
development.

The root cause is in options.scm multichoice handling, whereby it's
trying to compare the option value with (eq?); in scheme (eq? (list
"A") (list "A")) is always #f.

06ad55cae9/libgnucash/app-utils/options.scm (L911)
is the relevant old code.
2018-03-01 06:40:16 +08:00
Christopher Lam
90fb712c7f TR: make no-report-data message consistent with initial no-account 2018-03-01 06:40:16 +08:00
Christopher Lam
840e1f8b02 TR: simplify no-account-after-filtering stage 2018-03-01 06:40:16 +08:00
Niels
7ef8e6d489 Fix fall through in Account.cpp
Found with -Wimplicit-fallthrough, but older versions of GCC don't support it. So it will take some effort to add it to the build config.

I think it did not result in a reproducible bug.
2018-02-28 22:23:15 +00:00
Christopher Lam
d8d552ee8a options.scm: tidy (gnc:render-options-changed)
This small change introduces \n into the HTML render.
2018-03-01 05:30:48 +08:00
Geert Janssens
7da9a3ba58 Merge branch 'reg-item' of https://github.com/Bob-IT/gnucash into unstable 2018-02-28 18:16:10 +01:00
Robert Fewell
8353b5693e With register obscured the sheet kept being redrawn
When the register is obscured by another window, the sheet would get
lot of draw events. This was tracked down to getting the foreground
colour for the item-edit widget for the state GTK_STATE_FLAG_NORMAL.
Changed this to use the value obtained from gtk_widget_get_state_flags.
2018-02-28 16:33:54 +00:00
Geert Janssens
ad1664604f Cleanup namespace usage for boost::locale
In a previous commit I wrongly believed xgettext might not find
our strings if we used the fully namespaced boost::locale::translate or
aliased bl::translate instead of just translate. However that's
wrong, so I have changed the code to always use bl::translate.
2018-02-28 16:50:20 +01:00