Commit Graph

28102 Commits

Author SHA1 Message Date
John Ralls
833a681a5e [stock-txn-asst] Fix return calls in StockAssistantModel::create_transaction. 2023-06-29 14:33:58 -07:00
John Ralls
98e4f98798 [stock-txn-asst] No need for the amount message to be a warning. 2023-06-29 12:11:19 -07:00
John Ralls
67515497f7 [stock-txn-asst] finish_cb needs to create the transaction.
And StockAssistantModel::create_transaction doesn't need to return
the transaction.
2023-06-29 12:06:10 -07:00
John Ralls
a222efbdf3 GncOption debug messages should be in engine not app-utils. 2023-06-29 11:23:04 -07:00
Richard Cohen
52e8524ec5 Refactor: hide implementation of GncSxInstanceModel (move from .h -> .c) 2023-06-29 10:04:34 +01:00
Richard Cohen
d30fdd8071 Refactor: DECLARE_FINAL GncSxInstanceModel < GObject 2023-06-29 10:04:34 +01:00
Richard Cohen
9713683ee3 Refactor: define and use api for GncSxInstanceModel 2023-06-29 10:04:29 +01:00
Richard Cohen
697daad0bb Refactor: remove unnecessary *Private structs 2023-06-28 12:18:57 +01:00
Richard Cohen
1307e0ef75 Refactor: hide implementations (move from .h -> .c) 2023-06-28 12:18:57 +01:00
Richard Cohen
7fa32db2a7 Refactor: DECLARE_FINAL GNCSearchParamCompound < GNCSearchParam 2023-06-28 12:18:57 +01:00
Richard Cohen
f321cbc267 Refactor: DECLARE_FINAL GNCSearchParamSimple < GNCSearchParam 2023-06-28 12:18:57 +01:00
Richard Cohen
254edac26b Refactor: DECLARE_DERIVABLE GNCSearchParam < GObject 2023-06-28 12:18:57 +01:00
Richard Cohen
e094036d99 Refactor: define and use api methods for GNCSearchParam 2023-06-28 12:18:57 +01:00
Simon Arlott
663dfadb90
Fix memory leaks logging with gnc_numeric_to_string()
The value returned by gnc_numeric_to_string() needs to be freed.
Use gnc_num_dbg_to_string() instead.
2023-06-28 08:16:20 +01:00
Simon Arlott
dbf8f93be4
Fix assumption in gnc_num_dbg_to_string()
If the size of "buff" is not evenly divisible by "size" then this would
allocate off the end of the buffer. That's not currently the case but the
calculation shouldn't do this. Change it to check there's actually enough
space.
2023-06-28 08:10:13 +01:00
Simon Arlott
ab4e595670
Add failuref() test function that allows the use of format strings 2023-06-27 19:58:01 +01:00
Christopher Lam
165fcce8f5 [assistant-stock-txn] clear warnings/errors/infos before preparing last page
otherwise the messages will accumulate when nagivating back to the
last page.
2023-06-27 23:41:41 +08:00
Richard Cohen
e6701ed289 Refactor: remove unused struct pageDataTuple 2023-06-27 14:27:10 +01:00
Richard Cohen
90d1905786 Refactor: remove unnecessary *Private structs 2023-06-27 14:27:05 +01:00
Richard Cohen
86395f0c66 Refactor: hide implementations (move from .h -> .c) 2023-06-27 14:26:41 +01:00
Richard Cohen
53e8629416 Refactor: DECLARE_FINAL GncSxListTreeModelAdapter < GObject 2023-06-27 12:36:47 +01:00
Richard Cohen
f3b3fa39d1 Refactor: DECLARE_FINAL GncSxInstanceDenseCalAdapter < GObject 2023-06-27 12:36:47 +01:00
Richard Cohen
39352101ae Refactor: DECLARE_FINAL GncReportCombo < GtkBox 2023-06-27 12:36:47 +01:00
Richard Cohen
ff9ee95096 Refactor: DECLARE_FINAL GncRecurrence < GtkBox 2023-06-27 12:36:47 +01:00
Richard Cohen
734e9184e4 Refactor: DECLARE_FINAL GncPluginManager < GObject 2023-06-27 12:36:47 +01:00
Richard Cohen
df874225c0 Refactor: DECLARE_FINAL GncPeriodSelect < GtkBox 2023-06-27 12:36:47 +01:00
Richard Cohen
1fa45a352a Refactor: DECLARE_FINAL GncFrequency < GtkBox 2023-06-27 12:36:47 +01:00
Richard Cohen
1540a645fc Refactor: DECLARE_FINAL GncEmbeddedWindow < GtkBox 2023-06-27 12:36:47 +01:00
Richard Cohen
6a2c05a0f6 Refactor: DECLARE_FINAL GncDenseCalStore < GObject 2023-06-27 12:36:47 +01:00
Richard Cohen
2ffc37b675 Refactor: DECLARE_FINAL GncDenseCal < GtkBox 2023-06-27 12:36:47 +01:00
Richard Cohen
ceb21a6ace Refactor: DECLARE_FINAL GNCDateFormat < GtkBox 2023-06-27 12:36:47 +01:00
Richard Cohen
33e08df849 Refactor: DECLARE_FINAL GNCCurrencyEdit < GtkComboBox 2023-06-27 12:36:47 +01:00
Richard Cohen
e2e2adde96 Refactor: DECLARE_FINAL GncCellRendererTextView < GtkCellRendererText 2023-06-27 12:36:46 +01:00
Richard Cohen
4e3a57bea5 Refactor: DECLARE_FINAL GncCellRendererTextFlag < GtkCellRendererText 2023-06-27 12:36:46 +01:00
Richard Cohen
8115ecca88 Refactor: DECLARE_FINAL GNCAmountEdit < GtkBox 2023-06-27 12:36:46 +01:00
Richard Cohen
8f38f44239 Refactor: DECLARE_FINAL GNCAccountSel < GtkBox 2023-06-27 12:36:46 +01:00
Richard Cohen
4191c6a859 Refactor: remove unused GncRecurrenceComp 2023-06-27 12:36:46 +01:00
Richard Cohen
5b80ae0f51 Refactor: hide implementation of GOOptionMenu (move from .h -> .c) 2023-06-27 10:55:05 +01:00
Richard Cohen
aa638ccc03 Refactor: DECLARE_FINAL GOOptionMenu < GtkButton 2023-06-27 10:38:47 +01:00
Richard Cohen
02a9cf6ec3 Refactor: DECLARE_FINAL GOCharmapSel < GtkBox 2023-06-27 10:38:47 +01:00
Christopher Lam
fa3043a631 g_menu_item_new must be g_object_unreffed
Although gnome API usually insertions usually take ownership of the child
element, in this case the GMenuItem attributes are copied into the
GMenu.

From https://docs.gtk.org/gio/method.Menu.insert_item.html --

* Description

Inserts item into menu.

The “insertion” is actually done by copying all of the attribute and
link values of item and using them to form a new item within menu. As
such, item itself is not really inserted, but rather, a menu item that
is exactly the same as the one presently described by item.

This means that item is essentially useless after the insertion
occurs. Any changes you make to it are ignored unless it is inserted
again (at which point its updated values will be copied).

You should probably just free item once you’re done.

There are many convenience functions to take care of common cases. See
g_menu_insert(), g_menu_insert_section() and g_menu_insert_submenu()
as well as “prepend” and “append” variants of each of these functions.

Available since: 2.32
2023-06-27 08:56:09 +08:00
Christopher Lam
ff10b1d314 g_menu_model_iterate_item_attributes must be g_object_unreffed 2023-06-27 08:56:09 +08:00
John Ralls
aba64c9762 Fix nl.po. 2023-06-26 09:32:10 -07:00
John Ralls
e57d778992 Merge latest translations from Weblate. 2023-06-26 09:19:11 -07:00
John Ralls
0b3d3a5a68 Release GnuCash 5.3. 2023-06-26 09:04:59 -07:00
Yuri Chornoivan
8b13212005
Translation update by Yuri Chornoivan <yurchor@ukr.net> using Weblate
po/uk.po: 100.0% (5523 of 5523 strings; 0 fuzzy)
0 failing checks (0.0%)
Translation: GnuCash/Program (Ukrainian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/uk/
2023-06-26 18:00:39 +02:00
Andrea Andre
3535a0c7cf
Translation update by Andrea Andre <andrea.tsg19@slmail.me> using Weblate
po/ro.po: 47.8% (2642 of 5523 strings; 1941 fuzzy)
743 failing checks (13.4%)
Translation: GnuCash/Program (Romanian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/ro/
2023-06-26 18:00:37 +02:00
Stephan Paternotte
2782efc18d
Translation update by Stephan Paternotte <stephan@paternottes.net> using Weblate
po/nl.po: 93.2% (5152 of 5523 strings; 250 fuzzy)
96 failing checks (1.7%)
Translation: GnuCash/Program (Dutch)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/nl/
2023-06-26 18:00:35 +02:00
Giuseppe Foti
b43efa6441
Translation update by Giuseppe Foti <foti.giuseppe@gmail.com> using Weblate
po/it.po: 95.1% (5257 of 5523 strings; 175 fuzzy)
72 failing checks (1.3%)
Translation: GnuCash/Program (Italian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/it/
2023-06-26 18:00:33 +02:00
mocsa
f97279619d
Translation update by mocsa <csaba@feltoltve.hu> using Weblate
po/hu.po: 69.4% (3833 of 5523 strings; 635 fuzzy)
5 failing checks (0.1%)
Translation: GnuCash/Program (Hungarian)
Translate-URL: https://hosted.weblate.org/projects/gnucash/gnucash/hu/
2023-06-26 18:00:30 +02:00