Commit Graph

20007 Commits

Author SHA1 Message Date
Geert Janssens
69fef8277f Revert "Add preference to control toolbar appearance"
This reverts commit 3b09313107.
2018-07-31 17:30:07 +02:00
Geert Janssens
fe371534c2 Revert "Add toolbar preference changes to embedded-window."
This reverts commit a75eb4c8ec.
2018-07-31 17:29:52 +02:00
Geert Janssens
2203118d99 Revert "Add the toolbar preference changes to window-reconcile."
This reverts commit 0199fef584.
2018-07-31 17:29:38 +02:00
John Ralls
accd154eb0 Don't run test-stress-options.scm if no textual-ports.
ice-9 textual ports, required by test-stress-options, was introduced
in guile 2.2. We still support using guile-2.0.
2018-07-27 15:58:46 -07:00
John Ralls
d6b245772e Fix out-of-order declarations.
Broke Travis.
2018-07-23 15:22:51 -07:00
John Ralls
216528c130 Merge Bob Fewell's 'fixes8' into maint. 2018-07-23 14:51:01 -07:00
John Ralls
9cb00f8fe4 Merge Di Mang's 'maint-transfer-02' into maint.
Leaving the MAX_TAB_COUNT at 6, so no "further expansion room".
2018-07-23 14:47:51 -07:00
John Ralls
9993e0ce29 Almost completely remove Timespec from import-export.
KvpValue doesn't have a time64 type so aqb-kvp still needs to use
Timespec internally.
2018-07-23 14:39:20 -07:00
John Ralls
1131aa6fc4 Clean up jenny's whitespace. 2018-07-23 12:48:52 -07:00
John Ralls
40680369f6 Fix up jenny so that it complies with std=C11. 2018-07-23 12:47:54 -07:00
John Ralls
827c43d935 Add jenny to the dist and compile it. 2018-07-23 12:47:25 -07:00
John Ralls
6d605762dd Delete the last vestiges of timepair. 2018-07-23 12:00:54 -07:00
John Ralls
773b070345 Don't set transaction properties via scheme in C code. 2018-07-23 12:00:12 -07:00
Robert Fewell
64778fcad5 Fix error when options dialogue is open when app closed
With the options dialogue open when Gnucash is closed this error is
logged in the trace file, gnc_close_gui_component() component not found.

This is fixed by reversing the components list found for session so the
options dialogue is closed before the report window.
2018-07-22 13:07:57 +01:00
Robert Fewell
5c90f677e5 Remove some white space and tabs from dialog-options.c 2018-07-22 13:07:57 +01:00
Robert Fewell
5ad584ca3b Change the Options dialogue to use GtkWindow
Change the report / book options dialogue from a GtkDialog to GtkWindow.
This removes the need for setting the transient parent which allows the
dialogue to be placed behind the main application when changing values
making it easier to see the result.
2018-07-22 13:07:57 +01:00
Robert Fewell
8edf447808 Drop the tree model before updating transaction association tree view
To avoid delays with large transaction associations trees, drop the
model from the transaction association tree view while it is being
updated and then reconnect it after the model has been updated.
2018-07-22 13:07:57 +01:00
Robert Fewell
d343934101 Change the transaction association dialogue
Change the transaction association dialogue from a GtkDialog to
GtkWindow. This removes the need for setting the transient parent which
allows the dialogue to be placed behind the main application when
jumping to the transaction while the dialogue is still open.
2018-07-22 13:07:57 +01:00
Robert Fewell
1ea4310f8c Add a column for Tax related to find account dialogue 2018-07-22 13:07:57 +01:00
Robert Fewell
85bb778610 Drop the tree model before update find account tree view
To avoid delays with large account trees, drop the model from the find
account tree view while it is being updated and then reconnect it after
the model has been updated.
2018-07-22 13:07:57 +01:00
Robert Fewell
193176cc25 Change find-account from GtkDialog to GtkWindow
Change the find account dialogue from a GtkDialog to GtkWindow. This
removes the need for setting the transient parent which allows the
dialogue to be placed behind the main application when jumping to the
account if the the tick box to keep the dialogue open is used.
2018-07-22 13:07:57 +01:00
Robert Fewell
93030c61f1 Bug 796762 - Scrollbar partially hides the delete button in
the Saved Report Configurations window

The vertical scrollbar obscures the delete button in the tree view so
add a dummy blank column to the end and set it to the width of the
vertical scrollbar.
2018-07-22 13:07:57 +01:00
Di Mang
697d2a166f
unify appearance in preferences dialog
The reports and other windows based on GtkNotebooks have currently max. 6 tabs in preferences dialog. 
Changing the value MAX_TAB_COUNT to 6 will unify appearance in all such dialogs. But to consider future changes, it would be useful to add a few extra places for new tabs: MAX_TAB_COUNT = 8.
2018-07-18 22:08:11 +02:00
John Ralls
fa1b4c685f Add jenny to sources for combinatorics testing. 2018-07-16 14:08:24 -07:00
John Ralls
6f1c63dbda Merge Chris Lam's 'maint-stress-tests' into maint. 2018-07-16 12:52:01 -07:00
John Ralls
c444729db5 Bug 796755 - buggy window handling at startup
Defer showing the main window until after its size and location are
restored from the state file.
2018-07-16 10:09:34 -07:00
Christopher Lam
294e113fec Small typo fix
Fixes typo in a51be5157c
2018-07-16 18:51:37 +08:00
Christopher Lam
414ab99aa0 [test-stress-options] Set COMBINATORICS to full path to jenny
Setting COMBINATORICS to the full path name to jenny will enable
pairwise testing.

e.g. COMBINATORICS=/home/user/jenny/jenny ninja check
2018-07-16 18:51:37 +08:00
Christopher Lam
b8ce2b545a [stress-test] run tests on empty book and populated book
Refactor (tests) into call (create-test-data) which will add sample
txns in the environment.

As a result we can run tests twice - once before and once
after (create-test-data) which helps dislodge a few more report bugs.
2018-07-16 18:51:37 +08:00
Christopher Lam
aa4da810c1 [test-stress-options] introduce combinatorial testing
This is enabled if the environment variable COMBINATORICS exists.
I guess it can be run via:

COMBINATORICS=bla ninja check
2018-07-16 18:51:37 +08:00
Christopher Lam
dfe1f34573 [stress-test] stress test options! 2018-07-16 18:51:37 +08:00
Christopher Lam
694d0f0613 [budget-flow] fix report-title not defined
this report uses reportname instead
2018-07-16 18:18:25 +08:00
Christopher Lam
57c6f175b4 [html-chart] num-columns return 0 for empty-table
this commit fixes whereby data is '() indicating no columns
2018-07-16 18:18:25 +08:00
Christopher Lam
e2907844be [customer-summary] prevents crash on empty-book with no accounts 2018-07-16 18:18:25 +08:00
John Ralls
ff91056ab1 Resolve ubuntu 14.04 naming conflict. 2018-07-15 16:55:55 -07:00
John Ralls
a51be5157c Add preference for forcing prices to decimal display.
Anticipating that some users might prefer to see exact prices,
add a preference to General>Numbers to configure whether prices
are rounded to decimals or are displayed as exact fractions.
2018-07-15 14:18:01 -07:00
John Ralls
1fffbaf856 Bug 794755 - Commodity Register displays fractional prices
When printing numbers convert them to a new decimal denominator with
rounding if the passed-in print info specifies that they should be
forced and rounded.

Make the default price settings forced and rounded.

Pass the price currency to gnc_default_price_print_info and
use the currency's fraction * 100 to determine the round-to
denominator and the number of decimal places to display.
2018-07-15 13:20:21 -07:00
John Ralls
374477c360 Merge Bob Fewell's 'color-accounts' into maint. 2018-07-15 10:47:19 -07:00
Robert Fewell
8c4a5adb43 Align the Reconcile totals in the Reconcile Window.
This change aligns the totals with the account column by obtaining the
reconcile column width and adjusting the label padding. This is done at
initial display so it does not track column resizing or the use of the
scrollbar.
2018-07-15 10:45:45 -07:00
Robert Fewell
b95981e6af Bug 796751 - reconcile window usability - R column should be...
next to Amount.

With the use of the previous update the original order is possible as
the scrollbar is not hovering over the reconcile tick box
2018-07-15 10:44:23 -07:00
Robert Fewell
aa77b21dfb Reconcile vertical scrollbars hover over tree view data
In the reconcile window the vertical scrollbars when selected obscure
the tree view data so get the width of the scrollbar and add it to the
cell renderer x padding of the last column.
2018-07-15 10:44:17 -07:00
Robert Fewell
c513d78846 Remove white space and tabs from gnc-main-window.c 2018-07-15 10:44:16 -07:00
Robert Fewell
0199fef584 Add the toolbar preference changes to window-reconcile.
Fixes Bug 796739 - Toolbar buttons have no labels, part 3 of 3.
2018-07-15 10:43:44 -07:00
Robert Fewell
a75eb4c8ec Add toolbar preference changes to embedded-window.
Fixes Bug 796739 - Toolbar buttons have no labels, part 2 of 3.
2018-07-15 10:42:54 -07:00
Robert Fewell
3b09313107 Add preference to control toolbar appearance
Add preferences to select icon size and item layout on the toolbar.
Fixes Bug 796739 - Toolbar buttons have no labels, part 1 of 3.
2018-07-15 10:40:41 -07:00
Robert Fewell
3e37b87997 Bug 796669 - Dark Theme Text Colors Hard to Read
Only add the register-foreground class when using Gnucash built in
colours. When this setting not used, the foreground colour by default
will be what ever the theme has set and will be down to the user to
over ride along with the other register colours.
2018-07-15 10:39:50 -07:00
Robert Fewell
36dc2acd4a Remove some white space and replace tabs with spaces. 2018-07-15 16:45:41 +01:00
Robert Fewell
0e4898fe0a Add the ability to cascade account colours in account tree
Add the ability to select an account that has sub-accounts and use that
accounts colour on all sub accounts. By default only sub accounts that
do not have a colour set are updated but there is an option to over ride
 this.
2018-07-15 16:44:50 +01:00
John Ralls
43af50bd8a Bug 796759 - --add-price-quotes <sql file> leaves a lock on the file.
First, save isn't necessary if the book is dirty, so don't... but that
means that the book has to be marked dirty after a session swap. No more
laziness.

Second, regardless of the outcome of inner_main_add_price_quotes the
session must be destroyed to remove the lock.

A couple of cleanups in QofSessionImpl::save as well: Rewrote the
descriptive comment to reflect how it really works when the backend has
gotten disconnected and removed the superfluous qof_book_set_backend
with the backend that we'd *just gotten from the book*.
2018-07-14 17:09:22 -07:00
Di Mang
4c8f822c12 Increase of MAX_TAB_COUNT to change appearance of dialog "Book Options" in german language.
The dialog "Book Options" looks in german different, because it has 5 tabs: four standard tabs and additionaly one tab for tax settings, which appears only for german language. The 1 to 4 tabs appearance on top (horizontal mode). The appearance switchs to vertical mode (with tabs on the left side) for 5 and more tabs. Here the setting MAX_TAB_COUNT is increased to 5. This change should make the dialog similar in german and other languages.
2018-07-14 21:45:28 +02:00