Commit Graph

26722 Commits

Author SHA1 Message Date
John Ralls
7bb14b9caa Merge Richard Cohen's 'use-reference-for-loop' into master 2023-02-02 14:32:14 -08:00
John Ralls
d4d5f26970 Merge Richard Cohen's 'build-cleanup' into master 2023-02-02 14:21:27 -08:00
John Ralls
f8fe461cdf Merge Richard Cohen's 'replace-deprecated-gtk' into master 2023-02-02 14:19:37 -08:00
John Ralls
12db8eaaf2 Merge Bob Fewell's 'bug753307master' into master. 2023-02-02 13:58:26 -08:00
Robert Fewell
cbf39074c2 Remove the old preference setting for default invoice report
Remove preference setting and set the schema to be depreciated in
version 5000 and removed in version 6000.
2023-02-02 14:05:53 +00:00
Robert Fewell
07f3f536cc Allow to select saved report on print invoice button
This change was inspired by mildred's #PR1247 and uses the new
GncReportCombo to allow selection of 'Saved Invoice reports' when the
invoice print button is used or when printing multiple invoices.

This change presents a dialog with the default for the report combo set
to the properties setting. This dialog has a timeout which is
adjustable under properties and will stop if a key is pressed or combo
popped so that a different report template can be selected and used.
There is also an 'OK' button that stops the time out and prints and a
'Cancel' button which cancels the print.
2023-02-02 14:05:53 +00:00
Robert Fewell
b41e491ec5 Modify proposed code to use new GncReportCombo widget. 2023-02-02 14:05:46 +00:00
Robert Fewell
b49b5c86bb Create a new widget GncReportCombo to list reports
This widget will provide a combo and populate a model with guids, names
and a warning value that controls the visibility of a warning image.
2023-02-02 14:04:50 +00:00
Robert Fewell
019214f1c2 Bug753307 - Custom Report be selectable as default Report for Printing
This commit changes the preference in Business->'Report for Printing'
to be saved as a book property and allow the selection of any Invoice
Report to be used as the default.
2023-02-01 16:29:11 +00:00
Richard Cohen
d91d270a76 Replace deprecated (since 2.38) g_simple_action_group_lookup
with g_action_map_lookup_action
2023-01-31 17:53:11 +00:00
Richard Cohen
e3515185d3 Make the cmake command lowercase 2023-01-31 16:25:12 +00:00
Richard Cohen
351990cf47 Remove unused GNOME cmake flags
There are no longer any Gnome dependencies
2023-01-31 16:25:03 +00:00
Richard Cohen
dbdb5cb9d1 Remove unused GNUCASH_LATEST_STABLE_SERIES 2023-01-31 16:16:48 +00:00
Richard Cohen
d8f45f2443 Use const references for for-loops to avoid unnecessary copies
Found by clazy - clazy-range-loop-reference
2023-01-31 14:44:57 +00:00
Robert Fewell
63f8e73142 Fix sensitivity of invoice toolbar buttons
In gnc_plugin_page_invoice_update_menus change the location of saving
the is_posted and can_post values and remove saving of is_readonly.
2023-01-31 13:37:20 +00:00
Robert Fewell
30d2b97252 Fix toolbar Print action for invoices 2023-01-31 13:24:00 +00:00
Robert Fewell
2fc63d6244 Fix horizontal alignment of options labels to be GTK_ALIGN_END 2023-01-30 15:05:43 +00:00
Geert Janssens
ea95580b42 Merge branch 'maint' 2023-01-30 14:26:05 +01:00
Geert Janssens
8a167d186b Payment dialog - always list all possible post accounts
Before only the post account in the currency of the selected
vendor or customer was available.

This was reported in bug 797487n comment 17.
2023-01-30 13:48:19 +01:00
Geert Janssens
849aea31ef Bug 797477 - Manual foreign transaction from APAR to another doesn't trigger price input 2023-01-30 12:07:39 +01:00
Christopher Lam
119356752f Merge branch 'maint' 2023-01-30 09:56:13 +08:00
Geert Janssens
5bbfb8efd4 Add proper indent to scheme changes from previous commit
Committed seperately to make it easier to look at the actual changes.
This commit only adds a 2 space indent to one function body.
2023-01-29 23:11:49 +01:00
Geert Janssens
34ed91eac9 Bug 798734 - Aging Reports don't handle mixed currency payments and invoices without Trading Accounts
Revisit the fix. It still made assumptions about the way
payment transactions were created. It can now handle
payment transaction either in the payment account
currency or in the post account currency.
2023-01-29 23:09:06 +01:00
Geert Janssens
894f8241e1 Revisit invoice payment in multi-currency context
- Show proper amount in dialog when applying or editing an existing transaction as payment
- Be more careful not to waste the existing payment split
- If the user changed the payment amount while starting from an existing transaction
  unreconcile the changed payment split
- Avoid needlessly changing transaction currency (only do so if the user chose
  a new transfer account and the old currency is neither the new transfer account's
  currency nor the post account's currency)
2023-01-29 23:09:06 +01:00
Geert Janssens
2d3d05068d Edit/assign payment - be more prudent not to lose data
We can't handle the case where a transaction has splits in more than one
APAR account. Instead of only warning that some of them will be lost
refuse to continue and leave it to the user to fix the transaction first.
2023-01-29 23:09:06 +01:00
Geert Janssens
8e6fb15d44 Improve a few messages related to business payments 2023-01-29 23:09:06 +01:00
Geert Janssens
dd50c7af13 Multi-currency - show split amount rather than transaction value
This issue was found while evaluating bug 798734, but not
the immediate topic of that bug.
2023-01-29 23:09:06 +01:00
Christopher Lam
34be3c8b14 [report-utilities] use fold for gnc:accounts-count-splits
previous definition would build intermediate lists for each step. also
handles the null account-list.
2023-01-29 23:51:31 +08:00
Robert Fewell
8a02f168b0 Fix wrong toolbar label and menu entry for stock assistant 2023-01-29 11:40:44 +00:00
Robert Fewell
cbb3bd4618 Fix ability to start stock assistant from account tree. 2023-01-29 11:40:05 +00:00
Robert Fewell
b44f0c67be Change the alignment of a couple of widgets in the stock
assistant
2023-01-29 11:39:21 +00:00
Robert Fewell
4b226c574b Change some alignment in source file assistant-csv-price-import.c 2023-01-29 11:38:25 +00:00
Robert Fewell
9889712be5 Block CSV price import separator call backs while buttons updated
When the individual CSV separator buttons were being updated, the
associated call could be triggered several times. To stop this, block
the call back for the individual buttons when they are updated and call
it at the end.
2023-01-29 11:37:29 +00:00
Robert Fewell
a94ca11ba7 Configuration not properly saved for CSV price import
The trailing lines value was not being saved properly.
2023-01-29 11:36:42 +00:00
Robert Fewell
7bc4e0370d Add widget names to import dialogs so they can be manipulated with css 2023-01-29 11:35:57 +00:00
Robert Fewell
b85afa790f Only test for linked document glyths once per register
Change the function gnc_split_register_load to run the test for glyths
only on first pass.
2023-01-29 11:32:50 +00:00
Robert Fewell
4741ee355b Change normalize mode in a couple of places
To be consistent, change the normalize mode in gnc-account-sel and
gnc-account-edit to G_NORMALIZE_NFC which is used in other locations.
2023-01-29 11:02:15 +00:00
Geert Janssens
3a6d1ea663 Bug 798737 - Minor grammatical error - 'for' missing in 'You will be asked a conversion rate for each.' 2023-01-29 10:14:38 +01:00
Christopher Lam
e615a5775a Bug 798734 - Aging Reports don't handle mixed currency payments and invoices without Trading Accounts 2023-01-28 20:53:24 +08:00
John Ralls
44f4b55927 Merge Richard Cohen's 'fix-memleaks' into master. 2023-01-26 12:52:21 -08:00
John Ralls
09b0bfe8b9 Merge Richard Cohen's 'reinstate-tests' into master. 2023-01-26 12:48:08 -08:00
John Ralls
f8465dadf4 Fix a pair of missed extern "C" decls. 2023-01-26 12:45:10 -08:00
Richard Cohen
846e75146a Fix some typos so that the correct tests are run
- test_gnc_txn_to_float_txn_cut_semantics
- test_dbi_business_store_and_reload
2023-01-26 15:42:13 +00:00
Richard Cohen
5be5c58b4f Fix memory leak in aqbanking 2023-01-26 14:37:05 +00:00
Richard Cohen
619f62fb0e Fix memory leak in gnc-split-reg.c 2023-01-26 14:36:58 +00:00
Richard Cohen
671f14f68a Fix memory leak in import-main-matcher.c 2023-01-26 14:36:52 +00:00
Richard Cohen
a2ffc7fe75 Fix memory leak in binreloc function _br_find_exe()
Ironically, it seems to be in a code path that
is only followed when using valgrind
2023-01-26 14:36:43 +00:00
luzpaz
67ab9e90d2 Fix some typos 2023-01-26 13:48:58 +01:00
Christopher Lam
17820ec261 Merge branch 'maint' 2023-01-26 18:40:44 +08:00
John Ralls
4739e8ce04 Merge Bob Fewell's 'bug798475' into master. 2023-01-24 13:36:50 -08:00