Commit Graph

20429 Commits

Author SHA1 Message Date
Robert Fewell
82d0fa187b Add some space to the budget options
Add some space to the budget options on the left so they are not right
next to the border. Also add a note to specify where the visibility of
accounts is found.
2018-12-24 13:00:14 +00:00
Robert Fewell
bd0e532415 Remove some white space and tabs in dialog-search.c 2018-12-24 13:00:14 +00:00
Robert Fewell
952761afa6 Bug 796945 - Search Search Criteria window does not scroll when added criteria exceed a certain amount
Add the criteria grid to a viewport and scroll window as suggested in
bug report. Also needed to add the hiding of the new scroll window as
required.
2018-12-24 13:00:14 +00:00
Robert Fewell
a8d0270e5a Disallow tabs in GtkTextView in glade files
Disallow the use of tabs in all glade GtkTextView's. This is mainly
used for notes fields and showing log entries. Some views were not
editable but for consistency the setting was also added to them.
2018-12-24 13:00:14 +00:00
Robert Fewell
5c524c31b2 Add routine to fix Account Color being set to "Not Set"
Previously the account color slot has been populated with "Not Set"
when any field for the account has been edited and saved. This routine
should run once and remove all such entries.
2018-12-24 13:00:07 +00:00
Robert Fewell
43beeca079 Change the way colours are imported by the CSV account tree importer
When importing the account tree CSV file, change the importing of
colours so that only valid colours for accounts are updated, invalid
colours will result in the account color key slot being removed.
2018-12-22 18:16:17 +00:00
Robert Fewell
7a1f981b0c Change the sensitivity of the Cascade colour menu option
Enable the cascade colour menu setting only when the account being
cascaded from has sub-accounts.
2018-12-22 18:16:17 +00:00
Robert Fewell
fad17da72b Bug 796887 - Remove account slot key color if there is no valid color
If an existing account colour was specified and subsequently removed
the color key would be "Not Set". Change this to remove the key when
the colour is changed to default, i.e. removed.
2018-12-22 18:16:08 +00:00
Geert Janssens
9921ab22a2 Merge branch 'fixes02' of https://github.com/Bob-IT/gnucash into maint 2018-12-09 13:15:27 +01:00
Frank H. Ellenberger
353a3812aa Fix another may be used uninitialized warning 2018-12-07 11:55:30 +01:00
Kalev Lember
ff5e7657d5 Fixes to the appdata file
Rename the ID from org.gnucash.Gnucash to org.gnucash.GnuCash to match
flathub, and add a launchable ID to link it to the desktop file.
2018-12-06 09:16:41 +01:00
Christoph Holtermann
96e27a4199 typo 2018-12-04 12:05:59 +01:00
Robert Fewell
c3dae07d83 Disallow tabs in the account notes field.
While using the tab key to navigate the fields of the edit account
dialogue, it stops in the notes field as it accepts tabs so by
disallowing use keyboard navigation can proceed.
2018-12-03 11:33:54 +00:00
Robert Fewell
5bc6922c14 Bug 796944 - Tab navigation From Company Address field in New Book Options
Disallow the use of tabs in all dialogue options text views. This is
mainly used for notes fields and CSS so should not really be an issue.
2018-12-03 10:55:36 +00:00
Robert Fewell
9e104ebc40 Bug 796948 - Scheduled Transactions Entered Since Last Run Are not Visible
Add a call to gnc_gui_refresh_all after the transactions have been
created so the registers are updated.
2018-12-02 14:16:24 +00:00
Robert Fewell
03da6116bf Bug 796886 - OFX Import does not show source account in the transaction matching window
If there is more than one account source in the import it makes it
difficult to allocate the transactions so add a toggle button to show
or hide the source account column with the default being that of the
calling function.
2018-12-02 14:16:24 +00:00
Robert Fewell
51ab6e7804 Bug796960 - Incorrect amount sort order in Generic import matcher window
The amount column was being sorted by string as opposed to amount value.
Added a DOUBLE value to the model store to hold a converted gnc_numeric
amount value and use that for sorting the tree view amount column. Also
made the amount column right justified so numbers align.
2018-12-02 14:15:07 +00:00
Robert Fewell
34e84fda85 Add ability to double click on file name for csv-trans-import 2018-12-02 11:25:37 +00:00
Robert Fewell
48b0739942 Add ability to double click on file name for csv-price-import 2018-12-02 11:25:37 +00:00
Robert Fewell
3321462123 Add ability to double click on file name for csv-account-import 2018-12-02 11:25:37 +00:00
Robert Fewell
31fcb76414 Add ability to double click on file name for csv-export 2018-12-02 11:25:27 +00:00
Robert Fewell
8c904edc25 Use existing page references instead of getting them in csv-export 2018-12-01 12:25:11 +00:00
Robert Fewell
0c58f78bdf Remove window reference and use assistant instead for csv-export 2018-12-01 12:23:18 +00:00
Robert Fewell
d9d24a9055 Missed adding new parent window parameter
Added a GtkWindow parameter to csv_import_read_file to pass to the
error dialogue but missed actually adding it.
2018-12-01 10:58:15 +00:00
Robert Fewell
a671e34134 Add some space to a previous alignment change
Add some space to the fixed width labels in the price and transaction
importer glade files.
2018-12-01 10:53:43 +00:00
Robert Fewell
3abd04321d okbutton may be used uninitialised in gnc-file.c 2018-12-01 10:46:19 +00:00
John Ralls
519880545b Fix missing screen for GLib < 3.22. 2018-11-30 17:10:10 +09:00
John Ralls
5dcb44d991 Fix regex in CMakeLists.txt.
Apparently CMake doesn't handle backslashes well and \.
doesn't work in spite of its being an example in the documentation.
2018-11-30 16:40:35 +09:00
John Ralls
e434835f68 Remove special Apple compile flags, no longer required. 2018-11-30 16:23:30 +09:00
John Ralls
3f09e5c6f1 Only disable register warnings for SWIG 2.
SWIG 3 has removed the register storage class markers.
2018-11-30 16:11:42 +09:00
John Ralls
e81bcf6e33 Fix the remaining static analysis warnings.
Except two incorrect leak warnings and one about mktemp
 being insecure in the XML backend. See the respective
comments about those.
2018-11-30 15:08:41 +09:00
John Ralls
bf55c30aeb Fix most of the unused assignment errors from static analysis.
There are a very few left that need deeper study, but this gets
rid of most of the noise. For the most part it's just getting rid of
extra variables or removing an assignment that is always
replaced later but before any reads of the variable. A few are
discarded result variables.
2018-11-30 15:08:41 +09:00
John Ralls
a93448414f Fix another uninitialized variable in register.
Found by clang static analyzer.
2018-11-30 15:08:41 +09:00
John Ralls
f52609961e Fix uninitialized variables (and one leak) in gnome.
Found by clang static analyzer.
2018-11-30 15:08:41 +09:00
John Ralls
185787d7be Initialize some gnc_numerics that could be returned uninitialized.
Found by clang static analyzer.
2018-11-30 15:08:41 +09:00
John Ralls
8ed9a9c43a Initialize some variables that could be otherwise used uninitialized.
Found by clang static analyzer.
2018-11-30 15:08:41 +09:00
John Ralls
7e10b05c49 Avoid over-ranging string storage.
Found by clang static analyzer.
2018-11-30 15:08:41 +09:00
John Ralls
7283c86f6f Fix various static analysis logic errors in gnome-utils. 2018-11-30 15:08:41 +09:00
John Ralls
876bfd19ad Protect against nullptr dereference, remove unused GError.
Found by clang static analyzer.
2018-11-30 15:08:41 +09:00
John Ralls
24ce92056d Protect from potential nullptr dereferences.
pmtsched is created in only one banch of the opening switch.
Found by clang static analyzer.
2018-11-30 15:08:41 +09:00
John Ralls
8f22c4bed4 Localize variables, ensure that val_imbalance is set, test txn_curr != commodity once.
Found by clang static analyzer.
2018-11-30 15:08:41 +09:00
John Ralls
4ffeb3efac Ensure that a dereferenced variable isn't NULL.
Found by clang static analyzer.
2018-11-30 15:08:41 +09:00
John Ralls
43a30e1c97 Silence clang static analyzer complaint about potential div by 0.
It can't, because if b is 0 the function would have
returned already; since b.m_hi is 0 b.m_lo can't be. The assert
reassures clang that this is the case.
2018-11-30 15:08:41 +09:00
John Ralls
3d1362757b Prevent potential undefined behavior by shifting by a wrapped uint.
Found by clang static analyzer.
2018-11-30 15:08:41 +09:00
John Ralls
606d9cfee6 Prevent potential nullptr dereference.
Found by clang static analyzer.
2018-11-30 15:08:41 +09:00
John Ralls
faba7975ac Fix a bunch of memory allocation errors found by clang static analysis. 2018-11-30 15:08:41 +09:00
Geert Janssens
de6c173ef4 Merge branch 'Bug796896' of https://github.com/Bob-IT/gnucash into maint 2018-11-28 14:21:16 +01:00
John Ralls
61cd7999f3 Fix half-up, half-down, and banker's rounding for negative numbers.
We need to compare the magnitudes of the remainder and the denominator
in order to round negative numbers correctly. Note that while gnc_numeric
is constrained to a positive denominator the C++ rounding functions cannot
assume that constraint in all cases.

Combined with the previous commit, this fixes
Bug 796949 - Incorrect conversion of 0,01 USD to EUR
2018-11-27 22:17:22 +09:00
John Ralls
536606a89c Fix extract_common_prices logic.
So that the returned price tuple has the two commodities of interest
converted to a common currency. Before the first pair that that shared
any random currency would be returned, perhaps creating an absurd result.
2018-11-27 22:17:22 +09:00
Robert Fewell
458dac89fe Bug 779565 - Treeview header combos do not work at first load
When the csv preview page is first loaded the header combo will not
work till refreshed which can be done by selecting another separator.

By adding a g_idle_add to the preview_page_prepare to rebuild the table
the combos become active.
2018-11-26 17:26:58 +00:00