There are errors when closing the application to do with gnc_uri when
trying to create a filename from an empty book_id value to update the
page title. Added a test for empty book_id as well as it being null.
When the format is set to unset, the kvp data will now be removed and
added a function to retrieve the 'Fancy Date Format' and test for it
being valid, if not retrieve the preference date format.
There is a requirement to delete the "Fancy Date Format" book KVP data
when set to unset. This was not possible as is as it would delete all
the 'Business' options. This is still possible by passing a null list.
Update category-barchart.scm to use new pair for plot width and height
setting default to be both 100% of view. Also updated html-barchart.scm
and html-linechart.scm to use these new values.
Actually two problems; first, save_may_clobber_data returned the reverse
of what it should have and second, the backend's m_book (which pointed
to the old book) wasn't nulled so there was a mismatch at save time
preventing the save from taking place. Then, when quitting GnuCash, the
cleanup found the old m_book pointer and tried to use it, causing a
memory protection crash.
Adds GncDbiSqlConnection::drop_indexes, changes GncDbiSqlConnection::table_operation
to use a regex-filtered table list from the DbiConn, and converts TableOpType
to a C++ enum.
To qof-backend.hpp and qof-backend.cpp respectively, to reflect that they
implement the QofBackend class (which won’t be a class until a future commit).
Instead split the string in a formatter string with one parameter. This avoids
the need to remember to update the string and its translations
each time the saved-report's file format is bumped.
This is about as far as I can go on the SQL/DBI backend without changes
to QofBackend, QofQuery, QofInstance, and the engine classes. The XML
backend needs the same OO treatment before that's possible, so that's
the next stage.
Fixing incorrect implementation in gnc-bill-term-sql and gnc-tax-table-sql,
where there was no test for the parent actually having been loaded.
Also #ifdef-out the starting balances part of GncSqlAccountBackend::load_all
and move its variable decls inside the ifdef as auto.
