Commit Graph

22580 Commits

Author SHA1 Message Date
John Ralls
8ff5af4c19 Decouple QofBook creation from QofSession.
So that we don't create two books when loading a session.
Step 1 to not having a dirty book when we think we should have no
book at all.
2020-05-08 15:59:41 -07:00
Mike Alexander
0a4347bd5e Initially select the last account chosen in the account picker dialogs.
Separately keeps track of last investment account, security account,
and income account.  One issue is that gnc_import_select_account
doesn't tell the caller if it put up a dialog or found the online ID
on an existing account.  This means the last account may be one the
user didn't manually select.  This may or may not be the right thing
to do.
2020-05-08 17:07:50 -04:00
Mike Alexander
a4e35f3cea Remove some globals by moving them into the struct passed to callbacks.
No functional changes.
2020-05-08 17:07:21 -04:00
Mike Alexander
478112d8c0 Define log_module in gnc-sx-instance-model.c. 2020-05-08 16:43:45 -04:00
Mike Alexander
870c02b092 Add a newline to the GNC_DBD_DIR line in the environment file. 2020-05-08 16:41:58 -04:00
Robert Fewell
32e1917017 Transaction matcher dialogue was not closing when changing book. 2020-05-08 14:19:47 +01:00
Robert Fewell
6013cb6b14 Correct parent widget for import new account dialog. 2020-05-08 14:19:47 +01:00
Robert Fewell
d74225f6c0 Change layout of source file dialog-billterms.c
Remove tabs and spaces in source file.
2020-05-08 14:19:47 +01:00
Robert Fewell
49eee35a89 No Selection on load for Bill Terms
Change the selection process so it selects the first entry if present
on load and also selects a newly created entry when completed.
2020-05-08 14:19:47 +01:00
Robert Fewell
c4e41384f2 Bug 797689 - Change the Bill Terms Table dialogue to be based on a
GtkWindow

When using Gnucash on Microsoft Windows and a dialog opens a further
dialog when you switch away from the application and back the last
dialog that has the focus is behind the parent and it appears like the
application has froze. To fix this try to use only one level of dialogue
so change the Bill Terms Table to use a Window with no transient parent.
2020-05-08 14:19:39 +01:00
Robert Fewell
881f89addf Change layout of source file dialog-tax-tables.c
Remove tabs and spaces in source file.
2020-05-08 14:05:02 +01:00
Robert Fewell
8500f36c44 Change the Tax Table dialogue to be based on a GtkWindow
When using Gnucash on Microsoft Windows and a dialog opens a further
dialog when you switch away from the application and back the last
dialog that has the focus is behind the parent and it appears like the
application has froze. To fix this try to use only one level of dialogue
 so change the Tax Table to use a GtkWindow with no transient parent.
2020-05-08 14:03:53 +01:00
Robert Fewell
ccc1247e25 Align the import matcher help button
Move the import matcher help button to the left in the CSV transaction
importer.
2020-05-08 14:02:46 +01:00
John Ralls
20d53cc765 Merge branch 'maint' 2020-05-07 13:05:50 -07:00
John Ralls
601aec8ca0 Fix LIBDBI_DRIVERS_DIR generation.
Reusing the variable in a get_filename_component call caused the
function to recurse to /, not very useful.

Also re-do GNC_DBD_DIR with no default but to take its value from the
command line or environment.
2020-05-07 13:02:54 -07:00
John Ralls
6141592d40 Don't mutate the cached global account list store.
That defeats the purpose of caching it and causes problems when using it
from two registers at once. Instead use the PopBox tmp_store for listing
the type-ahead match results if any.

Since a no-match causes an empty ItemList and an empty ItemList with
grab loses key events because there's no cell to handle them--very
confusing to the user--prevent that by checking that there are entries
before grabbing.
2020-05-07 12:05:45 -07:00
John Ralls
534bcd6c1b Clean up some leftover noise from the ime-fix branch. 2020-05-07 11:45:46 -07:00
Frank H. Ellenberger
dc8f1057ce Use more precise strings in gnc-split-reg.c
You can edit the account very well, but not its transactions.
2020-05-06 17:48:25 +02:00
Thomas Schärli
404357a81c L10N🇩🇪 "Für" klein in "Ergebnisrechnung für Periode" etc. 2020-05-05 23:23:46 +02:00
Frank H. Ellenberger
fb18e457b4 I18N: Msgmerge recent changes 2020-05-05 23:12:21 +02:00
Frank H. Ellenberger
e447af04e3 I18N: Hotfix for bug 797725
Add a translator comment
2020-05-05 21:55:48 +02:00
Thomas Schärli
79910e8439 L10N:de_CH: Ein weiterer Tippfehler im Kontenrahmen KMU 2020-05-05 20:23:30 +02:00
John Ralls
650f7901cd Fix build on Ubuntu-18.04. 2020-05-04 19:47:34 -07:00
John Ralls
7461cc2ace Merge John Ralls's 'ime-fix' into master. 2020-05-04 14:36:30 -07:00
John Ralls
fd05616b38 Bug 797052 - Autofill Selection is Corrupted After Clicking Description
Ignore modifier keypresses.
2020-05-04 14:35:02 -07:00
John Ralls
3475939bd7 Use the GtkEntry's GtkIMContext instead of creating one for the sheet.
Bug 797264 - 3.5 can't use Chinese IME input
Bug 797329 - Using Japanese IME to enter transactions results in
unexpected field jumps
2020-05-04 13:31:08 -07:00
John Ralls
faacd96d32 Extract functions make_new_text, delete_text, insert_text, normalize_bounds
Replacing inefficient and incorrect GString implementation.
2020-05-04 12:23:23 -07:00
Christopher Lam
fb5dd034b7 [test-stress-options] fix combinatorics testing
Premise: pairwise combinatorics testing is only possible when all
options have at least 2 options.

The "General Journal" report is unique because it starts with the
Transaction Report options generator, and adds a few hidden
options. Unfortunately the Transaction Report receives the
"General/Stylesheet" option, with only 1 default stylesheet.

The General Journal report therefore has 1 stylesheet option with only
1 choice, and is not acceptable to jenny for pairwise testing. It
would fail the combinatorics testing. Adding other stylesheets did not
successfully allow pairwise testing. Therefore the simplest way to
test General Journal is to disable multichoice testing whereby
num(choices) is only 1.
2020-05-05 01:03:14 +08:00
Christopher Lam
a9a60c1831 [Account.cpp] more xaccAccountTypeGetFundamental types 2020-05-04 23:35:06 +08:00
Christopher Lam
14ea5d9751 Merge branch 'maint' 2020-05-04 23:31:21 +08:00
John Ralls
98a4d63af2 Extract function pass_to_entry_handler. 2020-05-03 14:16:31 -07:00
John Ralls
6470ecbde1 Extract function process_motion_keys. 2020-05-03 14:16:31 -07:00
John Ralls
d8b4a4ad19 Extract several functions for managing GtkEntry position and selection
GncTable uses separate values for entry position, selection start, and
selection end while GtkEntry maintains only position and selection
bound. These functions provide for a consistent bridge between the two.
2020-05-03 14:16:31 -07:00
Robert Fewell
e5e7b30f7a Merge Chris Good's branch 'bug797688RecAddSubAcct', PR #709 into master 2020-05-03 12:39:58 +01:00
Robert Fewell
7483d50141 Merge Chris Good's branch 'bug797236RecMas', PR #707 into master 2020-05-03 12:11:57 +01:00
Robert Fewell
2fae14c3ba Merge Chris Good's branch 'bug797648Rec-2', PR #713 into maint 2020-05-03 11:52:07 +01:00
Robert Fewell
5ed6b424dd Merge Jean Laroche's branch 'fix_seg_fault_in_matcher' into maint 2020-05-03 11:12:58 +01:00
jean
92e9e60cd0 Fix the crash that occurs when opening a new book when the transaction-matching dialog has been opened then closed. 2020-05-02 21:20:55 -07:00
Christopher Lam
2f0639235a Bug 797707 - CSV Transaction Export: custom dates should be insensitive by default
By default the absolute date selector needs to be made
insensitive. Selecting 'Custom Start/End date' will enable
sensitivity.
2020-05-03 11:47:57 +08:00
John Ralls
6a3fabc30d Fix test failure for timezones west of the prime meridian.
The previous fix didn't calculate the comparison time correctly and
ended up in the wrong day because the GMT time is before the local time.

In the course of checking the corner-case timezones (Midway and
Kiritimati) I found an error in the GncDateTime calculation of the
neutral time, so fixed that too.
2020-05-02 15:35:13 -07:00
John Ralls
0ea1135201 Relocate some static functions to avoid pre-declaring them. 2020-05-02 10:23:15 -07:00
John Ralls
2f65edc029 Extract Function gnucash_sheet_set_entry_value. 2020-05-02 10:22:30 -07:00
Geert Janssens
ca9d58b278 Display report zoom factor with one decimal space.
The code actually allowed fractional scaling, but the display of the option didn't.
As a result the spin button was acting oddly.
This was discovered while looking into bug
https://bugs.gnucash.org/show_bug.cgi?id=797712 but this commit is not a fix for that bug.
2020-05-02 18:11:12 +02:00
goodvibes2
f1c2e339fc Bug 797648 Redo - Reconciliation - Treat each split independently
The previous change under this bug which propagated the status
change (reconcile or unreconcile) of any split for the account to
be reconciled (and its subaccounts) in a transaction, to all
splits for the account to be reconciled (and its subaccounts) in
the transaction, is incorrect. Each split needs to be able to be
checked or unchecked independently of any other split in the
transaction.
2020-05-02 16:43:49 +10:00
goodvibes2
327544e6c0 Revert "Bug 797648 - Fix problem reconciling multiple splits in a transaction"
This reverts commit dd589060a3.
2020-05-02 16:11:50 +10:00
goodvibes2
4759453356 Revert "Use Doxygen format for function comment"
This reverts commit d2986559de.
2020-05-02 16:10:19 +10:00
goodvibes2
3d2974d97e Fix 2 comment typos in gnucash/gnome/window-reconcile.c 2020-05-02 11:54:17 +10:00
goodvibes2
9faba45fd5 Reconcile window - Retain position in split list after deletion
The changes for Bug 797236 so that the last selected split is
visible when the list is refreshed has no effect when the Delete
button is used, as the selected split has been deleted.
So preselect the next split after the split to be deleted.
If no next split in the list, select the previous.
The split preselected must have a different parent transaction to
the split to be deleted, as all splits in the transaction will be
deleted.
2020-05-02 11:54:17 +10:00
goodvibes2
79501e58dd Bug 797236 - Reconciliation - Retain visibility of selected split.
Ensure selected split (or last selected if multiples selected), is
visible after all operations when the list is refreshed.
2020-05-02 11:54:17 +10:00
John Ralls
41762b295c No need for a separate decl and def of a static inline function.
Especially on consecutive lines.
2020-05-01 16:29:06 -07:00