Commit Graph

21672 Commits

Author SHA1 Message Date
Christopher Lam
0ab0d23b00 Bug 797418 - In budget report, column with Actual Totals for Liabilities and Income are reversed
budget.scm had some cleanup whereby totals were accumulated but are
now re-retrieved. Forgot to reverse actuals for some account signs
reversals.
2019-09-20 11:12:37 +08:00
Christopher Lam
656d2718d8 [trial-balance] compact (collect-unrealized-gains)
use functional style
2019-09-19 21:53:09 +08:00
Christopher Lam
6b573de128 [trial-balance] use coll-plus and coll-minus for functional style 2019-09-19 21:53:09 +08:00
Christopher Lam
acf359a797 [trial-balance] upgrade coll-plus and coll-minus to report-wide fns 2019-09-19 21:53:09 +08:00
Christopher Lam
f88c54bb50 [trial-balance] use gnc:commodity-collector-get-negated 2019-09-19 21:49:13 +08:00
Christopher Lam
0c9c9c2594 [test-trial-balance] augment to test unrealized gains
these were already tested -- see previous tests *do* include
'unrealized losses'. augment by adding another couple foreign transfer
to change the unrealized gain/loss amount.
2019-09-19 21:45:07 +08:00
Christopher Lam
16da1acf1d Merge branch 'typos1' of git://github.com/luzpaz/gnucash into luzpaz-typos1 2019-09-18 21:36:29 +08:00
Christopher Lam
5344cbc7ae [reports] delete unused exports code. 2019-09-18 21:35:53 +08:00
Christian Stimming
6ae7cdc8f2 [i18n] German translation update
Especially in the CSV import.
Total: 5308 translated, 28 fuzzy, 22 untranslated.
2019-09-17 22:31:27 +02:00
Christian Stimming
ccaaa14187 [aqbanking] Again use aqbanking version number for new function instead of cmake_symbol_check
This reverts commit adae341d, "Use cmake_symbol_check to test for
AB_Banking_RuntimeConfig_SetCharValue". We received multiple reports
that the cmake check fails and the behaviour unexpectedly does not use
the new function. As this is completely counter-intuitive as long as the
new-enough aqbanking version are there, we better just stick
to the aqbanking version numbers, especially because this function is used
only in exactly one place here.
2019-09-17 22:09:47 +02:00
Christian Stimming
67069ff6a6 [aqbanking] Fix non-const return argument in aqbanking6 that we must free ourselves. 2019-09-17 21:54:46 +02:00
Geert Janssens
f1bab7af40 Set component type in appdata metadata
Required for flathub integration.
2019-09-17 11:54:34 +02:00
Christian Stimming
50e59077d7 [aqbanking] Keep transaction purpose conversion
With the newest (beta) aqbanking versions there is a renamed
version of the previous getter of the txn purpose available, which
had been switched to a different semantic in between.
2019-09-15 22:15:58 +02:00
Christopher Lam
ec5b110936 [trial-balance] compact function
use functional instead of accumulator style to handle
adjusting/closing debit/credit amounts.
2019-09-14 16:20:00 +08:00
Christopher Lam
268e9670e2 [trial-balance] rewrite to omit account-get-pos-trans-total-interval
Reuse adjusting-splits and filter for positive values.

This function was buggy... see total-query is defined as the
output of qof-query-merge-in-place, or qof-query-destroy, both
returning #unspecified; this fails when passed to qof-query-run.
2019-09-14 15:35:47 +08:00
Christopher Lam
0ec82872b0 [trial-balance] speedup: retrieve closing/adjusting splits once
only 2 qof-query at the start, instead of 2 qof-query per account
2019-09-14 14:35:14 +08:00
Christopher Lam
6e12bf81a9 [trial-balance] *untabify/delete-trailing-whitespace/reindent*
global reindent
2019-09-14 14:24:00 +08:00
Christopher Lam
525bcd39ed [test-trial-balance] initial commit
this is not yet 100% coverage, but is adequate to test upcoming
changes to adjusting and closing balance calculators.
2019-09-14 14:23:38 +08:00
luz.paz
cfc7cef7d6 gnucash/gtkbuilder source typo found 2019-09-13 20:28:14 -04:00
luz.paz
f6c96f9fe8 Fix typos for gnucash/report
Found via `codespell -q 3 -D ~/Projects/codespell/codespell_lib/data/dictionary.txt -S *.po,./po,*.min.js,./ChangeLog*,./NEWS,./doc/README*,./AUTHORS,./libgnucash/tax/us/txf-de*,./data/accounts -L ans,cas,dragable,gae,iff,iif,mut,nd,numer,startd,stoll`
2019-09-13 20:26:59 -04:00
luz.paz
65bb60d621 Fix typos for gnuchash/ doc/ bindings/ and misc.
Typos found via `codespell -q 3 -D ~/Projects/codespell/codespell_lib/data/dictionary.txt -S *.po,./po,*.min.js,./ChangeLog*,./NEWS,./doc/README*,./AUTHORS,./libgnucash/tax/us/txf-de*,./data/accounts -L ans,cas,dragable,gae,iff,iif,mut,nd,numer,startd,stoll`
2019-09-13 20:26:03 -04:00
Matthew Forbis
c675b5b5e4 Fix incorrect signature error with Cmake >= 3.6 and Webkit1. 2019-09-13 10:52:28 -07:00
Christopher Lam
355d28e721 [trial-balance] fix qof-query-destroy
qof-query-destroy inv-query never previously triggered. fix. also map
output is discarded, it's more readable to use for-each.
2019-09-13 23:38:16 +08:00
Christopher Lam
26a9ccc181 Bug 797408 - Find Transaction Window -> Search Criteria Section -> Add Search Criteria -> Section does not expand to new size to include a newly added Search Criteria 2019-09-13 18:54:46 +08:00
Christopher Lam
da655cfaa9 [balsheet-pnl] ensure txns on last report-date are processed
bugfix. after writing commit message to 23d0fa132, I had to verify the
strong statement regarding txns on last report-date, and found that I
was incorrect. ensure txns are previously accounted for.
2019-09-13 18:54:46 +08:00
John Ralls
41c58ec00a Convert Gtk3 and Webkit to imported targets.
This causes CMake to include their headers with -isystem instead of -I,
so the compiler doesn't generate warnings on them. ArchLinux was failing
to build because of such warnings.

Includes a function from cmake 3.6 to allow this to work on systems like
Ubuntu 14.04 that still provide only cmake 3.5.
2019-09-12 21:20:29 -07:00
John Ralls
c23f3f05e3 Fix deprecated G_TYPE_INSTANCE_GET_PRIVATE and G_INLINE_FUNC
with the function/declaration that they substituted.
Note that this doesn't use the recommended new GObject creation macros
because the class names in libgnucash/engine don't follow the gnome
naming convention.
2019-09-12 15:25:42 -07:00
Geert Janssens
70eb7172d5 Drop special case for old cmake versions
We require 3.5 which is more recent than 3.3
2019-09-12 22:54:24 +02:00
Geert Janssens
82b3af9695 Change scheme file compile command invocation
This
* adds normal double quotes around the guild function call
* removes escaped quotes from paths
* add 'VERBATIM' keyword to let cmake perform its own escape logic on the commands

Verified to work on Windows and linux with both ninja and make.
2019-09-12 22:54:24 +02:00
Geert Janssens
84dede1ab7 Remove leaked work in progress file from POTFILES.in 2019-09-12 22:54:24 +02:00
Christopher Lam
23d0fa1324 [balsheet-pnl] bugfix last pnl period must not be decreased by 1 day
logic error to calculate last period date pair for col-header.

pnl report-dates are stored as a list of time64. consider a regular
profit&loss for "quarterly income & expense amounts for last
calendar year". dates are 1-jan to 31-dec. the report-dates are
'(1-jan 1-apr 1-jul 1-oct 31-dec). the inc/exp accounts balances are
queried for the above dates, and the delta change (sans closing
entries) constitutes the desired answer.

the col-header needs to report "1-jan to 31-mar", which it does by
retrieving 2 consecutive dates in the list (1-jan 1-apr), then
decrease second date by 1 day to obtain "1-jan to 31-mar" . however
this fails for the last period which would return '1-oct to 30-dec'.

this commit changes display for last period to return last report-date
so that the header is fixed to '1-oct to 31-dec'.

this is cosmetic for header dates only, calculations of periodic
income/expense amounts were never affected and included entries on the
last report-date (e.g. 31-dec as above).
2019-09-11 20:30:13 +08:00
Christopher Lam
7a36c229c5 [balsheet-pnl] speed up by pre-appending accounts
minor efficiency change. append-reverse is faster than append, and
storing the appended lists is rather convenient for this
report which uses them a lot.
2019-09-11 20:30:13 +08:00
Christopher Lam
70cb3a0b97 [utilities] compact sort-and-delete-duplicates
This is still readable IMHO. kons is the result constructor, and adds
item to result iff different from previous add.
2019-09-11 20:30:13 +08:00
Christopher Lam
ff8c5725cd [test-extras] rewrite strip-string to avoid repeat string-append
this is marginally more efficient, by keeping a list of (shared)
substrings, and only concatenating them when returning the stripped
string.
2019-09-11 20:30:13 +08:00
Christopher Lam
b05c57a948 [html-acct-table] compact functions 2019-09-11 20:30:13 +08:00
Amish
e8e18915ea
Allow edit of some fields for posted invoice
Allow editing of some fields for posted invoice.

For reasons, see bug report:
https://bugs.gnucash.org/show_bug.cgi?id=797400

Reverts some changes done to fix:
https://bugs.gnucash.org/show_bug.cgi?id=797168
2019-09-10 17:03:46 +05:30
Frank H. Ellenberger
d3f86d2adf Merge branch 'PR579' into maint 2019-09-10 02:49:36 +02:00
Frank H. Ellenberger
a91b3ff453 PR #579: update Project-Id-Version of he.po
5358 translated messages.
2019-09-10 02:48:26 +02:00
Frank H. Ellenberger
fa4fc551af Remove obsolete "disambiguation prefix" translator comments
https://lists.gnucash.org/pipermail/gnucash-devel/2019-September/044199.html

Continuation of commit d30fe7a
2019-09-10 00:13:01 +02:00
John Ralls
e6e2258a74 Bug 797356 - ninja check fails with GCC-9 2019-09-09 14:44:10 -07:00
avma
4cd9f5a605
Update he.po to v3.7 2019-09-09 13:17:11 +03:00
Christian Stimming
b1d0dd7d58 [i18n] Update German translation
In particular, the single-character translations changed by
984d583e are now fixed again.

5301 translated, 38 fuzzy, 19 untranslated.
2019-09-08 22:14:02 +02:00
Christian Stimming
cce252713f [i18n] update (msgmerge) German translation 2019-09-08 21:59:26 +02:00
John Ralls
86f41542ff Fix a couple of typos in DOCUMENTERS. 2019-09-07 17:34:31 -07:00
John Ralls
84cfc5743b Release GnuCash 3.7 2019-09-07 16:38:10 -07:00
John Ralls
4392c92cc5 Update Ukrainian translation from the translation project. 2019-09-07 16:38:10 -07:00
Frank H. Ellenberger
92bae3fe3e [I18N] Bug 797349 - "A"ssociate header badly translated
A few more messages
2019-09-07 19:36:10 +02:00
Christopher Lam
a940434e5c [taxinvoice] comments were interfering with i18n. remove 2019-09-07 16:31:08 +08:00
Christopher Lam
656dddc166 [html-acct-table] compact formals definitions
use fewer conditionals, improve readability
2019-09-07 16:31:08 +08:00
Christopher Lam
228e5f47a8 Bug 796952 - Report formatting (justify) is broken
Remove the "minus 1" to amount-depth for some accounts with children
and display-amount is 'immediate-bal. This means amounts are now
strictly(*) indented according to account depth instead of a weird
formula if account-has-children and immediate-bal.

(*) when subtotal-mode isn't "canonically tabbed"
2019-09-07 15:51:25 +08:00